Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PM] bfcc1e67ff:
 kernel-selftests.breakpoints.step_after_suspend_test.fail
To:     Florian Fainelli <f.fainelli@gmail.com>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        <lkp@lists.01.org>, <lkp@intel.com>,
        kernel test robot <oliver.sang@intel.com>,
        Linux PM <linux-pm@vger.kernel.org>
References: <20211014075731.GB18719@xsang-OptiPlex-9020>
 <51c0a15f-1941-f161-dcec-a7a9acc726f2@gmail.com>
 <e526de16-5efd-6474-20e1-3f96a2e3c524@intel.com>
 <6755cf07-fa5a-cbb7-c076-57c162a08c99@gmail.com>
 <d3cf18f1-2af7-5e4d-abe4-c882f25bd5c3@intel.com>
 <20aedfba-14e3-3677-d21a-b87610095445@gmail.com>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
Message-ID: <d36f79b4-472c-4852-7370-a011f9f556ce@intel.com>
Date:   Tue, 19 Oct 2021 20:53:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.14.0
In-Reply-To: <20aedfba-14e3-3677-d21a-b87610095445@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFdpQUVlay9uK0JJTXVyQ2xiSWVidmlKditvSVI5YkRVd3JmczZiZHhPQWRU?=
 =?utf-8?B?MXNCa0R3c0hmL1lOc25rK0p6SzZjbEZsS1lJUGhUWDIwNndkTldWa0VvYWY1?=
 =?utf-8?B?TTlKZzNkK1ZsYWdmb21tRHhTU2VSY2dZQ1RzNzBJUTF2QkpxNHlpSC95dHFx?=
 =?utf-8?B?Z0w1TGF3L01Ba0V6UTV5UCtWakRyYUttV0RIVXhtTXo4enYxMzgvZkVqd0do?=
 =?utf-8?B?SVFWVkFYZGpXNm1iYUNybnVsRXV6ZThjU2NPN09DdlJsY21IYWoyZy95WGJW?=
 =?utf-8?B?d3g0YkxqaGh5SVZqQ1d4U3VIYUNMVk9YQ1FFSlc0aDZveFhKbUYyU3VvZkRa?=
 =?utf-8?B?OHZHSGtsR3pLMTJIZXdOUzVyRWxseDRoNXNsV3J5VDlzZndrRndydjFRZFcx?=
 =?utf-8?B?QnFOV3RjTXFwQkRaYzRSNEtjc2FQUmJnNXdmdmN0SFE0NmVOY2tweFhxMUdm?=
 =?utf-8?B?Wk5xV3BQYXlsRU8vc2FlRXB3MFZYcVkrckFoSXdrczZNK2ZmVXVYcDhvdDVJ?=
 =?utf-8?B?aWpqcEhWYmRaMmcwZERObU9Pc0s5clNMeUZhL3ByN3dCTlQyWDVrMytQQ2Z0?=
 =?utf-8?B?RlNPVlJPS3M2SDBZbVBRL0g0V1QydTVvbHVwSElvNDFPekRHR0hDZjJ1V2xL?=
 =?utf-8?B?NmFVeFpWMHdXRWo5dmVLNkxJOElSRHNINDdKdVhEblF5cVZlWlkzemJDWEk2?=
 =?utf-8?B?dlh2ZUNtcmxadEZJVTFnUlFYcFk2RUh5TTlUdlp3Sm43dFAydVdUVE1lSFZj?=
 =?utf-8?B?Z2R6MGwwanhUS3Y0VnlTYmVFZDdyU2JiQW82YjBsZm5wTzBVQUhFYld2UWw3?=
 =?utf-8?B?MXphaDJ5SXNNQ0tJV1R5YlIvV1pweENiSmQ5bDhhZXBwWEVIWHlPRGVGcE1y?=
 =?utf-8?B?dTZ2WkhxU3J6UW5lbm1COGFFYytFdHI4Q0F3WTBRbTlsOHo3d3Q2T0k1aTZG?=
 =?utf-8?B?bFFFSDBqVlROT3pFcnFDRUkzbU5WL21ScDhtc1k2bWxrQTlFWDlpTnNjQ1ZS?=
 =?utf-8?B?MEZ6RGttK2k4K1BUcnd1TDVrbjNNUFZIWnVDekNRUFQzL01TK0RXaXZlclJU?=
 =?utf-8?B?TjFCZjN6VkVEQ2JTY0ZqOGFuY0NqWFpQQit4VFBUZkRCeGdhai9Hb1NIOWdM?=
 =?utf-8?B?TElvbFNydWNhTGR0T0ZFbzladmV2azJ2ZGFQSWtxZHVEZmZtcHJQTGpWRHdH?=
 =?utf-8?B?UUx2aUxWTk1obzhhWFhWMEtTdTRobmVSWmJGZmVWKzV6UERtUUlTcVc1QnlE?=
 =?utf-8?B?Z0kwWFI3MGYxMENCMDc1UXVaOEo0aWtuYTdyN2JOUUVjZmZqeG1XNDNldWVI?=
 =?utf-8?B?emtTbUlOZ3JLTTE1ZVNqeHNwa0lRcW41aWR0bGl4MGVROXppWnJrMGlXUTVv?=
 =?utf-8?B?VURuS3Q2UFZDaFZ5eUdMVWhHYUJaRUVXVlQ2UmxpQ2JPRlVQMkJCeXh4SHRK?=
 =?utf-8?B?OU5WV0pKSndpdS8zcDVyUWU5d3hpUnRTRTQxQStXeWMvNmFDUTR5cGVVazFs?=
 =?utf-8?B?TEF5QllEcDJRRVBZVEFXYWcyTThjY2hXYjY1SnhCUC9BUjNQZ0VaVmZiZnhI?=
 =?utf-8?B?RDl4ZkhubVpCTFppS0ZkWHJxNUtXbXZXbmM5bFJmY2FZeHp4Q0Z6TFRlNGQy?=
 =?utf-8?B?cS9uV2pwUFNCbkdFTDJpWnQ2L3lYNUFNZkpQRjUycjB1VHpPWFhoWXNPZkNB?=
 =?utf-8?B?bjRXQko0MTFLbXBwVGIra3ZTTS95Q1g5OElNMTlWNlN1ZHMyd0JQbFNQTnJ6?=
 =?utf-8?Q?LigtJ3WQMD2Ko1pnPZEOLEx0Lbp1zEj5eaMvDJo?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4759353e-a700-4fa6-505e-08d99331ce93
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5326.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 18:53:58.2477
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KeIx9eyoJ4tdYO76jwvU7f76fkyDS6/bfsfC9wTVQIuVan7zex/IfxKk5XXV8uvXtypDjPL+nb3hiZc8U3xVuYPLBf+M38FYhsBN5yrJmxo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1595
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/15/2021 9:40 PM, Florian Fainelli wrote:
> On 10/15/21 11:45 AM, Rafael J. Wysocki wrote:
>> On 10/14/2021 11:55 PM, Florian Fainelli wrote:
>>> On 10/14/21 12:23 PM, Rafael J. Wysocki wrote:
>>>> On 10/14/2021 6:26 PM, Florian Fainelli wrote:
>>>>> On 10/14/21 12:57 AM, kernel test robot wrote:
>>>>>> Greeting,
>>>>>>
>>>>>> FYI, we noticed the following commit (built with gcc-9):
>>>>>>
>>>>>> commit: bfcc1e67ff1e4aa8bfe2ca57f99390fc284c799d ("PM: sleep: Do not
>>>>>> assume that "mem" is always present")
>>>>>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git
>>>>>> master
>>>>>>
>>>>>>
>>>>>> in testcase: kernel-selftests
>>>>>> version: kernel-selftests-x86_64-c8c9111a-1_20210929
>>>>>> with following parameters:
>>>>>>
>>>>>>       group: group-00
>>>>>>       ucode: 0x11
>>>>>>
>>>>>> test-description: The kernel contains a set of "self tests" under the
>>>>>> tools/testing/selftests/ directory. These are intended to be small
>>>>>> unit tests to exercise individual code paths in the kernel.
>>>>>> test-url: https://www.kernel.org/doc/Documentation/kselftest.txt
>>>>>>
>>>>>>
>>>>>> on test machine: 288 threads 2 sockets Intel(R) Xeon Phi(TM) CPU 7295
>>>>>> @ 1.50GHz with 80G memory
>>>>>>
>>>>>> caused below changes (please refer to attached dmesg/kmsg for entire
>>>>>> log/backtrace):
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> If you fix the issue, kindly add following tag
>>>>>> Reported-by: kernel test robot <oliver.sang@intel.com>
>>>>> Thanks for your report. Assuming that the code responsible for
>>>>> registering the suspend operations is drivers/acpi/sleep.c for your
>>>>> platform, and that acpi_sleep_suspend_setup() iterated over all
>>>>> possible
>>>>> sleep states, your platform must somehow be returning that
>>>>> ACPI_STATE_S3
>>>>> is not a supported state somehow?
>>>>>
>>>>> Rafael have you ever encountered something like that?
>>>> Yes, there are systems with ACPI that don't support S3.
>>> OK and do you know what happens when we enter suspend with "mem" in
>>> those cases? Do we immediately return because ultimately the firmware
>>> does not support ACPI S3?
>> "mem" should not be present in the list of available strings then, so it
>> should be rejected right away.
> Well yes, that was the purpose of the patch I submitted, but assuming
> that we did provide "mem" as one of the possible standby modes even
> though that was wrong (before patch), and the test was trying to enter
> ACPI S3 standby, what would have happened, would the ACPI firmware honor
> the request but return an error, or would it actually enter ACPI S3?
>
> In any case, I will change the test to check that this is a supported
> standby mode before trying it.

Unfortunately, I will need to revert bfcc1e67ff1e4aa8bfe2, because it 
breaks user space compatibility and that's got caught properly by the test.

What happens is that "mem" is a "pointer" to a secondary list of 
possible states and that generally is "s2idle shallow deep" and if 
s2idle is the only available option, it will be just "s2idle".

This list is there in /sys/power/mem_sleep.

It was done this way, because some variants of user space expect "mem" 
to be always present and don't recognize "freeze" properly.

Sorry for the confusion.