Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211018183709.124744-1-erik@kryo.se> <20211019191806.csewm7p26x3imk25@gmail.com>
In-Reply-To: <20211019191806.csewm7p26x3imk25@gmail.com>
From:   Erik Ekman <erik@kryo.se>
Date:   Tue, 19 Oct 2021 22:09:15 +0200
Message-ID: <CAGgu=sDimxN7=mW+JeTRTxDLUCq875DnaAFwx_SkfJwUgO_fdA@mail.gmail.com>
Subject: Re: [PATCH] sfc: Export fibre-specific link modes for 1/10G
To:     Erik Ekman <erik@kryo.se>, Edward Cree <ecree.xilinx@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 19 Oct 2021 at 21:18, Martin Habets <habetsm.xilinx@gmail.com> wrote:
>
> On Mon, Oct 18, 2021 at 08:37:08PM +0200, Erik Ekman wrote:
> > These modes were added to ethtool.h in 5711a98221443 ("net: ethtool: add support
> > for 1000BaseX and missing 10G link modes") back in 2016.
> >
> > Only setting CR mode for 10G, similar to how 25/40/50/100G modes are set up.
> >
> > Tested using SFN5122F-R7 (with 2 SFP+ ports) and a 1000BASE-BX10 SFP module.
> > Before:
> >
> > $ ethtool ext
> > Settings for ext:
> >       Supported ports: [ FIBRE ]
> >       Supported link modes:   1000baseT/Full
> >                               10000baseT/Full
> >       Supported pause frame use: Symmetric Receive-only
> >       Supports auto-negotiation: No
> >       Supported FEC modes: Not reported
> >       Advertised link modes:  Not reported
> >       Advertised pause frame use: No
> >       Advertised auto-negotiation: No
> >       Advertised FEC modes: Not reported
> >       Link partner advertised link modes:  Not reported
> >       Link partner advertised pause frame use: No
> >       Link partner advertised auto-negotiation: No
> >       Link partner advertised FEC modes: Not reported
> >       Speed: 1000Mb/s
> >       Duplex: Full
> >       Auto-negotiation: off
> >       Port: FIBRE
> >       PHYAD: 255
> >       Transceiver: internal
> >         Current message level: 0x000020f7 (8439)
> >                                drv probe link ifdown ifup rx_err tx_err hw
> >       Link detected: yes
> >
> > After:
> >
> > $ ethtool ext
> > Settings for ext:
> >       Supported ports: [ FIBRE ]
> >       Supported link modes:   1000baseX/Full
> >                               10000baseCR/Full
> >       Supported pause frame use: Symmetric Receive-only
> >       Supports auto-negotiation: No
> >       Supported FEC modes: Not reported
> >       Advertised link modes:  Not reported
> >       Advertised pause frame use: No
> >       Advertised auto-negotiation: No
> >       Advertised FEC modes: Not reported
> >       Link partner advertised link modes:  Not reported
> >       Link partner advertised pause frame use: No
> >       Link partner advertised auto-negotiation: No
> >       Link partner advertised FEC modes: Not reported
> >       Speed: 1000Mb/s
> >       Duplex: Full
> >       Auto-negotiation: off
> >       Port: FIBRE
> >       PHYAD: 255
> >       Transceiver: internal
> >       Supports Wake-on: g
> >       Wake-on: d
> >         Current message level: 0x000020f7 (8439)
> >                                drv probe link ifdown ifup rx_err tx_err hw
> >       Link detected: yes
> >
> > Signed-off-by: Erik Ekman <erik@kryo.se>
>
> Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
>

I will send a v2 patch with more modes marked supported.

/Erik