Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1634280441-4248-1-git-send-email-wangqing@vivo.com>
In-Reply-To: <1634280441-4248-1-git-send-email-wangqing@vivo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 19 Oct 2021 16:33:20 -0400
Message-ID: <CADnq5_PVZ_nFA=adGMXyBsMHMVV6JhDYTDN9sk7rVuKsTZDfYw@mail.gmail.com>
Subject: Re: [PATCH] amdgpu: replace snprintf in show functions with sysfs_emit
To:     Qing Wang <wangqing@vivo.com>
Cc:     Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  thanks!

On Fri, Oct 15, 2021 at 2:48 AM Qing Wang <wangqing@vivo.com> wrote:
>
> show() must not use snprintf() when formatting the value to be
> returned to user space.
>
> Fix the following coccicheck warning:
> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c:427:
> WARNING: use scnprintf or sprintf.
>
> Signed-off-by: Qing Wang <wangqing@vivo.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> index 2834981..faf4011 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
> @@ -424,7 +424,7 @@ static ssize_t show_##name(struct device *dev,                              \
>         struct drm_device *ddev = dev_get_drvdata(dev);                 \
>         struct amdgpu_device *adev = drm_to_adev(ddev);                 \
>                                                                         \
> -       return snprintf(buf, PAGE_SIZE, "0x%08x\n", adev->field);       \
> +       return sysfs_emit(buf, "0x%08x\n", adev->field);        \
>  }                                                                      \
>  static DEVICE_ATTR(name, mode, show_##name, NULL)
>
> --
> 2.7.4
>