Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Oct 2021 16:48:34 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Kalesh Singh <kaleshsingh@google.com>
Cc:     surenb@google.com, hridya@google.com, namhyung@kernel.org,
        Jonathan Corbet <corbet@lwn.net>,
        Ingo Molnar <mingo@redhat.com>, Shuah Khan <shuah@kernel.org>,
        Tom Zanussi <zanussi@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/5] tracing: Add support for creating hist trigger
 variables from literal
Message-ID: <20211019164834.465b2a53@gandalf.local.home>
In-Reply-To: <20210915195306.612966-2-kaleshsingh@google.com>
References: <20210915195306.612966-1-kaleshsingh@google.com>
        <20210915195306.612966-2-kaleshsingh@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 15 Sep 2021 19:52:45 +0000
Kalesh Singh <kaleshsingh@google.com> wrote:

> Currently hist trigger expressions don't support the use of numeric
> literals:
> 	e.g. echo 'hist:keys=common_pid:x=$y-1234'
> 		--> is not valid expression syntax  
> 
> Having the ability to use numeric constants in hist triggers supports
> a wider range of expressions for creating variables.

I'm not against the patch, but I'm curious to what use case this would be
useful for. In the cover letter it mentions the division and multiplication
for finding associated buckets, but what is the addition / subtraction used
for?

-- Steve


> 
> Add support for creating trace event histogram variables from numeric
> literals.
> 
> 	e.g. echo 'hist:keys=common_pid:x=1234,y=size-1024' >> event/trigger
> 
> A negative numeric constant is created, using unary minus operator
> (parentheses are required).
> 
> 	e.g. echo 'hist:keys=common_pid:z=-(2)' >> event/trigger
> 
> Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
>