Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Oct 2021 16:48:05 -0500
From:   Rob Herring <robh@kernel.org>
To:     David Heidelberg <david@ixit.cz>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-input@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, ~okias/devicetree@lists.sr.ht
Subject: Re: [PATCH] dt-bindings: input: mcs-touchkey: Convert txt bindings
 to yaml
Message-ID: <YW89FX52NQNBzQ/2@robh.at.kernel.org>
References: <20211009104837.46626-1-david@ixit.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211009104837.46626-1-david@ixit.cz>
Precedence: bulk

On Sat, Oct 09, 2021 at 12:48:37PM +0200, David Heidelberg wrote:
> Convert MELFAS MCS-5000 touchscreen controller chip documentation to the YAML format.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  .../bindings/input/mcs-touchkey.txt           | 26 ---------
>  .../bindings/input/mcs-touchkey.yaml          | 53 +++++++++++++++++++
>  2 files changed, 53 insertions(+), 26 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/input/mcs-touchkey.txt

I don't have this file in my tree.

>  create mode 100644 Documentation/devicetree/bindings/input/mcs-touchkey.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/mcs-touchkey.txt b/Documentation/devicetree/bindings/input/mcs-touchkey.txt
> deleted file mode 100644
> index 545454112a43..000000000000
> --- a/Documentation/devicetree/bindings/input/mcs-touchkey.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -* mcs_touchkey MELFAS MCS5000/5080 controller
> -
> -Required properties:
> -- compatible: must be "mcs5000_touchkey" or "mcs5080_touchkey"
> -- reg : I2C address of the chip
> -- interrupts: interrupt to which the chop is connected
> -- key_maxval: size of keycode table
> -- interrupts: interrupt to which the chip is connected
> -- code: key code for this device
> -
> -Example:
> -
> -	i2c_touch_key: i2c-gpio-0 {
> -	       /* ... */
> -
> -	       touch_key@20 {
> -		       compatible = "mcs5080_touchkey";
> -		       reg = <0x20>;
> -		       interrupt-patrent = <gpj0>;
> -		       key_maxval = <2>;
> -		       linux, code = <0x0000009e
> -			              0x000000a9>;
> -	       };
> -
> -	       /* ... */
> -	};
> diff --git a/Documentation/devicetree/bindings/input/mcs-touchkey.yaml b/Documentation/devicetree/bindings/input/mcs-touchkey.yaml
> new file mode 100644
> index 000000000000..b56de0361ff8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/mcs-touchkey.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/mcs-touchkey.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MELFAS MCS5000/5080 controller
> +
> +maintainers:
> +  - Rob Herring <robh+dt@kernel.org>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - mcs5000_touchkey
> +      - mcs5080_touchkey
> +
> +  reg: true
> +  interrupts: true
> +  key_maxval:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: size of keycode table
> +
> +  linux,code:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description: key code for this device
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - linux,code
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/tegra-gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c_touch_key: i2c-gpio-0 {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      melfas-touchkey@20 {
> +        compatible = "mcs5080_touchkey";
> +        reg = <0x20>;
> +        interrupt-parent = <&gpio>;
> +        interrupts = <TEGRA_GPIO(Q, 4) IRQ_TYPE_EDGE_FALLING>;
> +        key_maxval = <4>;
> +        linux,code = <139 102 158 217>;
> +      };
> +    };
> -- 
> 2.33.0
> 
>