Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 19 Oct 2021 21:35:13 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To:     Ian Rogers <irogers@google.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>,
        Jin Yao <yao.jin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        John Garry <john.garry@huawei.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        "Paul A . Clarke" <pc@us.ibm.com>,
        Riccardo Mancini <rickyman7@gmail.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Kees Cook <keescook@chromium.org>,
        Sami Tolvanen <samitolvanen@google.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Zhen Lei <thunder.leizhen@huawei.com>,
        ToastC <mrtoastcheng@gmail.com>,
        Joakim Zhang <qiangqing.zhang@nxp.com>,
        Felix Fietkau <nbd@nbd.name>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Song Liu <songliubraving@fb.com>, Fabian Hemmer <copy@copy.sh>,
        Alexander Antonov <alexander.antonov@linux.intel.com>,
        Nicholas Fraser <nfraser@codeweavers.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Denys Zagorui <dzagorui@cisco.com>,
        Wan Jiabing <wanjiabing@vivo.com>,
        Thomas Richter <tmricht@linux.ibm.com>,
        Sumanth Korikkar <sumanthk@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Changbin Du <changbin.du@intel.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        Andrew Kilroy <andrew.kilroy@arm.com>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v2 21/21] perf metric: Allow modifiers on metrics.
User-Agent: K-9 Mail for Android
In-Reply-To: <CAP-5=fV85eOA5_vpaNSx5M8thSVvoiF+tzDmYe83TPF7Hk+0vA@mail.gmail.com>
References: <20211015172132.1162559-1-irogers@google.com> <20211015172132.1162559-22-irogers@google.com> <YW7e6OvE/juYY8it@kernel.org> <YW7gsEDXBw1jk65o@kernel.org> <YW7hdvJ8eHS/jlgx@kernel.org> <YW7htMxwcNjZOtJH@kernel.org> <CAP-5=fV85eOA5_vpaNSx5M8thSVvoiF+tzDmYe83TPF7Hk+0vA@mail.gmail.com>
Message-ID: <C9460490-184C-4BFD-BD89-063C77F17344@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On October 19, 2021 5:00:23 PM GMT-03:00, Ian Rogers <irogers@google=2Ecom=
> wrote:
>On Tue, Oct 19, 2021 at 8:18 AM Arnaldo Carvalho de Melo
><acme@kernel=2Eorg> wrote:
>>
>> Em Tue, Oct 19, 2021 at 12:17:10PM -0300, Arnaldo Carvalho de Melo escr=
eveu:
>> > Em Tue, Oct 19, 2021 at 12:13:52PM -0300, Arnaldo Carvalho de Melo es=
creveu:
>> > > Em Tue, Oct 19, 2021 at 12:06:17PM -0300, Arnaldo Carvalho de Melo =
escreveu:
>> > > > Em Fri, Oct 15, 2021 at 10:21:32AM -0700, Ian Rogers escreveu:
>> > > > > By allowing modifiers on metrics we can, for example, gather th=
e
>> > > > > same metric for kernel and user mode=2E On a SkylakeX with
>> > > > > TopDownL1 this gives:
>> > > > >
>> > > > > $ perf stat -M TopDownL1:u,TopDownL1:k -a sleep 2
>> > > > >
>> > > > >  Performance counter stats for 'system wide':
>> > > >
>> > > > Hi Ian, can you please take a look on this? this is on my perf/co=
re
>> > > > branch=2E
>> > >
>> > > I processed the first version of this series, reviewed by Andi, can=
 you
>> > > please submit the diff from one to the other?
>> >
>> > The interdiff from the 21st patch on the first batch versus on the v2
>> > batch is below, but it doesn't apply to my current perf/core branch,
>> > lemme push it to tmp=2Eperf/core=2E=2E=2E
>>
>> It was there already, what I have locally is what is in tmp=2Eperf/core=
=2E
>
>Hi Arnaldo,
>
>The last change I see in tmp=2Eperf/core is:
>https://git=2Ekernel=2Eorg/pub/scm/linux/kernel/git/acme/linux=2Egit/comm=
it/?h=3Dtmp=2Eperf/core&id=3D5f43061b84d815c0f6477c1a8836bf0c6fec15a2
>
>The difference between v2 and v1 which fixes this bug is:
>
>+@@ -1500,7 +1568,10 @@ int metricgroup__copy_metric_events(struct
>evlist *evlist, struct cgroup *cgrp,
>+                               return -ENOMEM;
>+
>+                       new_expr->metric_expr =3D old_expr->metric_expr;
>+-                      new_expr->metric_name =3D old_expr->metric_name;
>++                      new_expr->metric_name =3D strdup(old_expr->metric=
_name);
>++                      if (!new_expr->metric_name)
>++                              return -ENOMEM;
>++
>+                       new_expr->metric_unit =3D old_expr->metric_unit;
>+                       new_expr->runtime =3D old_expr->runtime;
>+
>
>I also cleaned up some checkpatch line length warnings in v2, which I
>think is the reason for the other changes=2E Ideally I'd prefer the v2
>patch set over the v1, but they are largely identical=2E Both were based
>on acme/perf/core=2E Let me know how I can help=2E
>

I'm trying not to rewrite the perf/core branch after it's made public, so =
the best at this point is to add a new patch fixing the problem, if you can=
 please send it, that would help=2E

If it was just on tmp=2Eperf/core, then it would be ok to fix it=2E

- Arnaldo