DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=HMuKD3LIAzPV3NNpy1IkRwIC2cFIS7NeOiyfR3qxWEVuAYnOw5W58hHv2WfFX9GgGzDnY+On9yydALCw+mS0+BaPzgdlAqVAjnSDHRRhnb+/1GwfICmkkUdQGGteog+sqMpdQ6MTpvINlPi3hxWK9vuCQKY8kPc8SU/wgXb2Vn0=  ;
From: David Brownell <david-b@pacbell.net>
To: Dmitry Torokhov <dtor@insightbb.com>
Subject: Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state
Date: Fri, 29 Dec 2006 12:26:46 -0800
User-Agent: KMail/1.7.1
Cc: Imre Deak <imre.deak@solidboot.com>, linux-kernel@vger.kernel.org,
       nicolas.ferre@rfo.atmel.com, tony@atomide.com
References: <20061222192536.A206A1F0CDB@adsl-69-226-248-13.dsl.pltn13.pacbell.net> <200612281437.56888.david-b@pacbell.net> <200612290122.52752.dtor@insightbb.com>
In-Reply-To: <200612290122.52752.dtor@insightbb.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200612291226.46984.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 828
Lines: 24

On Thursday 28 December 2006 10:22 pm, Dmitry Torokhov wrote:
> 
> I appied all patches except for hwmon as it had some issues with CONFIG_HWMON
> handling. Could you please take a look at the patch below and tell me if it
> works for you?

Looked OK, except:

> +#if defined(CONFIG_HWMON) || (defined(MODULE) && defined(CONFIG_HWMON_MODULE))

That idiom is more usually written

	#if defined(CONFIG_HWMON) || defined(CONFIG_HWMON_MODULE)

Thanks!  I'll be glad to see fewer versions of this driver floating around.
And to see the next version of the ads7843 patches ... :) 

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/