Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     "sathya.prakash@broadcom.com" <sathya.prakash@broadcom.com>,
        "sreekanth.reddy@broadcom.com" <sreekanth.reddy@broadcom.com>,
        "suganath-prabu.subramani@broadcom.com" 
        <suganath-prabu.subramani@broadcom.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        "MPT-FusionLinux.pdl@broadcom.com" <MPT-FusionLinux.pdl@broadcom.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: mpt3sas: make mpt3sas_dev_attrs static
Thread-Topic: [PATCH] scsi: mpt3sas: make mpt3sas_dev_attrs static
Thread-Index: AQHXxNPv7vDkNg8t/UuhyEaJblny3KvbImcA
Date:   Wed, 20 Oct 2021 01:58:52 +0000
Message-ID: <4A68DD30-1156-42F8-BBD4-DE663EC73893@oracle.com>
References: <1634639239-2892-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1634639239-2892-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ioCj9p0b/8GMwi/4iuJh5gODnowAapAH6bM0Ey2m2eTUOJkJHQQvFnfRQvCn?=
 =?us-ascii?Q?YMOkPk8qUj7v68D9bI/2HQsDAKuMwNH5cetil0rAO3wSjlFTmBx0O824KtcI?=
 =?us-ascii?Q?lN34TuCxOdgV2USVC+xTXdZq3oLGa368Yu1Req1rplMsO4up2ppkArGsPD7U?=
 =?us-ascii?Q?4pvcqhxPJ36L++5aRZ2RV0EPHIwSgi+XHkFoiXQoiNPG4CArUQse1f4Ft/W0?=
 =?us-ascii?Q?Jmq3kUJ9Qntkdt0dVuyGK1a6uH3BhFP6XIPWPws2sjH7fYox7dkjeOIul19b?=
 =?us-ascii?Q?3iDZYwY1UxXXzCxwZl1C7bWBPSPnDJdNhO/ZJDLwqkTdj/F3zJR3s05Yjo3p?=
 =?us-ascii?Q?ob1VectB1USCeiFx0qRbLmyvBGreoKCPQa529lMxWKQfXrm96Etu8/Nvgowz?=
 =?us-ascii?Q?QDY/T53iLDghAhW7NS1qux6vHZwVKruoVmufiCutmBPKlJFcS5XNCaBcXlNA?=
 =?us-ascii?Q?LcMUheGkEXXL1c4705X5TOiPfbq/O4xXabhfesLB8B5T2z4RN8+nC1L7o7iX?=
 =?us-ascii?Q?yrrNnYt6OFWF/qXbsSYJzV/kWkwIB4PGYuvLBFUmlyLsGrVOypWoO0EFmWU2?=
 =?us-ascii?Q?kdTcaXhPSsbZEVnMMepKURYZFYSeaS2SUmVdXItzqzHEBYmpb6Y+Ra2dJssh?=
 =?us-ascii?Q?jDuQAlcg8bZwNlTfB3MhtUagEdLqHJnAyZneBtG1tKQK/KpJtTaEV/F8DMse?=
 =?us-ascii?Q?IqEl8mBeLnR0uI6+aubYuukBC4L8qZioM+Q+lGBe6nq7SsW57sOC/g+hu68i?=
 =?us-ascii?Q?r5VPW36dkfR6SBpwjSVwkLQT7VSlUiR5nS2er+OZxqUxCLjEQ7BXt49cwl0J?=
 =?us-ascii?Q?xNdWrbdGroHS2oVIv0uAVqJBiXg1aY5h+sylBD2Q4P31e+6J3MeadnyyZQCV?=
 =?us-ascii?Q?UnZuyJGV4jysPtjIyf9SF9DW+VadRwV33YP9CbJxf/mOTwivdOhXLtx/KwdA?=
 =?us-ascii?Q?GpiofHCtz52kcpCjscoXltk1aRMRXvwaCRWsnF2BW8IdQ+6n/tJEmy/mZ5Ts?=
 =?us-ascii?Q?AbvYRWfqXmlB/Zs19Yfn8G1sQiFa+ntJ2Qbrdfbxb5Q6G6tNGmkhX3jnBlCu?=
 =?us-ascii?Q?tnv7KBz9tPYaf+n8nm4pzL64pHQ9Vpqrzi1dYLtE8ElWUOMuUWGPo8EJgLOk?=
 =?us-ascii?Q?inqfSPt3EKv0Bv174lEdfDzrYT21hqQXqg7tKN0vF+sVOC0YdZ24DkRKi61A?=
 =?us-ascii?Q?++Mo4sffD6gI/QO2CnLlvk9Q4ZV/suXiugg/WGMsVBSYXU7ZfiNHJDejHiGT?=
 =?us-ascii?Q?kLYQ6J4RIkXnVqvKSZFjcyqoJjHQeH930PhisL4lNfsERDbQy2ASxvjYUMQr?=
 =?us-ascii?Q?0EtOCqJQnjB1V8m7H+TUCVlMOkAqantGGDiAzfP+SqOXnw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5CA1BA5E8A334A4DB9114398ACFD53A9@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2934.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da82a356-ebfa-4093-3064-08d9936d2ad6
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 01:58:52.7585
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 14tCgyo4bwzrn5o0U+7qINPC3TyLGhuOnINoEXRaUgSibe0OEMK1KHC1UPVrh5xQvIseGtlSaf6SKT3Mf3b6PHaju8Aj7Bh/rrzd3VNn6jI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4672
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10142 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0
 spamscore=0 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110200005
X-Proofpoint-ORIG-GUID: oeTuKC3h89JXamz76lfSYuzWN-G5kCHL
X-Proofpoint-GUID: oeTuKC3h89JXamz76lfSYuzWN-G5kCHL
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Oct 19, 2021, at 5:27 AM, Jiapeng Chong <jiapeng.chong@linux.alibaba.c=
om> wrote:
>=20
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>=20
> This symbol is not used outside of mpt3sas_ctl.c, so marks it static.
>=20
> Fixes the following sparse warning:
>=20
> drivers/scsi/mpt3sas/mpt3sas_ctl.c:3988:18: warning: symbol
> 'mpt3sas_dev_attrs' was not declared. Should it be static?
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 1bb3ca27d2ca ("scsi: mpt3sas: Switch to attribute groups")
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/scsi/mpt3sas/mpt3sas_ctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mp=
t3sas_ctl.c
> index 0aabc9761be1..05b6c6a073c3 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> @@ -3985,7 +3985,7 @@ sas_ncq_prio_enable_store(struct device *dev,
> }
> static DEVICE_ATTR_RW(sas_ncq_prio_enable);
>=20
> -struct attribute *mpt3sas_dev_attrs[] =3D {
> +static struct attribute *mpt3sas_dev_attrs[] =3D {
> 	&dev_attr_sas_address.attr,
> 	&dev_attr_sas_device_handle.attr,
> 	&dev_attr_sas_ncq_prio_supported.attr,
> --=20
> 2.19.1.6.gb485710b
>=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering