Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "Weight, Russell H" <russell.h.weight@intel.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "trix@redhat.com" <trix@redhat.com>,
        "lgoncalv@redhat.com" <lgoncalv@redhat.com>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "Gerlach, Matthew" <matthew.gerlach@intel.com>
Subject: RE: [PATCH v1 0/2] fpga: dfl: Log and clear errors on driver init
Thread-Topic: [PATCH v1 0/2] fpga: dfl: Log and clear errors on driver init
Thread-Index: AQHXxT9HeMr2I/hZYUmG/Mg0WNK+PKvbSqRw
Date:   Wed, 20 Oct 2021 04:44:43 +0000
Message-ID: <DM6PR11MB3819F29DF7B20FDED6DC814685BE9@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20211019231545.47118-1-russell.h.weight@intel.com>
In-Reply-To: <20211019231545.47118-1-russell.h.weight@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.200.16
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WOEF//OppMMMNoeWXvffoddSE/WcsDhHOX8DrRlqzcvPWiasEyV8L8o2Xmdj?=
 =?us-ascii?Q?qPNTRiLALcxwL6G7l8p4mfhPSJJvXSKZ7P7cRzda6hFeyhYakvxMZ1ni2aI9?=
 =?us-ascii?Q?Sa/ZN8Pi/bKJehsqNOrpbq+IUKW6Ql3gE1pJtEvMeMbYMancemMJ7md/8xJx?=
 =?us-ascii?Q?fDPqcMpx6YL9WICgxUmf3/AYCsJD9pPy0NoHm5UTLX1ASoIJVNqlxG77fbPW?=
 =?us-ascii?Q?lXbzfnaR8iVLv5JBt8AG5qkxQZP+iL7RlqpjpPBe83gCxJrd381cQexYlwXX?=
 =?us-ascii?Q?j+peB4ZyLh1LdaxHZDG3FdzcfnWf/zi2N9p7K4vlwK16P/JXmCxaf3cbuUjI?=
 =?us-ascii?Q?yNwQNAWmC5cGWFK8eV/5umtFyA/rB7/6lwoJV7pSc4lh+0/WyaJpLCm7Ne1A?=
 =?us-ascii?Q?As8vJJ7IpkBT6VUdzKlOCck8XAxPwJbtjgHnxPcMTh88wriM+WVb94LWwzFW?=
 =?us-ascii?Q?KO3N1qhVLOi6DitK/tXtSLsMrD9ohBom8IvkyFut0b1UWlS1nDLqriepy4qh?=
 =?us-ascii?Q?TooDb4dgjUL72ZB+0mJdQY0bS3j/9WNpcnozHfGk64fk83cQw9zH5r10BWDy?=
 =?us-ascii?Q?YrO7WiV5cYHcCao8BCBgtHBwnkZZbAc1YrBUbEgDvBpVFg7NBonV9wW/ErDB?=
 =?us-ascii?Q?/0FDs+Pgzrd0bWIyMddYxM62/ZoSdflMJYdMVP2SovdII0878/gdBuyfn45n?=
 =?us-ascii?Q?Fws6PcH+9oWGEh4MxiWu7xmfkqHMHLcDdHXjEISaBp8nGbTWFQr8mNQ0D9zy?=
 =?us-ascii?Q?BcOSs1gYsDQ6zi3RHXVHcEwctgb9pZboJ+5BTQEDRLpwNCFG2wNsACrght/t?=
 =?us-ascii?Q?BKEBVha76nj2/APljoO6hqVoKAJknsSSd5HrrosG5YLsmpXx5EAHi6qPQ4VU?=
 =?us-ascii?Q?mqWcialxffLX1ioGLuu2iN3ku4mZdo9QK21PBOsMuufNr0ryr9UM6+ZXq3oZ?=
 =?us-ascii?Q?86e/hzNwMwiw0lAfkYLCvPDkuuc9xpcg8PrfuZPxoYY3elbUePv6EYyLD/Vn?=
 =?us-ascii?Q?vS2m8p9y5+UL9xu++V/ggTWrFRwu55XIAFo31uAYNXXmHa8viuI0IwI6hEFv?=
 =?us-ascii?Q?fF8RRwbHQfcotNpIvzKmTKYlB3gIVS5cbPSAjU9neFLk9EHcsLl7P8DNpG6Z?=
 =?us-ascii?Q?HWEGo9RJkoOwo5it8jCui5EumBGH47EQpWOjhe+B+0unLkrcrYAb6WEES5t9?=
 =?us-ascii?Q?tu752Pz+BgkMCiCA2IPcSfZk0PfBdy1nzgtdJN+DzkX/JH6k2uJMGOoJgeq5?=
 =?us-ascii?Q?Oboez/5IpuQgTbt0xNxbmqfxsNNVrg6hEdrn1G7zhQybuZjvjiUYRAX5Ys14?=
 =?us-ascii?Q?CCQ8RwJrNvuJFZJqXjBM+gyN?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89afb223-a2d7-4f12-36c7-08d9938455bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 04:44:43.2066
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6kwQQQxRcNGOjsQsEuBQZ8xw6qvcZgM0KvnMxmIC2iSUTaoVyOhPqz7on/DrbEsOUYjgO1SiKbp/ucBhzduUCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2073
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH v1 0/2] fpga: dfl: Log and clear errors on driver init
>=20
> These patches address a request to log and clear any prexisting errors on
> FPGA cards when the drivers load. Any existing errors will result in prin=
t
> statements to the kernel error log before the errors are cleared. These
> changes specifically affect the fme and port error registers.

Could you please explain more about why we need this change?=20
As we have user interface to log and clear errors already, is it a better c=
hoice
to let userspace log and clear them during AFU initialization?

Hao

>=20
> Russ Weight (2):
>   fpga: dfl: afu: Clear port errors in afu init
>   fpga: dfl: fme: Clear fme global errors at driver init
>=20
>  drivers/fpga/dfl-afu-error.c |  26 ++++---
>  drivers/fpga/dfl-fme-error.c | 128 +++++++++++++++++++++++------------
>  2 files changed, 100 insertions(+), 54 deletions(-)
>=20
> --
> 2.25.1