Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   quanyang.wang@windriver.com
To:     Russell King <linux@armlinux.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ard Biesheuvel <ardb@kernel.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Quanyang Wang <quanyang.wang@windriver.com>
Subject: [PATCH] ARM: add BUILD_BUG_ON to check if fixmap range spans multiple pmds
Date:   Wed, 20 Oct 2021 13:49:42 +0800
Message-Id: <20211020054942.1608637-1-quanyang.wang@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0qY7u0ktq4ES6ZYf8+1N6MsA3qSL1H1b5p4dU/92/Sov9a7hDbio05Jv1nYX?=
 =?us-ascii?Q?4nivHrIkh6UZgN0wfpW786kbGyR04gxLEh9CsdTEibyR5leJ3rZdtwWW7YNk?=
 =?us-ascii?Q?Vsen4xsAMNbvIzXiVIbb+fOaS11ciamUTpuBme7UkoigniNKNnj8RjTvqrZk?=
 =?us-ascii?Q?yqSKb+Rb9QCmebAFjDMzSNAupMVL1Z2TIz/PWPwjg59OM37XjEJGJNZZIzOY?=
 =?us-ascii?Q?4jz128cD3c6YAWrElRPh1Ky91mvy23Fl1HXWNA+l8OnA2muPTdzS/sgK2y8V?=
 =?us-ascii?Q?893vjOCWtOTbUHI4E6R8mzGyYIbovtNPWBftVx6LjMRyk2sLHA2CyALDSvHe?=
 =?us-ascii?Q?+e32sut22vtYqgJ31X8txJsZVlDrTAhUY0z9MROboKWTfBVmTotpjof+Mk5m?=
 =?us-ascii?Q?0g01jWoWQGqRaHGIQmeX3fl8slwiJVUYW4xTvTjlgohWuxNI54maIhTRX3C2?=
 =?us-ascii?Q?dP2fTsGQ1kIlN7yoootId3G/OWqQUBWntK7/O7nYrLwO2gy9u17noPbTvKgg?=
 =?us-ascii?Q?gL2xYASaJtVY6GH6EbBFX7/ttkfRbrvhwZd1tfJ3z/gw2qy8jEncj+EcnA1Z?=
 =?us-ascii?Q?URn1QvnuNyxHpI9ZFqsBrc4WD7pNXF5kxot0QQOaHx8Qu+bsp/ydbwhnlgVN?=
 =?us-ascii?Q?OGTbSKf2zVdnknA5RCCnFldhPvu8uY6WmeBF3PqRWdzAxgVA8OvzlLhppMBg?=
 =?us-ascii?Q?tdwVWAkbRDWcZnNi7dexueh/aBYRx/oJQhsKmBC6xidpH/s4HZcGufUmuQCi?=
 =?us-ascii?Q?qHxaXHmtPCt3a4y+TXHI8U755BgVEoEBi3HtFnEuGuFIyJLswdyLgv+Z9ydT?=
 =?us-ascii?Q?+eIQMDXJMwcaAqeI5DgUJzRQzb80OubRwV7t4aDit04biEmyC5r0vl2EPYYW?=
 =?us-ascii?Q?mc34LTAVOAMzpd9DIjft7wI4o5S0Q88ipToG4aNN9vqhroEuB+cKkkmJYlxG?=
 =?us-ascii?Q?pFLUJ/2jSFcsVh0CXaHhZpGZvZlbrCkhWThXfx/aLCc7mcOvA5G2wfX8yVZg?=
 =?us-ascii?Q?Nz6mcSd8trvaoduZCUgBv+Ew690tBC1tRwKmebjOSE2HjNm2j6lgPbDseL22?=
 =?us-ascii?Q?vi2sTDgoDOBiQ3/7+Nk2P9crY4LaMw9ZQ1mB0Y0Vmz72fBGD/S+DnHGOYVOe?=
 =?us-ascii?Q?Wpv7WNCUiVR561+TuZFPD+gsSjxBW3UFVoIo4oFW5TxVH3Qa1fIX8PgCFA8K?=
 =?us-ascii?Q?RPhD0+KGqu2LjJR1agDYXZrYz3O/NVx+EV93dPNw1bhLJPyY2+7vi+O+72w0?=
 =?us-ascii?Q?XH/RGx+G6gUxVaCdlAffkPubGI80XajKck6i/GcUVfXg/wPjAMhgHi4oOcAW?=
 =?us-ascii?Q?hMB1sGegHemYAZXup/GMt3vJ?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98483381-ec54-4672-d951-08d9938d7488
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 05:50:00.7400
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: quanyang.wang@windriver.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4936
X-Proofpoint-GUID: OTii4oecVS7xiWMjgr4n-QrPniK7R7Ns
X-Proofpoint-ORIG-GUID: OTii4oecVS7xiWMjgr4n-QrPniK7R7Ns
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-20_02,2021-10-19_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 lowpriorityscore=0 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0
 mlxlogscore=877 impostorscore=0 spamscore=0 clxscore=1011 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110200030
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Quanyang Wang <quanyang.wang@windriver.com>

Not only the early fixmap range, but also the fixmap range should be
checked if it spans multiple pmds. When enabling CONFIG_DEBUG_HIGHMEM,
some systems which contain up to 16 CPUs will crash.

Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
---
 arch/arm/mm/mmu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
index a4e0060051070..57eed92073a4a 100644
--- a/arch/arm/mm/mmu.c
+++ b/arch/arm/mm/mmu.c
@@ -369,6 +369,8 @@ void __init early_fixmap_init(void)
 	 */
 	BUILD_BUG_ON((__fix_to_virt(__end_of_early_ioremap_region) >> PMD_SHIFT)
 		     != FIXADDR_TOP >> PMD_SHIFT);
+	BUILD_BUG_ON((__fix_to_virt(__end_of_fixmap_region) >> PMD_SHIFT)
+		     != FIXADDR_TOP >> PMD_SHIFT);
 
 	pmd = fixmap_pmd(FIXADDR_TOP);
 	pmd_populate_kernel(&init_mm, pmd, bm_pte);
-- 
2.25.1