Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210913170436.243-1-alexander.helms.jy@renesas.com>
 <20210913170436.243-2-alexander.helms.jy@renesas.com> <CAMuHMdWZp=7sR+dTL0F8o61weLqqC3k1kkemm_PktvyK8+ONmw@mail.gmail.com>
 <CAMuHMdXq2NyBf539raFJSoWSGXnwxOAMWcVB_WV-=uf+kOs7rw@mail.gmail.com> <4f2f81a8-9a79-3211-5ec3-fa679c3e7bb9@renesas.com>
In-Reply-To: <4f2f81a8-9a79-3211-5ec3-fa679c3e7bb9@renesas.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 20 Oct 2021 10:20:17 +0200
Message-ID: <CAMuHMdXHkeOK+Bg10BCLDvTztV6+y9+OomBUiTAoa1+GCHRnvw@mail.gmail.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: Add binding for Renesas 8T49N241
To:     Alex Helms <alexander.helms.jy@renesas.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        david.cater.jc@renesas.com, Michal Simek <michal.simek@xilinx.com>,
        Rob Herring <robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Alex,

On Tue, Oct 19, 2021 at 11:53 PM Alex Helms
<alexander.helms.jy@renesas.com> wrote:
> On 10/14/2021 5:16 AM, Geert Uytterhoeven wrote:
> > On Wed, Oct 13, 2021 at 8:02 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >> On Mon, Sep 13, 2021 at 7:05 PM Alex Helms
> >> <alexander.helms.jy@renesas.com> wrote:
> >>> Renesas 8T49N241 has 4 outputs, 1 integral and 3 fractional dividers.
> >>> The 8T49N241 accepts up to two differential or single-ended input clocks
> >>> and a fundamental-mode crystal input. The internal PLL can lock to either
> >>> of the input reference clocks or to the crystal to behave as a frequency
> >>> synthesizer.
> >>>
> >>> Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com>
> >>> Reviewed-by: Rob Herring <robh@kernel.org>
> >>
> >> Thanks for your patch!
> >>
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/clock/renesas,8t49n241.yaml
> >
> >> BTW, do you plan to add interrupt and/or GPIO support later?
> >
> > To clarify, and I really meant to add:
> >
> >   interrupts:
> >     maxItems: 1
> >
> > to the bindings now, and GPIO-related properties and subnodes later.
>
> Any additional features such as interrupts and GPIO properties would only be added if there is customer demand for such features. Since there is no interrupt support, does the "interrupts" item still need to be added to the yaml?

DT describes hardware, not software policy (or limitations of the driver).

Arguably that applies to both interrupts and GPIOs, but the latter is
more complex to describe, while the former is a simple "interrupts"
property.  It's not uncommon for board components to have their
interrupt line wired to an SoC, even if the driver doesn't use it.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds