Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 20 Oct 2021 10:25:52 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Josh Poimboeuf <jpoimboe@redhat.com>
Cc:     x86@kernel.org, andrew.cooper3@citrix.com,
        linux-kernel@vger.kernel.org, alexei.starovoitov@gmail.com,
        ndesaulniers@google.com
Subject: Re: [PATCH 4/9] x86/alternative: Implement .retpoline_sites support
Message-ID: <YW/SkCW9wSnFiivN@hirez.programming.kicks-ass.net>
References: <20211013122217.304265366@infradead.org>
 <20211013123645.002402102@infradead.org>
 <20211013205259.44cvvaxiexiff5w5@treble>
 <YW6t5catO1mx+eCZ@hirez.programming.kicks-ass.net>
 <20211019164659.dybir4wgfmdt4r47@treble>
 <20211019164913.2dsyyethdeblqjlq@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211019164913.2dsyyethdeblqjlq@treble>
Precedence: bulk

On Tue, Oct 19, 2021 at 09:49:13AM -0700, Josh Poimboeuf wrote:

> @@ -1916,8 +1930,25 @@ static int read_static_call_tramps(struct objtool_file *file)
>  		list_for_each_entry(func, &sec->symbol_list, list) {
>  			if (func->bind == STB_GLOBAL &&
>  			    !strncmp(func->name, STATIC_CALL_TRAMP_PREFIX_STR,
> -				     strlen(STATIC_CALL_TRAMP_PREFIX_STR)))
> +				     strlen(STATIC_CALL_TRAMP_PREFIX_STR))) {
>  				func->static_call_tramp = true;
> +			}
> +		}
> +	}
> +
> +	return 0;
> +}
> +
> +static int read_retpoline_thunks(struct objtool_file *file)
> +{
> +	struct section *sec;
> +	struct symbol *func;
> +
> +	for_each_sec(file, sec) {
> +		list_for_each_entry(func, &sec->symbol_list, list) {
> +			if (func->bind == STB_GLOBAL && arch_is_retpoline(func)) {
> +				func->retpoline = true;
> +			}
>  		}
>  	}

I've folded these two identical loops over all symbols into a single
classify_symbols() function.