Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <0e4601e4-5fb1-ba8c-71cb-41038b1e141f@oracle.com>
Date:   Wed, 20 Oct 2021 19:27:05 +1100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [RFC PATCH v3] workqueue: Introduce show_one_worker_pool and
 show_one_workqueue.
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>
Cc:     jiangshanlai@gmail.com, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, rafael@kernel.org, pavel@ucw.cz,
        len.brown@intel.com, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org
References: <20211016002007.143661-1-imran.f.khan@oracle.com>
 <YW8RYxb3rKGcD5mR@slm.duckdns.org>
From:   Imran Khan <imran.f.khan@oracle.com>
In-Reply-To: <YW8RYxb3rKGcD5mR@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1F2SFh6MkNJQUhoak9GY1lQV2Jsd2dMN25PeUxNR3FZQUdlY2x0Rk9qSzQy?=
 =?utf-8?B?MVZPMXZFMGh3blIvWmI4QXlsK0Jjb3dHTTYvNXM1ZmVTMEQxYzdsb0FuU2pW?=
 =?utf-8?B?M3NHVG9Ldm03QXFzZ2F2Z1crbmRLSEVWeGdVNVpTd0VpbVA2eU8rcDVBcEE2?=
 =?utf-8?B?OHZSeko2Q2JGWFhLRmg2TkxvcEZ0OEhvL1hZZ3RiN1plbWlFQU1mUS9uakdt?=
 =?utf-8?B?SXo3VzNDdllTVkNsSXVubU1nMGlaa1pnN3dkOXpPRkdOaUhzcS9FejJRZFE0?=
 =?utf-8?B?OXVyWUFGcVNBY2piamVoRzA3Z3RLdWdVQVlmWVlPSkpuR2tUQ1FMQkJ2MnZC?=
 =?utf-8?B?V0pQWDMvVkkzZk1sVk1oZ1ZzOWxZTkp1dHF0d0swMDZXV1pkbWlQakF3aHdD?=
 =?utf-8?B?K1A1aTNGNkNDaW00VjhDVGl1RVp5bVpqMkIzaTN1TmszYU5vbTYzc2xxYlor?=
 =?utf-8?B?Z0Q4eXVRelg1TnM3KzViOEszb2VTdnpxaVlMdlRWU3Brd2xtUGZGdjlXWS9P?=
 =?utf-8?B?d3pQdlF4Y0hOUWFrM0Z5VXZqOERBUU03T3ZxbEl3QllacXJRSXF5M1F3clFl?=
 =?utf-8?B?L1duNnk5RXBmMVExd1hBeExLNGd3NWVkaFJtVzNIQUpOeXJzei9TVTV6Wnh3?=
 =?utf-8?B?RzNSOGdUZzFRZTdNekRPend0T2gvZHRaSTY3MjJmcGFjdjZnTStBY3dFRXg3?=
 =?utf-8?B?cDlEVDEyQlJtZ2VjWFY1R2ZBYzk1dWIxcERJU2taWnhqM095dWFwN0tva0E3?=
 =?utf-8?B?aXJ4RmQ1TWp0MTk5VEtnVXBsZnE2U3hqWkIyZzIyNjIxWldmaW9HL1hsRW83?=
 =?utf-8?B?bU9Xc3E4ZHg4RTNBNXltMzJ5RGdDWXBhVVl3M0FwTnFWK0tLSERMV2lJYzA0?=
 =?utf-8?B?cVcrTjZSbXRsTW5UaTRRYm5tdTM5akZsdytFbEJiRnc5ZHdxNWlvZGhvQTN2?=
 =?utf-8?B?MFN4QW5raGFrUndMNU5iU25QWnFLcWtQdmRGQ3FwMFRJdmRpUlh1dlJGL1hQ?=
 =?utf-8?B?MUJkaXUrNWN1djJEU1UvUHhmL1VtZlVOK3dKcTZ2UmhiNDcybDlQMk85V2RM?=
 =?utf-8?B?MW44WUlRdXY2cTFjaGd6Tml4L0RBY0c5WHFuLzlLMkRaTzh4andPd3djdkNL?=
 =?utf-8?B?SlAzc3lTeWVnRW5vOEEybXdBR1ROSnNMT2V6QVhFb0kzalZlc21FUncyRSsx?=
 =?utf-8?B?dGc1RGdVSWRXVDV0NDZCOGN5ODMrNXEwdjhXaURVUFNWV3JBYVYwV0lyK3hr?=
 =?utf-8?B?ajQ0d1crcDZiM09kUlEvTjlFbHJYU3VYQVBycTJveTF3SEtIOG1IUmdKK1Zm?=
 =?utf-8?B?bEg5Wms2b21zMkxBelhnUTQ2WU8xazI2RWhCTUVZeGFiOFY4T1IvRVMzUjgz?=
 =?utf-8?B?TE5Wd3kxM0NMYmpFZ3NCRlYwRUVFUENVaDFpTW5BYnVWV0JFb3FySU1LaTF5?=
 =?utf-8?B?QnMrSUhYeXBEc1hOQVVHeGJyRFZnaU55aDhoc0RJckg1dWhXbC80aVBraXk1?=
 =?utf-8?B?Y2hDSG5hVG8xNXZ0NGRhRmQrMmI1amRuamJLTm5GY0lXdnNQNSs4KzdaVXg4?=
 =?utf-8?B?RmVkRGo0Y1cwbStBVkN4bFZHcnBwdFo4aDVTZzRqOHY0eFpWWWFaNnRYN1hV?=
 =?utf-8?B?d29ySzM1TmNQdG5OK3M3VHlmS1JlV3NscHRmNXNpUVFrV2FaTnRJMHhYUlVz?=
 =?utf-8?B?VktqTHdpM3RLUlhWdTNNaTRNRlREa09TSjd0WVpndTRMMUtEZlFQeVpkMmVl?=
 =?utf-8?B?clZJTURnaGhPYTFRMlJpeW55d3ZveHBia2RaeHo1Q2swSnpLbncvbjZwTkFZ?=
 =?utf-8?B?d3p3bll1NFRISEgwOW03Nzg3azZLTVRYb2Z3cXl5YmozOFBUaXRmK0RmaitE?=
 =?utf-8?B?dVdHdEkrSEJmSG85LzZtODZ5RDdCNWNpellETG9xczFqdWkweXFmbG9lamt0?=
 =?utf-8?Q?HqNZY+pMKp8rqwpnGalkm9Iwa7bUQBFd?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4eeec2de-3f51-4094-ec99-08d993a36a24
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 08:27:12.1095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: imran.f.khan@oracle.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5409
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10142 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110200046
X-Proofpoint-ORIG-GUID: rnnYndAhZPvkKNDicVXT2oLjFnu5QJo3
X-Proofpoint-GUID: rnnYndAhZPvkKNDicVXT2oLjFnu5QJo3
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tejun,

On 20/10/21 5:41 am, Tejun Heo wrote:
> On Sat, Oct 16, 2021 at 11:20:07AM +1100, Imran Khan wrote:
>> Currently show_workqueue_state shows the state of all workqueues and of
>> all worker pools. In certain cases we may need to dump state of only a
>> specific workqueue or worker pool. For example in destroy_workqueue we
>> only need to show state of the workqueue which is getting destroyed.
>>
>> So rename show_workqueue_state to show_all_workqueues(to signify it
>> dumps state of all busy workqueues) and divide it into more granular
>> functions (show_one_workqueue and show_one_worker_pool), that would show
>> states of individual workqueues and worker pools and can be used in
>> cases such as the one mentioned above.
>>
>> Also, as mentioned earlier, make destroy_workqueue dump data pertaining
>> to only the workqueue that is being destroyed and make user(s) of
>> earlier interface(show_workqueue_state), use new interface
>> (show_all_workqueues).
>>
>> Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
> 
> Can you respin the patch on top of the following branch?
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-5.16

Sure, I have rebased it upon the suggested branch and have sent v4 [1] 
of the change.

[1] 
https://lore.kernel.org/lkml/20211020030900.321837-1-imran.f.khan@oracle.com/

Thanks,
--Imran
> 
> Thank you.
>