Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1293624pxb; Wed, 20 Oct 2021 02:06:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzxxI0zo3lsLIUR4UBHWmYBIQVUzeGuypaXaru2lKEOUjrPD77R8Hd0f2N4S6A8zftTvbj X-Received: by 2002:a05:6402:348b:: with SMTP id v11mr59791556edc.296.1634720770117; Wed, 20 Oct 2021 02:06:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634720770; cv=none; d=google.com; s=arc-20160816; b=N2EYQHjGZwl9YuXcxh/qPAEbanM2HSD3CrEy0OFsVJ+sKisIBGnqITUqNUqk3nkwkP XoGgKXWnnA46wYa1iqg/MgM/aLIcJkCbIoMlQsb0kip2ZD7vv232O+bsnKFimXSfc1tE DxyUT+ncKqEx1cHCIYSdZlbjS1yfYFPLmJNHg/xYFvYbdF6My3z86dCdRIWJArPkgxRK ga6DLVw+K7lSU6PXVZYtoSKzUkJ49dfMVgD9XVsqwhhqXFL3alkihoaWnK1MYRaRg2SF 4HCcqSSCZkCOKoZ1brm7ZiDIFoBypvipSP8WLvj1d9n8gPX2H3WWk+mLx1cBdENORNEm QjFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2LGv1iuwysKWDMxQdNi6ewhvMBlplBA16YnIN7kRsOI=; b=asJPUBNrN+qPGpbdQYwCQSi3+cMP/Q7WTrsNTo44okYAfPA+VY5tcuOGAFb/4w/iru QKHWACOzDvjiegjo5CjT5TcdcPjIBgMchygFTDpQjCKKqVw1tfdWEJv7hT3qMIIrAxWm syc0HQ+yoHHkRKQnIsA/gen7UvLMhatNZPzo1B0o7ncQgktTNP7W9QSS+j7i5a5bA9hG LGPJQxsfo/GDXtD/l+fVh8tM4JyR0ntlxTi/89LZpeMAjdncBwjKd3Bzba1d1nPAdgSh T4VEFGf7URFoAeAQlIYcsfSexA3fOedojFdUmQwabkMMNE+CFmGxUl2YZ2OA9Wml1+84 a3Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=K0bTCdHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=geanix.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k9si2202796edh.518.2021.10.20.02.05.42; Wed, 20 Oct 2021 02:06:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=K0bTCdHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=geanix.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbhJTJDu (ORCPT + 99 others); Wed, 20 Oct 2021 05:03:50 -0400 Received: from first.geanix.com ([116.203.34.67]:37394 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbhJTJDt (ORCPT ); Wed, 20 Oct 2021 05:03:49 -0400 Received: from skn-laptop (unknown [185.233.254.173]) by first.geanix.com (Postfix) with ESMTPSA id AC7E2C7ED6; Wed, 20 Oct 2021 09:01:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1634720493; bh=0TDUefSKSTAfFL2Uv7HVije8SZ09HaYEgndQJR2AUrg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=K0bTCdHvzy6hsDfRq+p0+IVzDX/bc9Ahv6jiOoF8VX/VmiDA127VpWk/htZopBl6p HEAgV1o7w5NEgg7bVOLqwIOS9H7icU952jvUa+4/s0fkcLYg0WsnpYBhBJS3bIMs1u WUuZsKgXdvwToj3gPB56QZfJ+oMElYjex3J14NtGnbgfm11sueeSU3DJm3AzX4StIF b/30EEWmHwK3i1dTsR8YAS9m5ES4+QUIyxxtjXo+I1TohRjce8hUxDRS+WKOYU8JLh Z93NyuC/b6bEoGKtHHaDAylQy0P9oDo+mcSWB048RwjSpsxdiPDi7/IC0pRFAS7elM IZP2Fw42+AXsw== Date: Wed, 20 Oct 2021 11:01:32 +0200 From: Sean Nyekjaer To: Boris Brezillon Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Boris Brezillon , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt Message-ID: <20211020090132.zuxojg6cnwsm4dwg@skn-laptop> References: <20211020084534.2472305-1-sean@geanix.com> <20211020084534.2472305-2-sean@geanix.com> <20211020105326.0dca864a@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211020105326.0dca864a@collabora.com> X-Spam-Status: No, score=-3.1 required=4.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=disabled version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on 13e2a5895688 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 20, 2021 at 10:53:26AM +0200, Boris Brezillon wrote: > On Wed, 20 Oct 2021 10:45:31 +0200 > Sean Nyekjaer wrote: > > > From: Boris Brezillon > > > > The BBT scan logic use the MTD helpers before the MTD layer had a > > chance to initialize the device, and that leads to issues when > > accessing the uninitialized suspend lock. Let's temporarily set the > > suspend/resume hooks to NULL to skip the lock acquire/release step. > > > > Fixes: 013e6292aaf5 ("mtd: rawnand: Simplify the locking") > > Tested-by: Sean Nyekjaer > > It's missing our Signed-off-by tags. > Patch is from you ;) If you are okay with it, I will add your Signed-off-by tag. /Sean