Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] Bluetooth: btrtl: Add support for RTL8822C hci_ver
 0x08
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
        chbgdn <chbgdn@gmail.com>
References: <20211019095738.2098486-1-adeep@lexina.in>
 <20211019095738.2098486-2-adeep@lexina.in>
 <F99878E7-51E7-48B0-921B-8CDD53693E04@holtmann.org>
From:   Vyacheslav <adeep@lexina.in>
Message-ID: <7c0ba739-f2fe-ad09-e3e2-4b1286aabf38@lexina.in>
Date:   Wed, 20 Oct 2021 13:08:06 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <F99878E7-51E7-48B0-921B-8CDD53693E04@holtmann.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: ru
Content-Transfer-Encoding: 7bit
Precedence: bulk

19.10.2021 21:29, Marcel Holtmann wrote:
> Hi Vyacheslav,
> 
>> Add detection of RTL8822CS controller with hci_ver = 0x08
>>
>> Signed-off-by: chbgdn <chbgdn@gmail.com>
> 
> clear name please.

If Bohdan doesn't answer, we can remove this line.

>> +	/* 8822C with UART interface */
>> +	{ IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0x8, HCI_UART),
>> +	  .config_needed = true,
>> +	  .has_rom_version = true,
>> +	  .fw_name  = "rtl_bt/rtl8822cs_fw.bin",
>> +	  .cfg_name = "rtl_bt/rtl8822cs_config" },
>> +
> 
> what about the .has_msft_ext here. Does this one support the Microsoft extension?


This is only a variant of the already added 8822c controller, so I 
simply copied the parameters and changed only hci_ver to 0x8.
I found this controller on X96 TV Box and JetHome H1 device.

It will also be necessary to update rtl8822cs_config in the 
linux-firmware repository from 
https://github.com/armbian/firmware/commit/5d685ad233b4dfd03a4d025fa0061f6b0f850cb3