Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1373692pxb; Wed, 20 Oct 2021 03:55:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxteTo8vlUk6M0oG61b6dj04ctHcoomwnTIwrY5zN5psjHyMJ3F/z7d1cqAJOlCDjTpWaox X-Received: by 2002:a17:907:3353:: with SMTP id yr19mr43622656ejb.508.1634727305924; Wed, 20 Oct 2021 03:55:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634727305; cv=none; d=google.com; s=arc-20160816; b=hwjDFLstxeVbl8/IF3E8+8E/bXQaaEfXW3m2NZXNM7KGizWw3E/Mgph7MqBEUT1nS1 fIWt0AiLc1pJsXVaKVeklpFcwl6iWjq8KSza5pCkrki4TcwI5EPLuXBCZpOorvvT91Rr aFV6zZoX9tKKdLqEmwSrpxNSC2eItPGqEJCt6VXIfjsB3j9IiiNyya2SxnSjuDt/bVEk cA5YyYPl0ZnJIFdgfFiW151OZwRC7WuSwQHA+9FhMVi0mh8yHy0UeB/+xB/Yn+CrJCUS FuW4hPUYq8sWIksNQUMph/5D2hD0ik0c3jMvlv0Ok8cud/YK4SxZDwd8UUMvoUjzD/Pv 6L1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=uEjpzIz3iaI9bxQp1J3Sc/M4D7jV3FdCgUWlHWIGP5c=; b=kAcC4NMUoKrr+qaq184LRztikloLGDy+pSKz/LhLUkpkPfP5LmLKqRdnUNwV7xhArE T+hpzgJxrGdM9xmanx9xo57y/KsEUca1VCDS3PBBkTMxsb3RiSNLjdxfxb18JY86wDTQ ez8OoiW6l+FtSraeO+2CleEjMmu0+iITSekN4HAtnMUYTNMze5HwnlYp7EEGcee+wIXe swzLbQ9Qom6eEo4j+SDYzHUbS/IQ4z5v/H5s7yKbA+yp2bf7p8meZ3Ms1jxMPrjmFhLv BP3wnZw8nWXhEqh6/ViAsxIde2QxAkOl9XV/r9wBt9dE1KEE5dbI4z2KPjUxyv4xVwoT Xz3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=lkym+TGx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t11si3486385edd.247.2021.10.20.03.54.40; Wed, 20 Oct 2021 03:55:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=lkym+TGx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230099AbhJTKyv (ORCPT + 99 others); Wed, 20 Oct 2021 06:54:51 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:3626 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229702AbhJTKyu (ORCPT ); Wed, 20 Oct 2021 06:54:50 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19KAPN99031982; Wed, 20 Oct 2021 06:52:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=uEjpzIz3iaI9bxQp1J3Sc/M4D7jV3FdCgUWlHWIGP5c=; b=lkym+TGxMT1SC7t4SlWKlN0pFlxjzjy3KUOTBBJachZc+yLXE3xIjkXO4gNoNe/f2NyL hoXktfAFLed8wAwlQLkj0Cyl/XzGupc+MBCYRfh2ixbQn9zHqUB+eKonqF9lTgKYg739 mXkZrVsK7o6ZlZlsq/6K5zoeVV8ojrJGX+naZDh8eiHUY0Wu6HOyYfGuSJmAFhiaUmFX tGJ8X8w7vPZ+jpwqfQQETxhrY+PXh1qVFJy+uXLoUvrySkpns7NamavgsYrTmdBX1R/l w+Vz1Xdfva6ux+N731Zq+71VRsK0ev6hHA9kA+MynkPhlAy5UayiykbKMmir+eymVkSY aw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3btep1c3hs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Oct 2021 06:52:36 -0400 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 19K7vkiU015996; Wed, 20 Oct 2021 06:52:35 -0400 Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 3btep1c3h6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Oct 2021 06:52:35 -0400 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 19KAnrBT009534; Wed, 20 Oct 2021 10:52:32 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma05fra.de.ibm.com with ESMTP id 3bqpca12dk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Oct 2021 10:52:32 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 19KAqTfn56754548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Oct 2021 10:52:29 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 24D9F52079; Wed, 20 Oct 2021 10:52:29 +0000 (GMT) Received: from li-43c5434c-23b8-11b2-a85c-c4958fb47a68.ibm.com (unknown [9.171.54.36]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 73AD652073; Wed, 20 Oct 2021 10:52:28 +0000 (GMT) Subject: Re: [PATCH 3/3] KVM: s390: clear kicked_mask if not idle after set To: Halil Pasic Cc: Michael Mueller , Janosch Frank , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, David Hildenbrand , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Pierre Morel , Tony Krowiak , Matthew Rosato , Niklas Schnelle , farman@linux.ibm.com, kvm@vger.kernel.org References: <20211019175401.3757927-1-pasic@linux.ibm.com> <20211019175401.3757927-4-pasic@linux.ibm.com> <8cb919e7-e7ab-5ec1-591e-43f95f140d7b@linux.ibm.com> <20211020124513.6b90a15b.pasic@linux.ibm.com> From: Christian Borntraeger Message-ID: Date: Wed, 20 Oct 2021 12:52:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211020124513.6b90a15b.pasic@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: UZRxnofDHxbDZZDwgSx-rI0EhNEEvNcJ X-Proofpoint-GUID: NOh07Y2zhoLQSxyPGexQcS52umJVfRn3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-20_04,2021-10-20_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 adultscore=0 priorityscore=1501 mlxscore=0 clxscore=1015 bulkscore=0 malwarescore=0 spamscore=0 mlxlogscore=973 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110200060 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 20.10.21 um 12:45 schrieb Halil Pasic: > On Wed, 20 Oct 2021 12:31:19 +0200 > Christian Borntraeger wrote: > >>> Before releasing something like this, where none of us is sure if >>> it really saves cpu cost, I'd prefer to run some measurement with >>> the whole kicked_mask logic removed and to compare the number of >>> vcpu wake ups with the number of interrupts to be processed by >>> the gib alert mechanism in a slightly over committed host while >>> driving with Matthews test load. >> >> But I think patch 1 and 2 can go immediately as they measurably or >> testable fix things. Correct? > > I think so as well. And if patch 3 is going to be dropped, I would > really like to keep the unconditional clear in kvm_arch_vcpu_runnable(), > as my analysis in the discussion points out: I think it can save us > form trouble this patch is trying to address. Yes, lets keep patch 1 and 2 as us and let us look deeper into this patch. I will apply and queue 1 and 2 soon.