Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Cc:     Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Li Yang <leoyang.li@nxp.com>,
        Oleksij Rempel <o.rempel@pengutronix.de>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH devicetree 1/3] ARM: dts: imx6qp-prtwd3: update RGMII delays for sja1105 switch
Date:   Wed, 20 Oct 2021 14:36:11 +0300
Message-Id: <20211020113613.815210-2-vladimir.oltean@nxp.com>
In-Reply-To: <20211020113613.815210-1-vladimir.oltean@nxp.com>
References: <20211020113613.815210-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yEhR9I9rj9xxWWumAtnU/5gxsoNfnVe1C7ORnaUkp90W+NJFtAzdDrHNvH1V?=
 =?us-ascii?Q?SPsdheebfau80u0QkXL39KCm2+IWgMVpqpKbcpzU6w+qtnTZcpsnGf8xp+Pd?=
 =?us-ascii?Q?rKNJBRmE1FSItdnfur3dKGlBamVd+xc6LKpdCMyEiT4v9p1RgEa70FZMV6EW?=
 =?us-ascii?Q?VJZOmoao2Wnq4GLjTn0iG0Pogidm+g+zZG3rkmP2uv4fK3XboZlcp1ORu1vO?=
 =?us-ascii?Q?tW8QO0PTTIdaaeoaYnabhpeEt/Vu+HlXdSSqB422O96cRJ0qLXLhERMtLCtX?=
 =?us-ascii?Q?TS75op/kIZ/2EbFQDlH19gJEMoMWgZssk4z1N+lv4f8dFMyJe2e5NUlcpiCq?=
 =?us-ascii?Q?l3gBaoU2ekK4PW9p+ilr2vvSHqCFReVWPQE6RM9sLqhcUw7elMglb5CvsWHo?=
 =?us-ascii?Q?8t5kr/tbz7zYphbu5IDZ6LIS+PcfeyfyYJDaIIouMN21LiZusCcZZD3g2F/S?=
 =?us-ascii?Q?2BivlYXETx1Eg1BlN6wLCz1Zh+QPENQ3OUD/IIURB3FeVDbxUCVlUx4GUhq/?=
 =?us-ascii?Q?RGcOEC5gyIUwe3xpI6Z7D/3Du9R+rW5BNRVwfYBx2ShG+bMyMW82oieslXVq?=
 =?us-ascii?Q?IXdpwegi+Uf1bMXR/3GCKx1h678Gtex5/M2vod1OpcH7WUCgbwgNlC0ljLxc?=
 =?us-ascii?Q?7uJz9Fd0IHBF6vruA0d1Y/HOKC/yHfIqhQBbrQqrekCSRkgfC7wYuZJXYIt3?=
 =?us-ascii?Q?9t/qojZg2HRy+HHxv+AVk950qszbey40nkKluEPDd0Bo2JJngiRJ0dw1uzV6?=
 =?us-ascii?Q?m9qCmka4H3t9jQTJ3ZeK/s6aYHrBym2EPtR48RZN1ewdXyXJn/+dzoKqdRjP?=
 =?us-ascii?Q?5ktD1vnI/iWi0JrwdSEn0RlIEMKvlcR5HZ5vg7BDbHU1zEeLSRy+yxbVu3m6?=
 =?us-ascii?Q?LEPMpLFfStnoigENmZ9iOOkbU6gOmbz+113RvqiQugZAOO7fQZFEYDoIcRvD?=
 =?us-ascii?Q?Zf1Ac65mG9HdiX8uu3hVy+TUFfvkSkWCKclbUubdUcznYaxcdvFJ6/4X75do?=
 =?us-ascii?Q?g7gAipMwT/Bwf0gWQgtwDhSyNEvfFGr7+ONToKCS6iRJDsMQR0IKrtmN7Q74?=
 =?us-ascii?Q?CUGFgd/DL4/H5ekV65Ir6v1YlDVw5WfbLFwHM2U2zyxZMGpORO3Q3bJiwJBP?=
 =?us-ascii?Q?hDrwwo3WXAyYgaGZtAkZ/8mc0lr2MwGp5DMgWZT6k7pYYz8XIGyshiQScc6c?=
 =?us-ascii?Q?W4uo3nJfb9BBBTlX0Shcixm2R5IS0G7aCQehyRRWJ5M79Wd3YDYb5277KZYh?=
 =?us-ascii?Q?E9939y41c7tb8h3dnYWTwvJmD9s8DKzL0IjlK9k4lHwZkDMtRlstm0flYNeO?=
 =?us-ascii?Q?DPA4L6vOZVKDcIb9exz8IIdl5zec+tE4FmHbSqqjamjBeoHoCxZB+x9yNgFo?=
 =?us-ascii?Q?QrdDa2evmfpATHGTh6V2C6fwndcHODQAoNGScOlVEgp5LTsFOPxtK7UrP989?=
 =?us-ascii?Q?kSOo0/8bDQ2vfJO4l4c9x7CSdhrp6EzHsGQno5SlOLARXIR5K6mWpc+rZxef?=
 =?us-ascii?Q?i1lfpR+NurddWX/eq3em5caDYE57jLHXPGNFthWF1JifBYZUDGRkPcrqMqQ2?=
 =?us-ascii?Q?gTL0pLsbsAIPUod1dVLPPS/5OCUtyNdue6KBaXTn3namaPpiXYWlbx82v5eP?=
 =?us-ascii?Q?bH4t+9LyapSPZ+vJ70tFv24=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ddaa41a-5e4b-41d0-676c-08d993bddd66
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 11:36:32.3882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eM8p/Ih+rK7+klFDFcpaW/tcGTkg0YN+yvAVCvHsxWyy8oen2W/vuKOXooaCxvjr37qxu+pKetQ4UXFVyoDLTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4685
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

In the new behavior, the sja1105 driver expects there to be explicit
RGMII delays present on the fixed-link ports, otherwise it will complain
that it falls back to legacy behavior, which is to apply RGMII delays
incorrectly derived from the phy-mode string.

In this case, the legacy behavior of the driver is to apply both RX and
TX delays. To preserve that, add explicit 2 nanosecond delays, which are
identical with what the driver used to add (a 90 degree phase shift).
The delays from the phy-mode are ignored by new kernels (it's still
RGMII as long as it's "rgmii*" something), and the explicit
{rx,tx}-internal-delay-ps properties are ignored by old kernels, so the
change works both ways.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/arm/boot/dts/imx6qp-prtwd3.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qp-prtwd3.dts b/arch/arm/boot/dts/imx6qp-prtwd3.dts
index 7648e8a02000..cf6571cc4682 100644
--- a/arch/arm/boot/dts/imx6qp-prtwd3.dts
+++ b/arch/arm/boot/dts/imx6qp-prtwd3.dts
@@ -178,6 +178,8 @@ port@4 {
 				label = "cpu";
 				ethernet = <&fec>;
 				phy-mode = "rgmii-id";
+				rx-internal-delay-ps = <2000>;
+				tx-internal-delay-ps = <2000>;
 
 				fixed-link {
 					speed = <100>;
-- 
2.25.1