Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <fb309e2686ca42df2c053cc1b060b1bc774fd3e7.camel@linux.ibm.com>
Subject: Re: [PATCH v4 1/3] efi/libstub: Copy confidential computing secret
 area
From:   James Bottomley <jejb@linux.ibm.com>
Reply-To: jejb@linux.ibm.com
To:     Greg KH <gregkh@linuxfoundation.org>,
        Dov Murik <dovmurik@linux.ibm.com>
Cc:     linux-efi@vger.kernel.org, Borislav Petkov <bp@suse.de>,
        Ashish Kalra <ashish.kalra@amd.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Andi Kleen <ak@linux.intel.com>,
        Andrew Scull <ascull@google.com>,
        Dave Hansen <dave.hansen@intel.com>,
        "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
        Tobin Feldman-Fitzthum <tobin@linux.ibm.com>,
        Jim Cadden <jcadden@ibm.com>,
        Daniele Buono <dbuono@linux.vnet.ibm.com>,
        linux-coco@lists.linux.dev, linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 20 Oct 2021 08:00:28 -0400
In-Reply-To: <YW+5phDcxynJD2qy@kroah.com>
References: <20211020061408.3447533-1-dovmurik@linux.ibm.com>
         <20211020061408.3447533-2-dovmurik@linux.ibm.com>
         <YW+5phDcxynJD2qy@kroah.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2021-10-20 at 08:39 +0200, Greg KH wrote:
> On Wed, Oct 20, 2021 at 06:14:06AM +0000, Dov Murik wrote:
[...]
> > +	help
> > +	  Copy memory reserved by EFI for Confidential Computing (coco)
> > +	  injected secrets, if EFI exposes such a table entry.
> 
> Why would you want to "copy" secret memory?
> 
> This sounds really odd here, it sounds like you are opening up a
> security hole.  Are you sure this is the correct text that everyone
> on the "COCO" group agrees with?

The way this works is that EFI covers the secret area with a boot time
handoff block, which means it gets destroyed as soon as
ExitBootServices is called as a security measure ... if you do nothing
the secret is shredded.  This means you need to make a copy of it
before that happens if there are secrets that need to live beyond the
EFI boot stub.

James