Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] x86/sev-es: Expose __sev_es_ghcb_hv_call() to call ghcb
 hv call out of sev code
To:     Borislav Petkov <bp@alien8.de>
Cc:     Tianyu Lan <Tianyu.Lan@microsoft.com>, kys@microsoft.com,
        haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
        decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com,
        x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com,
        luto@kernel.org, peterz@infradead.org, davem@davemloft.net,
        kuba@kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de,
        jroedel@suse.de, brijesh.singh@amd.com, thomas.lendacky@amd.com,
        pgonda@google.com, akpm@linux-foundation.org,
        kirill.shutemov@linux.intel.com, rppt@kernel.org, tj@kernel.org,
        aneesh.kumar@linux.ibm.com, saravanand@fb.com, hannes@cmpxchg.org,
        rientjes@google.com, michael.h.kelley@microsoft.com,
        linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        vkuznets@redhat.com, konrad.wilk@oracle.com, hch@lst.de,
        robin.murphy@arm.com, joro@8bytes.org, parri.andrea@gmail.com,
        dave.hansen@intel.com
References: <2772390d-09c1-80c1-082f-225f32eae4aa@gmail.com>
 <20211020062321.3581158-1-ltykernel@gmail.com> <YW/oaZ2GN15hQdyd@zn.tnic>
From:   Tianyu Lan <ltykernel@gmail.com>
Message-ID: <c5b55d93-14c4-81cf-e999-71ad5d6a1b41@gmail.com>
Date:   Wed, 20 Oct 2021 20:39:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YW/oaZ2GN15hQdyd@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/20/2021 5:59 PM, Borislav Petkov wrote:
> On Wed, Oct 20, 2021 at 02:23:16AM -0400, Tianyu Lan wrote:
>> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
>>
>>
>> Hyper-V also needs to call ghcb hv call to write/read MSR in Isolation VM.
>> So expose __sev_es_ghcb_hv_call() to call it in the Hyper-V code.
>>
>> Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
>> ---
>>   arch/x86/include/asm/sev.h   | 11 +++++++++++
>>   arch/x86/kernel/sev-shared.c | 24 +++++++++++++++++++-----
>>   2 files changed, 30 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h
>> index fa5cd05d3b5b..295c847c3cd4 100644
>> --- a/arch/x86/include/asm/sev.h
>> +++ b/arch/x86/include/asm/sev.h
>> @@ -81,12 +81,23 @@ static __always_inline void sev_es_nmi_complete(void)
>>   		__sev_es_nmi_complete();
>>   }
>>   extern int __init sev_es_efi_map_ghcbs(pgd_t *pgd);
>> +extern enum es_result __sev_es_ghcb_hv_call(struct ghcb *ghcb,
>> +					    struct es_em_ctxt *ctxt,
>> +					    u64 exit_code, u64 exit_info_1,
>> +					    u64 exit_info_2);
> 
> You can do here:
> 
> static inline enum es_result
> __sev_es_ghcb_hv_call(struct ghcb *ghcb, u64 exit_code, u64 exit_info_1, u64 exit_info_2) { return ES_VMM_ERROR; }
> 
>> @@ -137,12 +141,22 @@ static enum es_result sev_es_ghcb_hv_call(struct ghcb *ghcb,
>>   	ghcb_set_sw_exit_info_1(ghcb, exit_info_1);
>>   	ghcb_set_sw_exit_info_2(ghcb, exit_info_2);
>>   
>> -	sev_es_wr_ghcb_msr(__pa(ghcb));
>>   	VMGEXIT();
>>   
>>   	return verify_exception_info(ghcb, ctxt);
>>   }
>>   
>> +static enum es_result sev_es_ghcb_hv_call(struct ghcb *ghcb,
>> +					  struct es_em_ctxt *ctxt,
>> +					  u64 exit_code, u64 exit_info_1,
>> +					  u64 exit_info_2)
>> +{
>> +	sev_es_wr_ghcb_msr(__pa(ghcb));
>> +
>> +	return __sev_es_ghcb_hv_call(ghcb, ctxt, exit_code, exit_info_1,
>> +				     exit_info_2);
>> +}
> 
> Well, why does Hyper-V need this thing a bit differently, without the
> setting of the GHCB's physical address?

Hyper-V runs paravisor in guest VMPL0 which emulates some functions
(e.g, timer, tsc, serial console and so on) via handling VC exception.
GHCB pages are allocated and set up by the paravisor and report to Linux
guest via MSR register.Hyper-V SEV implementation is unenlightened guest
case which doesn't Linux doesn't handle VC and paravisor in the VMPL0
handle it.


> 
> What if another hypervisor does yet another SEV implementation and yet
> another HV call needs to be defined?

In the early version, these ghcb operations are implemented in Hyper-V 
code and get comments to use existing code in the SEV ES as much as 
possible. So latter versions expose the API to re-use code.

Current two cases: enlightened guest and un-enlightened guest. Tom and
brjesh pushed enlightened case. Hyper-V is un-enlightened case and a
paravisor runs in VMPL0 to handle VC to emulate devices inside VM. GHCB
is allocated and set up by paravisor in the un-enlightened case. The new
__sev_es_ghcb_hv_call() is to handle these two cases.