Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 20 Oct 2021 10:24:33 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     John Garry <john.garry@huawei.com>
Cc:     Ian Rogers <irogers@google.com>, Andi Kleen <ak@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Kajol Jain <kjain@linux.ibm.com>,
        "Paul A . Clarke" <pc@us.ibm.com>,
        Riccardo Mancini <rickyman7@gmail.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Kees Cook <keescook@chromium.org>,
        Sami Tolvanen <samitolvanen@google.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Zhen Lei <thunder.leizhen@huawei.com>,
        ToastC <mrtoastcheng@gmail.com>,
        Joakim Zhang <qiangqing.zhang@nxp.com>,
        Felix Fietkau <nbd@nbd.name>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Song Liu <songliubraving@fb.com>, Fabian Hemmer <copy@copy.sh>,
        Alexander Antonov <alexander.antonov@linux.intel.com>,
        Nicholas Fraser <nfraser@codeweavers.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Denys Zagorui <dzagorui@cisco.com>,
        Wan Jiabing <wanjiabing@vivo.com>,
        Thomas Richter <tmricht@linux.ibm.com>,
        Sumanth Korikkar <sumanthk@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        Andrew Kilroy <andrew.kilroy@arm.com>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v2 04/21] perf pmu: Make pmu_event tables const.
Message-ID: <YXAYkecMsW+Zj8W9@kernel.org>
References: <20211015172132.1162559-1-irogers@google.com>
 <20211015172132.1162559-5-irogers@google.com>
 <d9566a3a-179e-ab3c-6a63-256ea23778b9@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d9566a3a-179e-ab3c-6a63-256ea23778b9@huawei.com>
Precedence: bulk

Em Tue, Oct 19, 2021 at 12:19:24PM +0100, John Garry escreveu:
> On 15/10/2021 18:21, Ian Rogers wrote:

> - bouncing Changbin Du <changbin.du@intel.com> and Jin Yao
> <yao.jin@linux.intel.com>
 
> > Make lookup nature of data structures clearer through their type. Reduce
> > scope of architecture specific pmu_event tables by making them static.

> > Suggested-by: John Garry<john.garry@huawei.com>
> > Acked-by: Andi Kleen<ak@linux.intel.com>
> > Signed-off-by: Ian Rogers<irogers@google.com>
 
> Reviewed-by: John Garry <john.garry@huawei.com>
 
> BTW, We seem to be using > 80 char per line now. Well in metricgroup.h
> anyway, from a brief check. I know checkpatch.pl is ok with this now, but
> some maintainers aren't. Just saying.

I don't have a problem with that:

[acme@quaco ~]$ echo $COLUMNS
273
[acme@quaco ~]$

:-)

- Arnaldo