Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: quic_luoj=quicinc.com@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 41A57C4338F
Subject: Re: [PATCH v3 12/13] net: phy: adjust qca8081 master/slave seed value
 if link down
To:     Andrew Lunn <andrew@lunn.ch>, Luo Jie <luoj@codeaurora.org>
Cc:     hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, sricharan@codeaurora.org
References: <20211018033333.17677-1-luoj@codeaurora.org>
 <20211018033333.17677-13-luoj@codeaurora.org> <YW3vVt99i7TNCzaC@lunn.ch>
From:   Jie Luo <quic_luoj@quicinc.com>
Message-ID: <087c328d-2909-6750-8711-71abb8d5e301@quicinc.com>
Date:   Wed, 20 Oct 2021 21:27:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YW3vVt99i7TNCzaC@lunn.ch>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 10/19/2021 6:04 AM, Andrew Lunn wrote:
> On Mon, Oct 18, 2021 at 11:33:32AM +0800, Luo Jie wrote:
>> 1. The master/slave seed needs to be updated when the link can't
>> be created.
>>
>> 2. The case where two qca8081 PHYs are connected each other and
>> master/slave seed is generated as the same value also needs
>> to be considered, so adding this code change into read_status
>> instead of link_change_notify.
>>
>> Signed-off-by: Luo Jie <luoj@codeaurora.org>
>> ---
>>   drivers/net/phy/at803x.c | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
>> index 5d007f89e9d3..77aaf9e72781 100644
>> --- a/drivers/net/phy/at803x.c
>> +++ b/drivers/net/phy/at803x.c
>> @@ -1556,6 +1556,22 @@ static int qca808x_read_status(struct phy_device *phydev)
>>   	else
>>   		phydev->interface = PHY_INTERFACE_MODE_SMII;
>>   
>> +	/* generate seed as a lower random value to make PHY linked as SLAVE easily,
>> +	 * except for master/slave configuration fault detected.
>> +	 * the reason for not putting this code into the function link_change_notify is
>> +	 * the corner case where the link partner is also the qca8081 PHY and the seed
>> +	 * value is configured as the same value, the link can't be up and no link change
>> +	 * occurs.
>> +	 */
>> +	if (!phydev->link) {
>> +		if (phydev->master_slave_state == MASTER_SLAVE_STATE_ERR) {
>> +			qca808x_phy_ms_seed_enable(phydev, false);
>> +		} else {
>> +			qca808x_phy_ms_random_seed_set(phydev);
>> +			qca808x_phy_ms_seed_enable(phydev, true);
>> +		}
>> +	}
> Are you assuming here that the status is polled once a second, and
> each poll you choose a new seed and see if it succeeds? What happens
> when interrupts are used, not polling?
>
>       Andrew

Hi Andrew,

yes, this code assumes that the PHY POLL is used, and choose a new 
random seed value

on each poll if no link is created.

when the interrupts is used, this corner case seems can't be covered 
since there is

no related interrupt occurs when the seed is configured as same value.