Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1955ef45-d30f-5354-e514-2bc8f7d9cfb6@linux.ibm.com>
Date:   Wed, 20 Oct 2021 16:44:01 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] s390: replace snprintf in show functions with sysfs_emit
Content-Language: en-US
To:     Qing Wang <wangqing@vivo.com>,
        Jan Hoeppner <hoeppner@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1634280655-4908-1-git-send-email-wangqing@vivo.com>
From:   Stefan Haberland <sth@linux.ibm.com>
In-Reply-To: <1634280655-4908-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Am 15.10.21 um 08:50 schrieb Qing Wang:
> show() must not use snprintf() when formatting the value to be
> returned to user space.
>
> Fix the coccicheck warnings:
> WARNING: use scnprintf or sprintf.
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> Signed-off-by: Qing Wang <wangqing@vivo.com>
> ---
>   drivers/s390/block/dasd_devmap.c | 74 ++++++++++++++++++++--------------------
>

Thanks for the DASD changes. While I am totally fine with the change 
itself I agree with Joe's remark.
Would you like to improve your patch? Otherwise I can add a small follow 
on patch. Just let me know.