Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1579192pxb; Wed, 20 Oct 2021 07:50:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwP5hNdkwICEeO/4vgsFBsbhCz/hdm1v1cBX6LgY+VEi9yFBlsl5u7OrJQO7hXsSQgf9Jyy X-Received: by 2002:a17:90b:1646:: with SMTP id il6mr364862pjb.129.1634741439546; Wed, 20 Oct 2021 07:50:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634741439; cv=none; d=google.com; s=arc-20160816; b=DIR9Ll5nj2fjF8neeMKkwZnYOBTL4d8B5hHoHDdHAK5EdbPQ4g8XBkrGntQ+lFohg/ RsibQ2GPjwEsIfamP6RAox8xvicLRbF3rm4yKQPnO4bH+krIsaUNKXbUKxKJiJv1sUWQ 5D+vz3TDAdLS7OPy4kcUNmD6B5F/Yz/2UF9+4ZV6Bt4JY/XsJJlF6vY+Uym/C9AOiO1y qk6+AGIABBVWB/my7IcrSP0BlcXxF1k2Cvodbym54AOFXpXxTJfBfQLtYAGEITa24m3D TqvG40PbOvTe3eEiZuHoux2Pr+GxABmrvmDBcY7+M4RLg6V/2IdT8mEp0spJp18DBsgx v34w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=1aYq6Nre0HfvAGioV56ovQoznLb7/FFRrfVZiQ+alJA=; b=XtwuJmZ58alFJybmJt04zPeRQWBXdAKlpTnb8MShobE3f1kRnMdZTVA4sbtZfIEXoV UxEWRlUH/xYjm22DHEQcbbOjixDTiRy6WzwqMOJ82LHQVKw/c3HQRAJ18vYCc/6XWG2Z WwQl41HPPKueSx7LTmtPdVXrocWacloyl0Qia4muueFawcEsWEoUWWYvHIQkynv0GnRi DrV6OAWEN29hk0AiOvujYz+xpod/VlnlqZiQy+kXTH0QjOis7Mu5djn004/4U7kb9OS9 HLD0/qZH03/eauIMSUVzodjh+isH1L4bDqMJ34ElFvm/ij9OR/+KEYuFlMzVU7NA68oU NvVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bg24si7948668pjb.14.2021.10.20.07.50.25; Wed, 20 Oct 2021 07:50:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230265AbhJTOvg (ORCPT + 99 others); Wed, 20 Oct 2021 10:51:36 -0400 Received: from mga01.intel.com ([192.55.52.88]:40263 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230260AbhJTOvf (ORCPT ); Wed, 20 Oct 2021 10:51:35 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10143"; a="252284960" X-IronPort-AV: E=Sophos;i="5.87,167,1631602800"; d="scan'208";a="252284960" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 07:48:25 -0700 X-IronPort-AV: E=Sophos;i="5.87,167,1631602800"; d="scan'208";a="483759073" Received: from xsang-optiplex-9020.sh.intel.com (HELO xsang-OptiPlex-9020) ([10.239.159.41]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 07:48:23 -0700 Date: Wed, 20 Oct 2021 23:08:16 +0800 From: Oliver Sang To: Christoph Hellwig Cc: Jens Axboe , LKML , lkp@lists.01.org, lkp@intel.com Subject: Re: [block] 52b85909f8: ndctl.test-libndctl.fail Message-ID: <20211020150816.GB22721@xsang-OptiPlex-9020> References: <20210831145036.GA14661@xsang-OptiPlex-9020> <20210901113424.GA6637@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210901113424.GA6637@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph Hellwig, On Wed, Sep 01, 2021 at 01:34:24PM +0200, Christoph Hellwig wrote: > On Tue, Aug 31, 2021 at 10:50:36PM +0800, kernel test robot wrote: > > > > > > Greeting, > > > > FYI, we noticed the following commit (built with gcc-9): > > > > commit: 52b85909f85d06efa69aaf4210e72467f1f58d2b ("block: fold register_disk into device_add_disk") > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > Can someone help to decode the output? I'm a little lost in debug output > from libkmod but can't really find anything substancial that looks wrong. sorry for late, we retested on this commit and its parent, also we noticed a fix commit: commit d55174cccac2e4c2a58ff68b6b573fc0836f73bd (nvdimm/libnvdimm-fixes) Author: Christoph Hellwig Date: Wed Sep 22 19:34:29 2021 +0200 nvdimm/pmem: fix creating the dax group The recent block layer refactoring broke the way how the pmem driver abused device_add_disk. Fix this by properly passing the attribute groups to device_add_disk. Fixes: 52b85909f85d ("block: fold register_disk into device_add_disk") rerun on all these 3 commits, we now confirmed the ndctl.test-libndctl.fail can be reproduced on all of them. sorry for inconvenience.