Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1598915pxb; Wed, 20 Oct 2021 08:12:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0vvBprpv23KV5xwMcLqaI15xumU7cDyDDc1mcPsiUHdWAOhZizQV7QTfFhOxeLjyLKCB8 X-Received: by 2002:a50:e145:: with SMTP id i5mr78150edl.16.1634742753120; Wed, 20 Oct 2021 08:12:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634742753; cv=none; d=google.com; s=arc-20160816; b=scjBqjyE2RK+GlDbZ7wLzaEr6vJvlynx8e+ih6CE4UPS68s1iW8A6SP9K67xpl0id8 rz9uVw/wBjIeGOQNEwahP7ibyeabM5WqWnSQtFUg35F0ZU9k/E4xHqqL+oQmuv+zc3RK G9DyIVU+9DC/KZ1nqFa+ETtMtnlzvJdd2grOmWZo85wVlcEXrMuKc6DkTNaCXh84eJiv PAYyb+yAqfb9WRIx14ikqF+eCGbBPRog9qgWp2hvG7ZWSCSRhmaSPLJMoafdNRKstdWe hM5MEA1P9d3mjxKbWHT527+zWTxSoZLaPidAA8qn9uush5ccRs8ds/5yp1GEp0FRFDLu InHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :dlp-version:dlp-reaction:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=bqgVvHYYZEbQhtiGSyQiRc4GTe18D/WC4vskfaZCwkw=; b=lChguJe3vd2XcGiMLr6ag56KU4uM5YfCnoGOXBeFFvBaa+FIYSYEIAeBvgLE7bjruz yNQBZQ5ltYvHfv588wMEBux8uDEaOJi0rhV/xQOKv1siuoKpIVFcoxAzsBJmnXn8EQbx YTpWuU2R8Fxp2n09IS+FKdRvXb2axlzhGnFAiImfTflOmHySCJIVSLhZGR3mquRoWPXv JroWu/19BvFhXvu5NKG4jutt4rkmBtyQd9Ty5P9x7lYCQwxYtQxDvunx6WHsHU37X910 r69Kbb7P03bKWEooJc9G898Wqs1KpMzmMkVf4NmYe4grMUVhj/UFbyPyhtd8qQWni08g 9a0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k9si3898955edv.565.2021.10.20.08.12.09; Wed, 20 Oct 2021 08:12:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbhJTPJP convert rfc822-to-8bit (ORCPT + 99 others); Wed, 20 Oct 2021 11:09:15 -0400 Received: from mga12.intel.com ([192.55.52.136]:51232 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbhJTPJO (ORCPT ); Wed, 20 Oct 2021 11:09:14 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10143"; a="208902821" X-IronPort-AV: E=Sophos;i="5.87,167,1631602800"; d="scan'208";a="208902821" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 08:06:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,167,1631602800"; d="scan'208";a="551674637" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga004.fm.intel.com with ESMTP; 20 Oct 2021 08:06:59 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 20 Oct 2021 08:06:58 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 20 Oct 2021 08:06:58 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2242.012; Wed, 20 Oct 2021 08:06:58 -0700 From: "Luck, Tony" To: Smita Koralahalli , "x86@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: "H . Peter Anvin" , "yazen.ghannam@amd.com" Subject: RE: [PATCH v2 2/5] x86/mce/inject: Warn the user on a not set valid bit in MCA_STATUS Thread-Topic: [PATCH v2 2/5] x86/mce/inject: Warn the user on a not set valid bit in MCA_STATUS Thread-Index: AQHXxUI8p9AjIXdBe0GwapWxUk7Kj6vb/UKQ Date: Wed, 20 Oct 2021 15:06:58 +0000 Message-ID: References: <20211019233641.140275-1-Smita.KoralahalliChannabasappa@amd.com> <20211019233641.140275-3-Smita.KoralahalliChannabasappa@amd.com> In-Reply-To: <20211019233641.140275-3-Smita.KoralahalliChannabasappa@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + if (!(i_mce.status & MCI_STATUS_VAL)) + pr_warn("Handlers might ignore signatures with Val=0 in MCA_STATUS\n"); I don't think there is any "might" about this. All code paths start by checking for MCI_STATUS_VAL and skipping if it isn't set. s/might/will/ -Tony