Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <ae9f553a-ce85-4537-7038-3f16bdf69cab@suse.de>
Date:   Wed, 20 Oct 2021 23:28:29 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH] bcache: use pr_err instead of pr_notice if we are really
 error
Content-Language: en-US
To:     Lin Feng <linf@wangsu.com>
Cc:     linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
        kent.overstreet@gmail.com
References: <20211020021313.140414-1-linf@wangsu.com>
From:   Coly Li <colyli@suse.de>
In-Reply-To: <20211020021313.140414-1-linf@wangsu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/20/21 10:13 AM, Lin Feng wrote:
> In bcache we have:
> ./bset.c:			pr_notice("loop %u, %llu per us\n", size,
> ./super.c:	pr_notice("error %s: %s\n", dc->backing_dev_name, err);
> ./super.c:		pr_notice("invalidating existing data\n");
> ./super.c:		pr_notice("error %s: %s\n", ca->cache_dev_name, err);
> ./super.c:		pr_notice("error %s: %s\n", ca->cache_dev_name, err);
> ./super.c:			pr_notice("Timeout waiting for devices to be closed\n");
>
> and 3 sites with string 'error' are really error happening on device
> register.

It is fine to keep current dmesg level and message format.

Thanks.

Coly Li

>
> Signed-off-by: Lin Feng <linf@wangsu.com>
> ---
>   drivers/md/bcache/super.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index f2874c77ff79..18a2e4bea9c2 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1493,7 +1493,7 @@ static int register_bdev(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
>   
>   	return 0;
>   err:
> -	pr_notice("error %s: %s\n", dc->backing_dev_name, err);
> +	pr_err("%s: %s\n", dc->backing_dev_name, err);
>   	bcache_device_stop(&dc->disk);
>   	return ret;
>   }
> @@ -2338,7 +2338,7 @@ static int cache_alloc(struct cache *ca)
>   err_free:
>   	module_put(THIS_MODULE);
>   	if (err)
> -		pr_notice("error %s: %s\n", ca->cache_dev_name, err);
> +		pr_err("%s: %s\n", ca->cache_dev_name, err);
>   	return ret;
>   }
>   
> @@ -2397,7 +2397,7 @@ static int register_cache(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
>   
>   err:
>   	if (err)
> -		pr_notice("error %s: %s\n", ca->cache_dev_name, err);
> +		pr_err("%s: %s\n", ca->cache_dev_name, err);
>   
>   	return ret;
>   }