Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1618242pxb; Wed, 20 Oct 2021 08:34:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKWMhLCUHpRantjrVnImHoeARnZuRFoLoUKlsGF6syJSBxrXsIosgGZfsplMtn+bb/TSfn X-Received: by 2002:a17:90a:e7cc:: with SMTP id kb12mr687171pjb.182.1634744060890; Wed, 20 Oct 2021 08:34:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634744060; cv=none; d=google.com; s=arc-20160816; b=NtieLQg0UW9pTTYJgUMMMnCak4ZCREqvYBOn3hO0nkTc6SJS0chrrQhsiOholdAkaa Pk7lz4SZFIuMDzypwht0SCQzQ+KVBYlit/p/YUK3Eoc5hVU2Kf2GMM72Grdq7pftJq7X nx3NPMfo5KDniouv/l7jBJZfsWCuY5njaJHU4JOAvm6Hxr2HNrNkpi390LAu+jmIsK9i 4cbSlqlKRkbFZv2XLLZRCOY7i0AuyRbSDAI0vfghNIMLQ9Lw+wFhPZWC971NuaQyplvH +bQta2sRBZi7ZItY0IXi5mwfgVLA3jBz5cAz12/BDdIVVMfqpmIwXotTiSDw7su7yKM1 WU4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=6n8NSAGAdR/E7/nlXOnW3BNS7DML5NAqvD61l5QSC00=; b=WhXK3SvBOphu/N5c3PwXXRlDHjlX2LNSaotVeHZtlp6cvyJV5uQJ827ePjqxIeyChq PY5PA4JKpi2UmVbN4N+BSjoMHn4kduVB8/OO1rVRVURiO2cAXpfKKui3Ngq+lbR8+vqG k3pLbFj/YJF4IBFVWYLOHjY9r7e49YteKQ4ZoULioClt50SOObJ5ThuQtaVmD35jYbJ6 tg+29c8IkK7/Anrv/Fa7tuxstpwodz3+jLZXH2tHO4UaKcmkJPNr8vmddBSvR/sGPqET Etty34G2CUxK0Urd+Oti0gLQKGSVeIeJw+LP5BE1Uxgmv+QvSseAX2m5IdQvO0hoWkz/ RnfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g23si219949pgm.61.2021.10.20.08.33.51; Wed, 20 Oct 2021 08:34:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230192AbhJTPex (ORCPT + 99 others); Wed, 20 Oct 2021 11:34:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:53454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbhJTPew (ORCPT ); Wed, 20 Oct 2021 11:34:52 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB56D61373; Wed, 20 Oct 2021 15:32:36 +0000 (UTC) Date: Wed, 20 Oct 2021 11:32:34 -0400 From: Steven Rostedt To: Kalesh Singh Cc: surenb@google.com, hridya@google.com, namhyung@kernel.org, kernel-team@android.com, Jonathan Corbet , Ingo Molnar , Shuah Khan , Masami Hiramatsu , Tom Zanussi , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 1/5] tracing: Add support for creating hist trigger variables from literal Message-ID: <20211020113234.45657902@gandalf.local.home> In-Reply-To: <20211020013153.4106001-2-kaleshsingh@google.com> References: <20211020013153.4106001-1-kaleshsingh@google.com> <20211020013153.4106001-2-kaleshsingh@google.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Oct 2021 18:31:38 -0700 Kalesh Singh wrote: > @@ -89,6 +91,8 @@ typedef u64 (*hist_field_fn_t) (struct hist_field *field, > #define HIST_FIELD_OPERANDS_MAX 2 > #define HIST_FIELDS_MAX (TRACING_MAP_FIELDS_MAX + TRACING_MAP_VARS_MAX) > #define HIST_ACTIONS_MAX 8 > +#define HIST_CONST_MAX 4 BTW, why is there a limit to the number of constants? -- Steve > +#define HIST_CONST_DIGITS_MAX 21 >