Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 1/2] fpga: dfl: afu: Clear port errors in afu init
To:     Tom Rix <trix@redhat.com>, <mdf@kernel.org>,
        <linux-fpga@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <lgoncalv@redhat.com>, <yilun.xu@intel.com>, <hao.wu@intel.com>,
        <matthew.gerlach@intel.com>
References: <20211019231545.47118-1-russell.h.weight@intel.com>
 <20211019231545.47118-2-russell.h.weight@intel.com>
 <e03a0a0a-74c3-9791-2603-523c2796a71d@redhat.com>
From:   Russ Weight <russell.h.weight@intel.com>
Message-ID: <cfcd0e62-aa51-3fdf-a6ce-75d8dad76b3f@intel.com>
Date:   Wed, 20 Oct 2021 09:02:29 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.13.0
In-Reply-To: <e03a0a0a-74c3-9791-2603-523c2796a71d@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmZTVWUyMmtmU1ZCYXkvQjJRazBGU3JqZGRqTUxWamhucDd4ZDBwSmxTKzBs?=
 =?utf-8?B?NjRhN2pndWdnYTlHYzcrb1RINGFzRVhmZXB1d0hWMnY3NlI5MXdmbXdiM2JI?=
 =?utf-8?B?WWN4dG5RZUthZ3BlRkdFVE1qd3hlbFRqRXVjYStIZWVRMlUwZFZkenJIZWd0?=
 =?utf-8?B?TDRZOGtTek8zQnd3VDZsRi9zVXNrbVJpa20zSTdQalBhZHZwMVVHMmM5OUZ2?=
 =?utf-8?B?alpocUtOMDhVZGxoekFkaUR3aUlqUnNhQlIvd0c2dnk5ZzNzV045dVE0RG5Y?=
 =?utf-8?B?cDEzbmFwMDM1UWJONE5TT3czSm5Jdjh5citkdlhtU2VCeHdvZDRtSFdpRml5?=
 =?utf-8?B?R2thdzlqQkdPTjZlQnBqV1UvTnJJZzN5M0pZaXhsQldxT2hjb2Nnbi9lQllR?=
 =?utf-8?B?MGJxdVhJQWFmN1RnYmhPYmwzb2dVWGxZMmcvQUxBNEE5ODB0b0hOdTdzY0Qv?=
 =?utf-8?B?SktQTmdIZHZVbG4rUzl4NFNjckx0ZkwvV3hVUHB5Qndwak0ydm1yOU1SVWRk?=
 =?utf-8?B?Qkc3cHZiY2FOTE8xVnB6YW8vd1UvWVZ3S2grZXI1cDU3eTVKVUNoQzlXTDEx?=
 =?utf-8?B?VjdWUWdha2lJblVEMmJSekF1aVNCWkQ3dFNvUHBZRFU0V29sS3hEeUFnTmoz?=
 =?utf-8?B?TXBYUWhZNExLOW1BeU1NcDgwOUJzMDZWeUpYNHo0UFpubEtVZjNkV09adTlE?=
 =?utf-8?B?b0ZtMkdlTmMySGpncTloK1RGais1c3JjVkN1UnJMOHYyeHloczBKL0duM0sw?=
 =?utf-8?B?VDQwSit6bDlGV3plczh2VlNtTCtEQTFTdXBuVnArNmdvYnBxZ3czSEtCVkNh?=
 =?utf-8?B?bWU3SG0vU3Urd3lWSTZCaEhGbzUrS3BYZVZRUjkzYW9VTFhJN2U1cW9FNDFG?=
 =?utf-8?B?QlJCODhUWGJoNzN5cExGR25WdTd0dkcvTVZCZXc0clRkSDFjTjlBazIxakkz?=
 =?utf-8?B?QzlXR25USHhHMXFuMkxmM1BKVGRvMGtLMkxIdnBIK0ZqT2k0Rk84bER4SGoy?=
 =?utf-8?B?WnhJQTA4VFF6a2hxdFEyN1Y4d1A3SE1KaVlIRWZ0bnVlVjJzY2VLUm93T1hD?=
 =?utf-8?B?VENFenVqejRnTDdMem9MOTlOU3ZBN1M0WVI4L2hONHMrY2duSkxVQW1GQkJa?=
 =?utf-8?B?Y3lFZERMbitpa1h5VWIzY3RDbTRLY0lROFg3ZWVxN1l6MUh0UTJHeTUxdG1k?=
 =?utf-8?B?SFpuRHZyemg3b1VWakxiaGs3Q1ZleUhpQ28zb3BhWEFnSWp0c2lJdmU5aFlF?=
 =?utf-8?B?QWFUSFRKbUZjSVdHU2NiNFEvZllxeXFZL3FYNlFBMDZobUFQQzFOMzlmMnlZ?=
 =?utf-8?B?b2h1VjNiUXczOFQyZWR3dG9sRGtoQjhmUUxRcE5EUkFhd1RxejZjeHNoSEtU?=
 =?utf-8?B?dFNrUXFPTHJrbDNJWVVuZVhXcmpZc08rTW1CQmx6V3hMTk1KdFJobVJKWk5h?=
 =?utf-8?B?aGtJV3VsTkg4Qlp2K3pLQThFTHNydy9RRHkxN1VPU3IrazFvUHFVclFQajZZ?=
 =?utf-8?B?dEJZOWQ1U3IvS3Y5b3VDQnZzREZHQkwzb3VqcGluR29PRUhxd2pLZ1REZ1JP?=
 =?utf-8?B?MjRON0Fma00wOTlSK0xwTjBTN2lITGpld1ZVMnJYcW00RFNwM2txZnZmWGNI?=
 =?utf-8?B?cnVPakIxZE5jQ014dnAwYkxLdUFibzVBQ1dQRHp0NGphdkt4dksvT1hOd2Uv?=
 =?utf-8?B?UnR4eEY5Y3FGM0s0WUJUTVplTFZSSDZDWkJwbGRUV0lwKzUwWi8rYWVqTjEv?=
 =?utf-8?Q?yV0SUDnmn2pJH0LXaVYIBwt13AdBFdcoKdexDeR?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b4376b66-53c8-4f52-c00d-08d993e2fe6e
X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5163.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 16:02:19.2249
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: russell.h.weight@intel.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3501
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/20/21 5:18 AM, Tom Rix wrote:
>
> On 10/19/21 4:15 PM, Russ Weight wrote:
>> When the AFU driver initializes, log any pre-existing errors and clear them.
>>
>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
>> ---
>>   drivers/fpga/dfl-afu-error.c | 26 ++++++++++++++++----------
>>   1 file changed, 16 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/fpga/dfl-afu-error.c b/drivers/fpga/dfl-afu-error.c
>> index ab7be6217368..0dc60bf49902 100644
>> --- a/drivers/fpga/dfl-afu-error.c
>> +++ b/drivers/fpga/dfl-afu-error.c
>> @@ -47,13 +47,13 @@ static void afu_port_err_mask(struct device *dev, bool mask)
>>   }
>>     /* clear port errors. */
>> -static int afu_port_err_clear(struct device *dev, u64 err)
>> +static int afu_port_err_clear(struct device *dev, u64 err, bool clear_all)
>>   {
>>       struct dfl_feature_platform_data *pdata = dev_get_platdata(dev);
>>       struct platform_device *pdev = to_platform_device(dev);
>> +    u64 v, port_error, port_first_error;
> v is only used now by the read of PORT_HDR_STS, could v be changed to a more descriptive variable like hdr_sts ?
>>       void __iomem *base_err, *base_hdr;
>>       int enable_ret = 0, ret = -EBUSY;
>> -    u64 v;
>>         base_err = dfl_get_feature_ioaddr_by_id(dev, PORT_FEATURE_ID_ERROR);
>>       base_hdr = dfl_get_feature_ioaddr_by_id(dev, PORT_FEATURE_ID_HEADER);
>> @@ -88,16 +88,21 @@ static int afu_port_err_clear(struct device *dev, u64 err)
>>       __afu_port_err_mask(dev, true);
>>         /* Clear errors if err input matches with current port errors.*/
>> -    v = readq(base_err + PORT_ERROR);
>> +    port_error = readq(base_err + PORT_ERROR);
>>   -    if (v == err) {
>> -        writeq(v, base_err + PORT_ERROR);
>> +    if (clear_all || port_error == err) {
>> +        port_first_error = readq(base_err + PORT_FIRST_ERROR);
>>   -        v = readq(base_err + PORT_FIRST_ERROR);
>> -        writeq(v, base_err + PORT_FIRST_ERROR);
>> +        if (clear_all && (port_error || port_first_error))
>
> likely with clear_all that this dev_warn will over report.
>
> how about removing clear_all && from if-check ?
I think that would make it report more often? clear_all is only set
at the time that the driver initializes. With the current condition,
errors will only be logged when the driver loads, if and only if
there are actually errors to report.


>
>> +            dev_warn(dev,
>> +                 "Port Error: 0x%llx, First Error 0x%llx\n",
>> +                 port_error, port_first_error);
>> +
>> +        writeq(port_error, base_err + PORT_ERROR);
>> +        writeq(port_first_error, base_err + PORT_FIRST_ERROR);
>>       } else {
>>           dev_warn(dev, "%s: received 0x%llx, expected 0x%llx\n",
>> -             __func__, v, err);
>> +             __func__, port_error, err);
>>           ret = -EINVAL;
>>       }
>>   @@ -137,7 +142,7 @@ static ssize_t errors_store(struct device *dev, struct device_attribute *attr,
>>       if (kstrtou64(buff, 0, &value))
>>           return -EINVAL;
>>   -    ret = afu_port_err_clear(dev, value);
>> +    ret = afu_port_err_clear(dev, value, false);
>>         return ret ? ret : count;
>>   }
>> @@ -211,7 +216,8 @@ const struct attribute_group port_err_group = {
>>   static int port_err_init(struct platform_device *pdev,
>>                struct dfl_feature *feature)
>>   {
>> -    afu_port_err_mask(&pdev->dev, false);
>> +    if (afu_port_err_clear(&pdev->dev, 0, true))
>> +        afu_port_err_mask(&pdev->dev, false);
>
> There is a __afu_port_err_mask at the end of afu_port_err_clear so this call isn't needed.

The condition statements says to only clear the mask explicitly if afu_port_err_clear()
fails. If it succeeds, then the explicit call will not happen, because as you have
pointed out, afu_port_err_clear() clear the mask.

Thanks,
- Russ

>
> Tom
>
>>         return 0;
>>   }
>