Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211011012212.91357-1-osk@google.com> <YW2l5yTj2Adc+Kjz@robh.at.kernel.org>
In-Reply-To: <YW2l5yTj2Adc+Kjz@robh.at.kernel.org>
From:   Oskar Senft <osk@google.com>
Date:   Wed, 20 Oct 2021 12:49:36 -0400
Message-ID: <CABoTLcTgbSKVH5+RoBsUdTUMbm59ePCbHbuJiFDQ17yvU1azrw@mail.gmail.com>
Subject: Re: [PATCH v7 1/2] dt-bindings: hwmon: Add nct7802 bindings
To:     Rob Herring <robh@kernel.org>
Cc:     Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Rob

Thanks for the review comments!

> > +patternProperties:
> > +  "^channel@[0-3]$":
> > +    type: object
>
> I would move the 'additionalProperties' here. I think that's a bit
> easier to read.

Following the same thought, I also moved the 'additionalProperties' on
the top level up to above its 'properties'.

> blank line

Thanks, I added the missing blank lines. I'm not sure what I was thinking.

> > +            channel@0 { /* LTD */
> > +              reg = <0>;
> > +              status = "okay";
>
> Don't show status in examples.

Oh yes, you mentioned that before, I'm sorry. They're removed now.

I sent a PATCH v8 with the changes.

Oskar.