Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v6 1/2] dt-bindings: Add binding for Renesas 8T49N241
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        david.cater.jc@renesas.com, Michal Simek <michal.simek@xilinx.com>,
        Rob Herring <robh@kernel.org>
References: <20210913170436.243-1-alexander.helms.jy@renesas.com>
 <20210913170436.243-2-alexander.helms.jy@renesas.com>
 <CAMuHMdWZp=7sR+dTL0F8o61weLqqC3k1kkemm_PktvyK8+ONmw@mail.gmail.com>
 <CAMuHMdXq2NyBf539raFJSoWSGXnwxOAMWcVB_WV-=uf+kOs7rw@mail.gmail.com>
 <4f2f81a8-9a79-3211-5ec3-fa679c3e7bb9@renesas.com>
 <CAMuHMdXHkeOK+Bg10BCLDvTztV6+y9+OomBUiTAoa1+GCHRnvw@mail.gmail.com>
In-Reply-To: <CAMuHMdXHkeOK+Bg10BCLDvTztV6+y9+OomBUiTAoa1+GCHRnvw@mail.gmail.com>
From:   Alex Helms <alexander.helms.jy@renesas.com>
Message-ID: <f77449f2-9299-44d6-b49c-b0be687ea20c@renesas.com>
Date:   Wed, 20 Oct 2021 09:56:51 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emVoZ3dpY2pMZ21GUXhNM1ZxZEU4VHNqWE9VdHVlVDY3VEp3c1Z6ejJJNFlP?=
 =?utf-8?B?WVozMXJyMUROck5SOGRtcWhSQkhqVkQyNTBCWjd6SVAyVml3VDZpdUNkamNr?=
 =?utf-8?B?a2RtSDdHbTBsRzF4c0ZMWkVmbkcwM0dTYlZFZnhON01kQkZLZVpOWlk4MVFU?=
 =?utf-8?B?aHhaalZ5YkJIZmxLeVVlQURzTlhDNDlCRDJLZTZJNE5WbVROalVpeXJQYWFi?=
 =?utf-8?B?WGZhdlFzamZDWnNCSFBrSlNTQUZGMkhOZFJ1aVNlaHByZnFldzZFeEhiTHQ2?=
 =?utf-8?B?bW85bElNOElpbnpUNUVTSVVmODFHdDRqUnNEd3RRMUExdUtmV1BHNmY4ZkZW?=
 =?utf-8?B?OXo0WWpwdlEvd3lvSllJc0tTa0Z2ZGxNbkNjTjhwamZ5V3pjT2pIWWR6a2hC?=
 =?utf-8?B?RXBFd3NPUHVPM2J3VU01M1RhOHBWdlFWLys1WGhxN0s5bEI1c2I0bEVXR3po?=
 =?utf-8?B?TCsxTWhRYjJGT2NVdVJYblBBRHdRTWtIQlZOUDB3bmM3aGFYNU5odUl2VG42?=
 =?utf-8?B?c3ZJdW5Oa0dCczRkUlEvekVnNWNxV0V5b1djem5OcWhMVVU5LytFOFl1RjNB?=
 =?utf-8?B?TytqZkYrSzU5RnJuSXBFMDFzbDhjcXRJb3NwQ1ZlQldKOWx5QklzL1NlbGVT?=
 =?utf-8?B?dE9sOUhSL2pIeUx0N3ZNb2RxRDk2VW01blMyTnlXL2htTXFDYlcxWnowQjZJ?=
 =?utf-8?B?TU1IV2NZN2x5Rlh6dUJDY25XZWFvSGRIdU9nRTJKclJOQVR2Snp5T2g4elk4?=
 =?utf-8?B?a0tRQkR4WTZLQ1JnZE1NTGFlRXA4S3d0blR1eU1lcEwrVHNnZUJlcEUyNEU3?=
 =?utf-8?B?Vmw4VHlwQnI0eUFKTnB3Tk9sT3B2NThJQ2FlRWFwM1pFTFF4Z29VOUhwSVNB?=
 =?utf-8?B?WTdxZXhVY25PZllqa1FrVHhUZlB3NzZoQXdBaGtHNGVpRUhzczh0T3ZCOUR5?=
 =?utf-8?B?Szd0UmF5SC9FZGV2K2RQU1Y0MGFobW10NjlDSXBXdHdZcE9JaFRiRDlwU0dL?=
 =?utf-8?B?RjRXTzNyYzlUeXlUL1BWS085bUNpeEt4Lzg2R0dpY3plbWE1a2dwUXZ4bHBr?=
 =?utf-8?B?Znl5V2gwbjNweTQzL0JIVnZvcmR0a2owOEhNTnBIZlNxUFV6WXduTEh6NmdT?=
 =?utf-8?B?OVhSVFJPVHdaVjJ6Tk9kT3prbkc4Ui9NZEpvUDBHMit5WlAzd24zakJGRGcx?=
 =?utf-8?B?UW16STJUL09DNXB1cUNyNmR2dzVzU1pCek1DbzJuaS9ERHpoM1V5MzQ4NGxX?=
 =?utf-8?B?UkpnZkphdVUxektQNmxWNDJ3UGVIMENkYnpSUWZiaEpaK01tSUVIOTZETm54?=
 =?utf-8?B?cDdpcGN2aTBSNnZUdWF4R01GSTZDS1U1VW1MakJvcllScGxGZlJHUjNTU0pY?=
 =?utf-8?B?MkMzZlVpeEt0UCt1TlIyVG5hQk4rRGJwa0R5bE4veThza1dpTE9ydEVtL3dl?=
 =?utf-8?B?eXFPQy9YMlkwK2JvRGZFTzh4Z3dxelc2aUJzTUxpeXJkbDJYSHgvZmNpT1dE?=
 =?utf-8?B?enhSRVBYbjB1c2g1VURiTXJhUUdYUWlzcVhiTFBNQWJLYVVwZ3pEZW9WaTdM?=
 =?utf-8?B?WGJCZ2dLNkpjbmZoQ2YwaGJGa29PYkVEZ3ZEM2hrUmRFZCtCR1EzS20zNjNx?=
 =?utf-8?B?N1JUeWd6b3FOL25qRDU5eUpzcGhsRGpERlZ0RnNCaFpXdUZER2I4T2FJNHp3?=
 =?utf-8?B?TzFLa285RE93Qnp3R3JsWG84V2x1ZFIzNzZIUFZoVEMzd1dxZkM1TVJHZUk1?=
 =?utf-8?Q?LBIMvVtJH+Gl1Rg9ytc1Qn33VYC+olz1YENKgcs?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f0e68ac-1deb-4fbc-f2cc-08d993eaa0f2
X-MS-Exchange-CrossTenant-AuthSource: OSAPR01MB3892.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 16:56:58.3541
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XhlYk+JiKQD6cUyLIKIjN9FwKKnyw/xogYctA51vhaSIrRDB4w1HRBcUH8u1O1kjDpWRPq3jkfD+rWP3+AkWxQiLjTLMQcvI/eSBf8OKBg0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB4184
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Geert,

On 10/20/2021 1:20 AM, Geert Uytterhoeven wrote:
> Hi Alex,
> 
> On Tue, Oct 19, 2021 at 11:53 PM Alex Helms
> <alexander.helms.jy@renesas.com> wrote:
>> On 10/14/2021 5:16 AM, Geert Uytterhoeven wrote:
>>> On Wed, Oct 13, 2021 at 8:02 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>>> On Mon, Sep 13, 2021 at 7:05 PM Alex Helms
>>>> <alexander.helms.jy@renesas.com> wrote:
>>>>> Renesas 8T49N241 has 4 outputs, 1 integral and 3 fractional dividers.
>>>>> The 8T49N241 accepts up to two differential or single-ended input clocks
>>>>> and a fundamental-mode crystal input. The internal PLL can lock to either
>>>>> of the input reference clocks or to the crystal to behave as a frequency
>>>>> synthesizer.
>>>>>
>>>>> Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com>
>>>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>>>
>>>> Thanks for your patch!
>>>>
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/clock/renesas,8t49n241.yaml
>>>
>>>> BTW, do you plan to add interrupt and/or GPIO support later?
>>>
>>> To clarify, and I really meant to add:
>>>
>>>   interrupts:
>>>     maxItems: 1
>>>
>>> to the bindings now, and GPIO-related properties and subnodes later.
>>
>> Any additional features such as interrupts and GPIO properties would only be added if there is customer demand for such features. Since there is no interrupt support, does the "interrupts" item still need to be added to the yaml?
> 
> DT describes hardware, not software policy (or limitations of the driver).
> 
> Arguably that applies to both interrupts and GPIOs, but the latter is
> more complex to describe, while the former is a simple "interrupts"
> property.  It's not uncommon for board components to have their
> interrupt line wired to an SoC, even if the driver doesn't use it.

I understand what you are describing but I don't understand how it is relevant for this device. The device is a clock generator on the i2c bus. It has a few GPIOs that can be configured as outputs for specific events like loss of lock or loss of signal, but I don't understand why that matters. 8t49n241 is similar to the existing dt and driver silabs,si5351 which does not define any interrupts. In fact it seems their dt describes both hardware and software policy because it uses custom dt keywords for changing driver behavior such as "silabs,pll-source" or "silabs,drive-strength". So looking at other examples of similar drivers, I don't understand why the 8t49n241 driver needs to define an interrupt.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

-Alex