Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1740945pxb; Wed, 20 Oct 2021 10:47:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNPZd/6I3GN4shcqs2rHJPnVsFsBdQOh8pu2j695LjEFFYkaNDSp+7QRcjUJuEy/4mHbo6 X-Received: by 2002:a05:6a00:1a56:b0:44d:23ae:37dd with SMTP id h22-20020a056a001a5600b0044d23ae37ddmr453785pfv.8.1634752057769; Wed, 20 Oct 2021 10:47:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634752057; cv=none; d=google.com; s=arc-20160816; b=sGSPZywb7j4TQeGRHY/b/rP2WBZZsHOV76rrVSr7yzOlD7IOysQJSWF5c3uy5aA2XV sjUJJUK8RCZJhy0oIXpvnNuh7wtTY9q4THNZAUGBU9PWSCUCGt32eNXP0c9Qu+xfunWS sX951Qv6e/BXqJC4RdwCQxNSvuLw8r5mtGJtGwwa731ItXQfk5xB2a1O0ulWS+4EYUVL Kp4KVsQVdfOw1OUxLL1S/G5Gv+6JokXU2ZFP6PJVoIVGdTmsJQT4GK7+MlxvX28vOZ/I Pxns9h2XMUIeO1DaLfdwxCyQn2bsrY2eyY4lLRMGfqlgy2zU8oK2ddrZjlrr+lB+zuNo fuXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from; bh=W2Dmaw1x5vEQ/+RKPXOYP0kdOqUT2rP/sCvj8EQwTZY=; b=fohr+vtPlpTke0o0PO0XaYqnbJtQwS57hiDcpp8FJzDXrRax8SBSqjwTYtbljHdlDp K8W5U1SgHUMlBOn2CiEGDaXpRKUAsXo4zunpBuOi4Eg5U6fQdmJsIegO7OpVTlcT8tF4 vgHovnzted7xtZJX5JpP6UwGmzff8FN0C+lSrwIrDgai1O6y3o+pmTGCKK66bjPRiEv3 +YNeSpEJl+R5kP5PFXDSr3/wOErfQDPNsvvjuOL8BKxzwQkKtRkPGFe3UfwJ/4W1iDba pbXNgQr2/UnqFvL7Q4A+RZUDlZ3EEfIEcA6ovAPgA25XJEbKTWfnCtKBIsPIWtvwaqdD UHjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b3si3719204pgq.262.2021.10.20.10.47.21; Wed, 20 Oct 2021 10:47:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231293AbhJTRsK (ORCPT + 99 others); Wed, 20 Oct 2021 13:48:10 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:43558 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231359AbhJTRrk (ORCPT ); Wed, 20 Oct 2021 13:47:40 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]:50654) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mdFeX-00EwP4-Bx; Wed, 20 Oct 2021 11:45:25 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:47894 helo=localhost.localdomain) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mdFeV-001NdN-HO; Wed, 20 Oct 2021 11:45:24 -0600 From: "Eric W. Biederman" To: linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Al Viro , Kees Cook , "Eric W. Biederman" , David Miller , sparclinux@vger.kernel.org Date: Wed, 20 Oct 2021 12:44:02 -0500 Message-Id: <20211020174406.17889-16-ebiederm@xmission.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87y26nmwkb.fsf@disp2133> References: <87y26nmwkb.fsf@disp2133> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-XM-SPF: eid=1mdFeV-001NdN-HO;;;mid=<20211020174406.17889-16-ebiederm@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+PPL8dLrIlJ5bbcAk6ZNzCrUxBuSVPrlA= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa07.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01,XMNoVowels, XMSubLong autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5022] * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;linux-kernel@vger.kernel.org X-Spam-Relay-Country: X-Spam-Timing: total 487 ms - load_scoreonly_sql: 0.08 (0.0%), signal_user_changed: 12 (2.4%), b_tie_ro: 10 (2.0%), parse: 1.12 (0.2%), extract_message_metadata: 18 (3.7%), get_uri_detail_list: 1.53 (0.3%), tests_pri_-1000: 22 (4.6%), tests_pri_-950: 1.66 (0.3%), tests_pri_-900: 1.10 (0.2%), tests_pri_-90: 223 (45.8%), check_bayes: 221 (45.5%), b_tokenize: 6 (1.2%), b_tok_get_all: 6 (1.2%), b_comp_prob: 1.98 (0.4%), b_tok_touch_all: 204 (41.9%), b_finish: 0.95 (0.2%), tests_pri_0: 196 (40.3%), check_dkim_signature: 0.59 (0.1%), check_dkim_adsp: 2.5 (0.5%), poll_dns_idle: 0.69 (0.1%), tests_pri_10: 2.1 (0.4%), tests_pri_500: 7 (1.4%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH 16/20] signal/sparc32: In setup_rt_frame and setup_fram use force_fatal_sig X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Modify the 32bit version of setup_rt_frame and setup_frame to act similar to the 64bit version of setup_rt_frame and fail with a signal instead of calling do_exit. Replacing do_exit(SIGILL) with force_fatal_signal(SIGILL) ensures that the process will be terminated cleanly when the stack frame is invalid, instead of just killing off a single thread and leaving the process is a weird state. Cc: David Miller Cc: sparclinux@vger.kernel.org Signed-off-by: Eric W. Biederman --- arch/sparc/kernel/signal_32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/sparc/kernel/signal_32.c b/arch/sparc/kernel/signal_32.c index 02f3ad55dfe3..cd677bc564a7 100644 --- a/arch/sparc/kernel/signal_32.c +++ b/arch/sparc/kernel/signal_32.c @@ -244,7 +244,7 @@ static int setup_frame(struct ksignal *ksig, struct pt_regs *regs, get_sigframe(ksig, regs, sigframe_size); if (invalid_frame_pointer(sf, sigframe_size)) { - do_exit(SIGILL); + force_fatal_sig(SIGILL); return -EINVAL; } @@ -336,7 +336,7 @@ static int setup_rt_frame(struct ksignal *ksig, struct pt_regs *regs, sf = (struct rt_signal_frame __user *) get_sigframe(ksig, regs, sigframe_size); if (invalid_frame_pointer(sf, sigframe_size)) { - do_exit(SIGILL); + force_fatal_sig(SIGILL); return -EINVAL; } -- 2.20.1