Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1741070pxb; Wed, 20 Oct 2021 10:47:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2Y9eb5XCfa6jWyv1ATsspWY+Ev4UQYlLrHgWme5IlZxDOKsIf6uvw43OyJOR3oXN6NoC8 X-Received: by 2002:a17:90b:1e01:: with SMTP id pg1mr465088pjb.73.1634752064931; Wed, 20 Oct 2021 10:47:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634752064; cv=none; d=google.com; s=arc-20160816; b=NED1BDAEilBvYvKPcgOg52hvNUP3YkTolk2LQwHT8r8fRAWdgLlBRVvjIL/1JAqBAQ pZ+szwZaKUh0GepQFbMjtliWNze3oD79pPuzcn2rMdnlotPYJ/oaVQd0aJmIvUGnvI1i M4cBeDL38Mjge2I20tUYOiJpwVrwb4ljA/Q7x8pcyMtUIvPbpaBnmk/DD88MxEQpoTRa pgqNybZ7tu2Km7GXzQt09tq0em5GDy/L7oSXwGv2PzgCZi1UylwA9m4xLeu5trc3xSP0 2gdY1DFMaD7K/1WANk+hvDlUmrV23bhpXx3UnHxYcUPo5wO4vaV91ZvjXkG6kRYJbGs3 nQyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from; bh=+kKLfv/jIYbgW66y9MyriWDwrcbSgOeRPbQzDhoS/k4=; b=qXFxscc3KUi5OYrLlwq3NRNs9qAMw/+/uHWzxc97VwpoyqbhIbgCuSkOjjs3viMwSe zMDJPXL6i2IYIwOGuilrQkh+XKkSqTFVgjQGSRS/M7J/d0OmkViFyl4DkKphaVR3pS6K EWh+WPxWkBPV4NW0m1onRUNCD4THDVqngmZv4wtEUgQphgsnqk5Wb4Fz7E5iJxE5SjYc I1mgUfn8sNViLSIl+2JD7NC5MVpxrH+PW8JFIh/Q/8P42ht4dQB70NEwzr1Rdcpkzs4n vozZTOU8CccP4loKxa1VQaYyDRIltOd4oU2U/4VlZW82UGFyRu1U2UlqJcPbJy6pg5JI mA2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 25si3769840pfp.189.2021.10.20.10.47.31; Wed, 20 Oct 2021 10:47:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231308AbhJTRsP (ORCPT + 99 others); Wed, 20 Oct 2021 13:48:15 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:43642 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231326AbhJTRrp (ORCPT ); Wed, 20 Oct 2021 13:47:45 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]:50742) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mdFec-00EwQg-0r; Wed, 20 Oct 2021 11:45:30 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:47894 helo=localhost.localdomain) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mdFea-001NdN-DK; Wed, 20 Oct 2021 11:45:29 -0600 From: "Eric W. Biederman" To: linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Al Viro , Kees Cook , "Eric W. Biederman" Date: Wed, 20 Oct 2021 12:44:04 -0500 Message-Id: <20211020174406.17889-18-ebiederm@xmission.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87y26nmwkb.fsf@disp2133> References: <87y26nmwkb.fsf@disp2133> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-XM-SPF: eid=1mdFea-001NdN-DK;;;mid=<20211020174406.17889-18-ebiederm@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/OEXAIXYi4uLUgO8NYQ5LoOkPqvwiFiu8= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa03.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TooManySym_01,XMNoVowels,XMSubLong autolearn=disabled version=3.4.2 X-Spam-Virus: No X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5002] * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa03 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa03 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;linux-kernel@vger.kernel.org X-Spam-Relay-Country: X-Spam-Timing: total 368 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 3.9 (1.1%), b_tie_ro: 2.7 (0.7%), parse: 1.08 (0.3%), extract_message_metadata: 12 (3.3%), get_uri_detail_list: 1.84 (0.5%), tests_pri_-1000: 14 (3.9%), tests_pri_-950: 1.16 (0.3%), tests_pri_-900: 0.84 (0.2%), tests_pri_-90: 86 (23.5%), check_bayes: 85 (23.1%), b_tokenize: 5 (1.5%), b_tok_get_all: 5 (1.5%), b_comp_prob: 1.33 (0.4%), b_tok_touch_all: 70 (18.9%), b_finish: 0.86 (0.2%), tests_pri_0: 236 (64.1%), check_dkim_signature: 0.69 (0.2%), check_dkim_adsp: 1.71 (0.5%), poll_dns_idle: 0.27 (0.1%), tests_pri_10: 2.3 (0.6%), tests_pri_500: 7 (1.8%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH 18/20] exit/rtl8723bs: Replace the macro thread_exit with a simple return 0 X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Every place thread_exit is called is at the end of a function started with kthread_run. The code in kthread_run has arranged things so a kernel thread can just return and do_exit will be called. So just have the threads return instead of calling complete_and_exit. Signed-off-by: "Eric W. Biederman" --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- drivers/staging/rtl8723bs/include/osdep_service_linux.h | 2 -- 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index d494c06dab96..8e69f9c10f5c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -524,7 +524,7 @@ int rtw_cmd_thread(void *context) complete(&pcmdpriv->terminate_cmdthread_comp); atomic_set(&(pcmdpriv->cmdthd_running), false); - thread_exit(); + return 0; } /* diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 79e4d7df1ef5..0c357bc2478c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -2491,7 +2491,7 @@ int rtw_xmit_thread(void *context) complete(&padapter->xmitpriv.terminate_xmitthread_comp); - thread_exit(); + return 0; } void rtw_sctx_init(struct submit_ctx *sctx, int timeout_ms) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index 156d6aba18ca..2b9a41b12d1f 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -435,7 +435,7 @@ int rtl8723bs_xmit_thread(void *context) complete(&pxmitpriv->SdioXmitTerminate); - thread_exit(); + return 0; } s32 rtl8723bs_mgnt_xmit( diff --git a/drivers/staging/rtl8723bs/include/osdep_service_linux.h b/drivers/staging/rtl8723bs/include/osdep_service_linux.h index 3492ec1efd1e..188ed7e26550 100644 --- a/drivers/staging/rtl8723bs/include/osdep_service_linux.h +++ b/drivers/staging/rtl8723bs/include/osdep_service_linux.h @@ -45,8 +45,6 @@ spinlock_t lock; }; - #define thread_exit() complete_and_exit(NULL, 0) - static inline struct list_head *get_next(struct list_head *list) { return list->next; -- 2.20.1