Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1814423pxb; Wed, 20 Oct 2021 12:16:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxesQ92zpSGhSRloUugCeNRCDng37i5uBFxbI8P+DeF5b8dbBTF+649ICCryf2ATmN72Vhc X-Received: by 2002:a05:6402:268c:: with SMTP id w12mr1107689edd.376.1634757361576; Wed, 20 Oct 2021 12:16:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634757361; cv=none; d=google.com; s=arc-20160816; b=kKp0Tnwf+LJtdEHiNvIk+3vQb8vHAd16g6u/0/gr5+RBQ/Lvx20HbKmDjZupozuqT8 lChgFzUamZvJ6DIHXbi2gkWeug/OQymRJB3z3FreqSDU+1MRC8/vcxLsdQXfd3imw+Ig /VNb+iv4yVt7qr17HNchB5CYqMt5tpKddCZ7RaJGKiDq+pHxsOUQWoKpnWhf5A2DHW1v 2CylFhBz1RgdkK73hTAlZq1vc8ojAjS+qMenzk92+DKtmjKbaulItUaYZPuCzAZIPvoc 9MSQljA6CL+JSkezBzxtdFxTr46daJS6iRhtpk30lglckckhyr37WhNvdYP2NeqnD6US cipg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VT1ZnTWZw0jMkeN3fDOrnC1r/jUp1V3OZwD2nwImWMk=; b=vXX5V9e6rR9vUzwO0X5YA5Er+du6iXQ6zAaud58I+HCXiS1FubWBAzY/HStUSeZgEp 9AQ9XBqyme5xV2dxeYu9W6cDW8riOuR+DPFN38z+HiviBeysOH++USvEh+PoJYe6Guym FCUo6baA0jqm3TPEGzNq1dvNaQzQT+Pkkwk9EJEO/LXUda5hhgOwFfkyQEfzPc3qX1w0 /wzJpNMX4DWQan9wfp29EhWtc/LeC496ETeH8ORsjOZRZzWIHc09niy4dVtllcJbqvig yLkkyCv1TiGZSt8kDQlyEC4DOw2Gxc8Opu8Tt1lVTdjhUAAacj3nv3IXM3/L6NXq2Ii0 J5Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nre93T6M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o17si6225404edc.228.2021.10.20.12.15.35; Wed, 20 Oct 2021 12:16:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nre93T6M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231521AbhJTTNq (ORCPT + 99 others); Wed, 20 Oct 2021 15:13:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231433AbhJTTNp (ORCPT ); Wed, 20 Oct 2021 15:13:45 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEF6EC06174E for ; Wed, 20 Oct 2021 12:11:30 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id t11so16811404plq.11 for ; Wed, 20 Oct 2021 12:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VT1ZnTWZw0jMkeN3fDOrnC1r/jUp1V3OZwD2nwImWMk=; b=nre93T6MzHelf00EfakHYDHtu00QJEKItoSAkKHGP3gUTjHdigzheidpN0Cn+ghvKd LKWv2/OIotRWfXs/WCG7an5/vs5KygZtizL39PVLhD9YZOfqaFwrzigVA2RIjTye4bHE OWKNrjwp2iiSwr71nYKpU9JH0SPNhhNIbBfEw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VT1ZnTWZw0jMkeN3fDOrnC1r/jUp1V3OZwD2nwImWMk=; b=Ql+hcrkdqDjqIR4PKTQLNfdn8aka8PU3tp7RXwSFtnrFzXl1yabP+4HDgBo2UL6U1w JyuZ6Pe6ByxF4SLtAcLMHlBaJP5PDEsZsGKM4x6ZgnpXUkaJKuBdaOlbwHWAd62Oclgm MKbjQPYV+OznXKVm/05jc0enYlYTfP7Bbc8pzl65j+IJfSJKC7pXWaC+TL9UYZ4rUCfA GIWdl65mOy1mK9SQBYZsRen7hkVtuxiU1M3NF/uEksfwVsaLMnBxbgXahKo+5s2z7cpD EPf1olr5+byxqOcgCaYjQ1eM9AKJcIj+OtaouKg+rd4Ogzx9equfDz2xKYSWqNw5Yq5G xCEg== X-Gm-Message-State: AOAM53247mquZ7RR1NBt5/64eR14lpgR7xfdrGeqH11Pml2ezrVLwr7Z 2s8swzjoy9OSZZ6d5NRYRgWedw== X-Received: by 2002:a17:90a:e54d:: with SMTP id ei13mr950751pjb.65.1634757090342; Wed, 20 Oct 2021 12:11:30 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x13sm2869108pge.37.2021.10.20.12.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 12:11:29 -0700 (PDT) Date: Wed, 20 Oct 2021 12:11:29 -0700 From: Kees Cook To: Miguel Ojeda , Emese Revfy Cc: Masahiro Yamada , Michal Marek , Nick Desaulniers , Jonathan Corbet , linux-hardening@vger.kernel.org, Linux Kbuild mailing list , Linux Doc Mailing List , Dan Li , Ard Biesheuvel , Miguel Ojeda , James Morris , "Serge E. Hallyn" , Nathan Chancellor , linux-kernel , linux-security-module , llvm@lists.linux.dev Subject: Re: [PATCH 2/2] gcc-plugins: Remove cyc_complexity Message-ID: <202110201210.1F70546@keescook> References: <20211020173554.38122-1-keescook@chromium.org> <20211020173554.38122-3-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 20, 2021 at 07:48:55PM +0200, Miguel Ojeda wrote: > On Wed, Oct 20, 2021 at 7:35 PM Kees Cook wrote: > > > > - * Copyright 2011-2016 by Emese Revfy > > Perhaps we should Cc this address to give them notice. Good point; I'm in the habit of that happening automatically as Emese was a co-maintainer of the gcc-plugins. Sorry for the oversight here. > Reviewed-by: Miguel Ojeda Thanks! -- Kees Cook