Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Francesco Dolcini <francesco.dolcini@toradex.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Stefan Agner <stefan@agner.ch>, linux-serial@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        u.kleine-koenig@pengutronix.de,
        Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: [PATCH v2 1/2] serial: imx: fix detach/attach of serial console
Date:   Wed, 20 Oct 2021 21:26:42 +0200
Message-Id: <20211020192643.476895-2-francesco.dolcini@toradex.com>
In-Reply-To: <20211020192643.476895-1-francesco.dolcini@toradex.com>
References: <20211020192643.476895-1-francesco.dolcini@toradex.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PGH058uz8VqPa2JLn8aqDoXmtMdFAvxajVQMhh9A9THlhf1q0YjWhHaJvl7r?=
 =?us-ascii?Q?Wcscqmka+9X0ZOVsM7Fb/jV6x9Ib70shj3uBj+3jDdUsQtbAML0sohpUqopG?=
 =?us-ascii?Q?c4tjYpLKLVp/ZaqCWnKGMazQ8eDhQzeYtMh17uAbqLpkr7W3MeHJC/hIWbWs?=
 =?us-ascii?Q?VIR3V3eKvSwVseVpsRBbnhrqr7YYPvufnyDiMAfd7NNkrHP1K81wOFFAaiya?=
 =?us-ascii?Q?Vvuvrs21bgUkHKe3CB1wjAHon1uga0pi1V6sR+Gl3MgUo5cSHBTFvLDj53X9?=
 =?us-ascii?Q?qRV+8jpWbS2CIoLK0Sx412R9XXaTqXwS0FuvNz5pt+B/BLPaV08+FS3Tjrsr?=
 =?us-ascii?Q?Hlb0MjRqhrjCf3ZrB4uauLbDnR0ihOIBSCEd1fbMcAGqW4mIQN8XNTy8xyIF?=
 =?us-ascii?Q?2tsNJwbbOTQqX124gUpisiy9bao9DJYBpsn1WIe3r2US+AKKsVZwaqWJY8QE?=
 =?us-ascii?Q?1IigIWf2RvIUaYokj74lYwou1K89UpuAT1h75Wce6dTsI8M01wlC2VsKYRMw?=
 =?us-ascii?Q?HiJu4mZEDBrZ84uwVW2EcJhT7t6BWBxncykeU9Wl83+cu9uz2v3dqC1ouXhI?=
 =?us-ascii?Q?8FzTg4L4eik0XnR1V4wP6XZ/Z+96yo5j4NaGLSf8A6fpHwN80Cvk3eHNiL1u?=
 =?us-ascii?Q?/60Ak9ufTYw2QBYr52BmV1peMvFLW547NzPoVysmPXExYLFmv6tfPYWPl4Px?=
 =?us-ascii?Q?NT8thQqbQzccIQqb6edB/USuZ5aaMBm2ircDXoNYFCeUILG0dkpUgeB5iijC?=
 =?us-ascii?Q?k/M1HH68MPV/5tRKU+ReB00xlEYn3eFJsT3GTLpgFTenqi+RAyB0QiQqJJss?=
 =?us-ascii?Q?kPFXCrIRwCInkU2LtwjczhqGQupnOJBb4p0/O8+BxVCjve2fZItua4guR+H6?=
 =?us-ascii?Q?NKFILVIvh47TyLJzZ04GbcJ9g8i+nyL0Yh+NRc4y4CRXwsLvjv3XOB+B4Xt0?=
 =?us-ascii?Q?Lm4NQT/15g4rsxWenQ4OVz5A3v86w28lYSI9AeyGsMYjnaKpSnIV1NiJadNG?=
 =?us-ascii?Q?fAoutu1I7BpvdFC955UI6ds9MnqYZwMwbz0b6rpOekM4jFF3j0WQ6yYIfZxR?=
 =?us-ascii?Q?GOL8hx6eOphQw13IlJ/rgkl8UHrPGjS/IPp0l0ytmXaGozQ/ufSl8BArFZus?=
 =?us-ascii?Q?pm51AATnaY/F8WCGqt99KUhNlAJi7k+ZfvnMUlJp3Mji4f/YI7+16E076tnk?=
 =?us-ascii?Q?uTvw+Y8TPAPQ1hAZd9BCtVoWdR7BamHwKPNRJhw8HrAIJG/eN+beMZHGwW/y?=
 =?us-ascii?Q?tSHX+zy4m4trc/Fz3fM5AV57Vq68MqNnL1ar0vsjCuwypEWYcoPf+911Wb7V?=
 =?us-ascii?Q?hHLYpxhOFFhn2H1J3I0hzrBE?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e2b8b0e-bf6d-400d-1305-08d993ff9a21
X-MS-Exchange-CrossTenant-AuthSource: DBAPR05MB7445.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 19:27:06.2603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2HSwQIGZTXr72gtnSnNsE8KB+mUfE9/rXNLeXql4DUgeiNHbcJF0YBZWFw7CMvjdL9v8ZycAClxDoSS71auu1bNXAKEQIplg5FfugNceLm0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR05MB5947
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Stefan Agner <stefan@agner.ch>

If the device used as a serial console gets detached/attached at runtime,
register_console() will try to call imx_uart_setup_console(), but this
is not possible since it is marked as __init.

For instance

  # cat /sys/devices/virtual/tty/console/active
  tty1 ttymxc0
  # echo -n N > /sys/devices/virtual/tty/console/subsystem/ttymxc0/console
  # echo -n Y > /sys/devices/virtual/tty/console/subsystem/ttymxc0/console

[   73.166649] 8<--- cut here ---
[   73.167005] Unable to handle kernel paging request at virtual address c154d928
[   73.167601] pgd = 55433e84
[   73.167875] [c154d928] *pgd=8141941e(bad)
[   73.168304] Internal error: Oops: 8000000d [#1] SMP ARM
[   73.168429] Modules linked in:
[   73.168522] CPU: 0 PID: 536 Comm: sh Not tainted 5.15.0-rc6-00056-g3968ddcf05fb #3
[   73.168675] Hardware name: Freescale i.MX6 Ultralite (Device Tree)
[   73.168791] PC is at imx_uart_console_setup+0x0/0x238
[   73.168927] LR is at try_enable_new_console+0x98/0x124
[   73.169056] pc : [<c154d928>]    lr : [<c0196f44>]    psr: a0000013
[   73.169178] sp : c2ef5e70  ip : 00000000  fp : 00000000
[   73.169281] r10: 00000000  r9 : c02cf970  r8 : 00000000
[   73.169389] r7 : 00000001  r6 : 00000001  r5 : c1760164  r4 : c1e0fb08
[   73.169512] r3 : c154d928  r2 : 00000000  r1 : efffcbd1  r0 : c1760164
[   73.169641] Flags: NzCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
[   73.169782] Control: 10c5387d  Table: 8345406a  DAC: 00000051
[   73.169895] Register r0 information: non-slab/vmalloc memory
[   73.170032] Register r1 information: non-slab/vmalloc memory
[   73.170158] Register r2 information: NULL pointer
[   73.170273] Register r3 information: non-slab/vmalloc memory
[   73.170397] Register r4 information: non-slab/vmalloc memory
[   73.170521] Register r5 information: non-slab/vmalloc memory
[   73.170647] Register r6 information: non-paged memory
[   73.170771] Register r7 information: non-paged memory
[   73.170892] Register r8 information: NULL pointer
[   73.171009] Register r9 information: non-slab/vmalloc memory
[   73.171142] Register r10 information: NULL pointer
[   73.171259] Register r11 information: NULL pointer
[   73.171375] Register r12 information: NULL pointer
[   73.171494] Process sh (pid: 536, stack limit = 0xcd1ba82f)
[   73.171621] Stack: (0xc2ef5e70 to 0xc2ef6000)
[   73.171731] 5e60:                                     ???????? ???????? ???????? ????????
[   73.171899] 5e80: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.172059] 5ea0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.172217] 5ec0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.172377] 5ee0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.172537] 5f00: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.172698] 5f20: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.172856] 5f40: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.173016] 5f60: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.173177] 5f80: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.173336] 5fa0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.173496] 5fc0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.173654] 5fe0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.173826] [<c0196f44>] (try_enable_new_console) from [<c01984a8>] (register_console+0x10c/0x2ec)
[   73.174053] [<c01984a8>] (register_console) from [<c06e2c90>] (console_store+0x14c/0x168)
[   73.174262] [<c06e2c90>] (console_store) from [<c0383718>] (kernfs_fop_write_iter+0x110/0x1cc)
[   73.174470] [<c0383718>] (kernfs_fop_write_iter) from [<c02cf5f4>] (vfs_write+0x31c/0x548)
[   73.174679] [<c02cf5f4>] (vfs_write) from [<c02cf970>] (ksys_write+0x60/0xec)
[   73.174863] [<c02cf970>] (ksys_write) from [<c0100080>] (ret_fast_syscall+0x0/0x1c)
[   73.175052] Exception stack(0xc2ef5fa8 to 0xc2ef5ff0)
[   73.175167] 5fa0:                   ???????? ???????? ???????? ???????? ???????? ????????
[   73.175327] 5fc0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ????????
[   73.175486] 5fe0: ???????? ???????? ???????? ????????
[   73.175608] Code: 00000000 00000000 00000000 00000000 (00000000)
[   73.175744] ---[ end trace 9b75121265109bf1 ]---

A similar issue could be triggered unbinding/binding the serial console
device [*].

Drop __init so that imx_uart_setup_console() can be safely called at
runtime.

[*] https://lore.kernel.org/all/20181114174940.7865-3-stefan@agner.ch/

Fixes: a3cb39d258ef ("serial: core: Allow detach and attach serial device for console")
Signed-off-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 drivers/tty/serial/imx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 8b121cd869e9..51a9f9423b1a 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -2017,7 +2017,7 @@ imx_uart_console_write(struct console *co, const char *s, unsigned int count)
  * If the port was already initialised (eg, by a boot loader),
  * try to determine the current setup.
  */
-static void __init
+static void
 imx_uart_console_get_options(struct imx_port *sport, int *baud,
 			     int *parity, int *bits)
 {
@@ -2076,7 +2076,7 @@ imx_uart_console_get_options(struct imx_port *sport, int *baud,
 	}
 }
 
-static int __init
+static int
 imx_uart_console_setup(struct console *co, char *options)
 {
 	struct imx_port *sport;
-- 
2.25.1