Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp34512pxb; Wed, 20 Oct 2021 15:55:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzy1SkRt96j0zwMLq0WOrO/pdKHbgRIKiTGLT7kMSjavCn9LOOS7zK5US1Lfq/LEpAckaM6 X-Received: by 2002:a17:90a:cc0d:: with SMTP id b13mr2074768pju.190.1634770505647; Wed, 20 Oct 2021 15:55:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634770505; cv=none; d=google.com; s=arc-20160816; b=a+lW6HuRHIGPgrZkuY83vp+iAQjs4jbxxJdUdyKticC/AIwJ489mHDZcGwhWiUnI1j RNC5l/VR65jL71VjpKQn7Eo1cGdNWweUnngUeTuaVOK6IFzJM9r8PSBJq99HnY3ARP11 DZGHgWR+PCtbLEY/jLkuvjn6HW6CngcIKOqLGYC3w76nl0L8iwud7UltSwYHxvTTNpZ7 Z9ehxdJinEw5cvL59o8DcF0Sq5NMEZ8CXoK+a6E6xI+uiIY1wi/WLqJrSPehYrW8kQK7 K4i0QX2zN09ytp72IO2vu9+LgiSXFJWo874yDes0molfc1oe/Dlyk9aVor9QhRQAWGWG 1eGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=lSsjbOQwefFnogmBYkQShNyvBodWyjPRyIlY4BZCdbY=; b=P6fyRWqMOZIizVlMlzEnOG0j2sz+hswUUhEdBvC9vz/2JIE75kznTjX3veNR+rUlBi SI8pP3bxO1ZwaxU+NLLS0nf242sOqSt4+DErNL+LyQJaQnt3YIvv4ZkxnZBLWZ6uQygS dI14JmjRXM7EMxWJ3svgMPg/fFwhfQXO+IuwRx9G3tbFA7MZaX7mHclfnMHD+I5QiRnR ufOi50311nbeqopeSm/JjCIra77lpKrmmE/nW5nPsIVfMcviruFA6Dt/6LtcnIR/T6eg gi3y4bXJRikGDeKx1+flWxbC2qcf9TeJvggd9vUgoF2clh6Ex54e54fx36floT370kio ouWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=XTFPUQpI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l8si5209806pfd.212.2021.10.20.15.54.35; Wed, 20 Oct 2021 15:55:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=XTFPUQpI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231182AbhJTWwi (ORCPT + 99 others); Wed, 20 Oct 2021 18:52:38 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:42995 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230123AbhJTWwh (ORCPT ); Wed, 20 Oct 2021 18:52:37 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 722E55C0257; Wed, 20 Oct 2021 18:50:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 20 Oct 2021 18:50:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=lSsjbO QwefFnogmBYkQShNyvBodWyjPRyIlY4BZCdbY=; b=XTFPUQpIgFUb5/+zQnC3+q E7iOxXZPkaMDV1LZeLMZHcNWaAPPNFYwJArhDaxHz04DhUA8SWNsm8dI1fjXUkgo 2soX9rJ7FjQLUmxi+xkJEsyrBs149cTEC9jikjMUNPsE8wF2gEZL8vJS7NftJADm heU+kExqUoInTXCuSLkwVKw26Kyj8tbG/GZi0cPRCatdUq55KdlqrDzW6THS6+v2 6XBYAugsRB6Ko7srZzO5hi79sgj7nuzYlRwxtg7FzDrA2XFWqzDDmLcoPQSOEGqI Ex8CTizCH4Y3S9yAXbSIGIvvhCM8LzL1gjBQyNZ/i7lAzj3T7VrD6A0OhkrwifNQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvhedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffujgfkfhggtgesthdtredttddtvdenucfhrhhomhephfhinhhnucfv hhgrihhnuceofhhthhgrihhnsehlihhnuhigqdhmieekkhdrohhrgheqnecuggftrfgrth htvghrnhepffduhfegfedvieetudfgleeugeehkeekfeevfffhieevteelvdfhtdevffet uedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepfh hthhgrihhnsehlihhnuhigqdhmieekkhdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Oct 2021 18:50:18 -0400 (EDT) Date: Thu, 21 Oct 2021 09:50:26 +1100 (AEDT) From: Finn Thain To: James Bottomley cc: Jiapeng Chong , kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, martin.petersen@oracle.com, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: megaraid_mbox: return -ENOMEM on megaraid_init_mbox() allocation failure In-Reply-To: <670213ce9e6c3b625e9f8ed66b9fad8ea2843322.camel@linux.ibm.com> Message-ID: References: <1634640800-22502-1-git-send-email-jiapeng.chong@linux.alibaba.com> <2482854e18365087266c2f0907c1bbfd42bd2731.camel@linux.ibm.com> <670213ce9e6c3b625e9f8ed66b9fad8ea2843322.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Oct 2021, James Bottomley wrote: > > > > ... and arguably they would be correct. > > Well, yes ... that's why I don't want one "fix" that generates a > cascading sequence of further "fixes". > OTOH, if you don't "fix" it, it generates a cascading sequence of copy-and-paste antipatterns in new code, and poor training data for those of us reading old code. Anyway, I agree that the churn would be too risky. But it sure would be nice if automatic tools were able to perform a program transformation of this kind at the source level, being that the compiler will surely do it anyway at a lower level. There's a lot to be said for source code that reflects the compiler's understanding of the logic, rather than the human's.