Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp52181pxb; Wed, 20 Oct 2021 16:19:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGcJ151FG3+5ZP/Su/EepP5/1T8QBxUPA60jqhYi1ir7+OkTENPtikUYuZ4VoK4NFAREY6 X-Received: by 2002:a05:6402:1778:: with SMTP id da24mr2619953edb.318.1634771940622; Wed, 20 Oct 2021 16:19:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634771940; cv=none; d=google.com; s=arc-20160816; b=cuvJlyK+BrD7qKu7yjQfVSecD+RT1yR2jsb0CVfcprTtT6qABvB+KkTto+cWQ0bpIP 8NyD2xfwbcVNKrAjgeRO4JBZcdzq+I4bH9W/c9LWib32Xz7nz8vmmcAdDIs646yWwbXf v/FBQbKoLbNul6k8O2zhOBXfBj6yETADfGA8Rp7u2HsVR0YrCBJeEXNQ6f0duLX3PHhU sMUr3b3dDQcv90BGjpH3yf6YAjlHWXTf/aKdbajUtbv9rPOIAZ8bWQgdV9ZiFxRXKYrG QJaQfZZNLUL3zO4xyjmP704AXJHhQu7h6rP/q4vmWxj05sQcgCyEIsXXqAaM32zKr0lq XItw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TW8PK7PaHwCGOJyjt24lOr9/bxwQDtAKYeeAErfznG8=; b=AGwQLwWY8hv8ejY8J4DBRgTXXfiHZK1TqdXUqQQqSXOt9JkyXpuOlMrXwf5ZqkCyfX CE8DvPFSaAUAkyLhwrIIdYAdJ6zmtR3Erm7IE3zq6f7gC92stNNS1KpvBAO/JTiDfPsg PFegq0lB+FnM//4toZMI4PQ1Cdf8oWSsBdRgu1CLDiB6YPRli8wwjaqf2Mx+1Ul/mG8v saWZ4vXd4Oo0XbemhfhJQVf5U3Y5DlSZRqOM8mzTozYZz3l2bg1dFjAQrGYz4Ce+Avo6 Wd5v62VlPRc1vjx2oRLm5ONMIbw8KPclLJhmPoPSci1SNx5elrBVXtodDQzDNsheObEE Njng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DuiD96fQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn12si5974305ejc.134.2021.10.20.16.18.35; Wed, 20 Oct 2021 16:19:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DuiD96fQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231182AbhJTXQq (ORCPT + 99 others); Wed, 20 Oct 2021 19:16:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:48328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229702AbhJTXQp (ORCPT ); Wed, 20 Oct 2021 19:16:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3FE85610A2; Wed, 20 Oct 2021 23:14:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634771670; bh=oi8a3JG/XkmKsI8mfGwa2zI65CTPnyciySVi1vE9Ta8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DuiD96fQvwo7N0m8LmOuS8+Hdz9ngko76+qhxxL2fxsJXaxpKzVtaYiPGQsfmlYGj gPMeHy1ITuu+kEC5Qi3LLDIF206EN3X7NGynD9mVS+1u3nLjlUuQ5k9IwpjXhSxOB8 VX0OTArOjQ12nYLnGhUWaCRnXFz/U+udE15+x8J3IbiBvlU9PC8DzeC/Gwn8SE4zfL IWxYHkZc/0jbT9uESoX3O9UxsIuA//e50GJJdYUM8Eu/NQeQPyHrSKNlQsZ90hnjOD CzJIgA0PlB23s8aVADlchl99MhNmJmenLIJoRjpLftDol6l/OLkgAv7kaHxYJSIgLy 6EVLMm3gnz3LA== Date: Wed, 20 Oct 2021 18:19:10 -0500 From: "Gustavo A. R. Silva" To: Jan Kara Cc: Len Baker , Alexander Viro , Kees Cook , linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] writeback: prefer struct_size over open coded arithmetic Message-ID: <20211020231910.GA1313548@embeddedor> References: <20210925114308.11455-1-len.baker@gmx.com> <20211020144044.GB16460@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211020144044.GB16460@quack2.suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 20, 2021 at 04:40:44PM +0200, Jan Kara wrote: [..] > > This code was detected with the help of Coccinelle and audited and fixed > > manually. > > > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments > > > > Signed-off-by: Len Baker > > Looks good. Feel free to add: > > Reviewed-by: Jan Kara > > BTW, writeback patches are usually merged by Andrew Morton so probably send > it to him. Thanks! I'm taking this in my -next tree. Thank you both, Len and Jan. -- Gustavo