Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 21 Oct 2021 09:36:32 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Huan Xie <xiehuan09@gmail.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>, mingo@redhat.com,
        chenhuacai@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace: Add trace any kernel object
Message-Id: <20211021093632.a197670625a6595d7082c9f8@kernel.org>
In-Reply-To: <CAEr6+EDf1hcm2SawO07+69KnBrODmiM05AqeeBwN+4wuyME=6w@mail.gmail.com>
References: <20211014014445.5734-1-xiehuan09@gmail.com>
        <20211013222056.312bec0c@oasis.local.home>
        <20211015220832.f9a13bd4ebbc4881b1e68163@kernel.org>
        <CAEr6+EDf1hcm2SawO07+69KnBrODmiM05AqeeBwN+4wuyME=6w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 21 Oct 2021 00:04:40 +0800
Huan Xie <xiehuan09@gmail.com> wrote:

> > > > For example:
> > > >
> > > > For the function bio_add_page, we can trace the first argument:
> > > >
> > > > int bio_add_page(struct bio *bio, struct page *page,
> > > >                             unsigned int len, unsigned int offset)
> > > >
> > > >     #cd /sys/kernel/debug/tracing
> > > >     #echo 1 > ./trace_object
> >
> > Hmm, so what happen if there are several events in parallel?
> >
> > > >     #echo 'p bio_add_page arg1=$arg1' > kprobe_events
> > > >     #echo 1 > ./events/kprobes/p_bio_add_page_0/enable
> >
> > what about adding a "objfilter" trigger action to update the object
> > list? e.g.
> >
> > echo objfilter:add:arg1:1 if comm == "sync" >> ./events/kprobes/p_bio_add_page_0/trigger
> >
> > This will "add the value of 'arg1' to objfilter 1 time if the process
> > name is sync".
> 
> Thanks. The trigger seems to work in combination with kprobe/uprobe/eprobe.
> 
> I have been trying to implement this feature in recent days, But my
> code does not look very elegant at the moment :-)

No problem! I can help you to brush up the coding :)

> It seems the result of 'cat  trace' should also need to be filtered,
> Because it will output the functions we don’t want to care about.

It actually depends on what object user wants to trace. e.g. network
packet trace will not be affected by 'cat trace'.
Anyway, we have "options/pause-on-trace" to stop tracing while
reading trace file. So user can choose it stop it or not. :)

> 
> I didn't expect this idea to be a relatively large project. :-)
> 

Because you have an exciting idea :)

Thank you,

-- 
Masami Hiramatsu <mhiramat@kernel.org>