Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp145800pxb; Wed, 20 Oct 2021 18:35:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGfaanLQgRp6DOBUy8FEPaCYoUvK7gfEnwSF8XIhBAt+iWtH3IzH8M3HIAhsS0stojSkvR X-Received: by 2002:a05:6a00:a8b:b0:44d:ef7c:94b9 with SMTP id b11-20020a056a000a8b00b0044def7c94b9mr2296378pfl.36.1634780141226; Wed, 20 Oct 2021 18:35:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634780141; cv=none; d=google.com; s=arc-20160816; b=J0H2Hph95pyJLFAjrPrnky2Yol+rNlSGW7RvwFdkYZjqw3vFWdmraNokdE45XmcYCr /KKk4EsRXftZIGOzOrdX4qjYYAp6N3tEZuXy/wEEXjSPE+AZQmfAOmdNx35N7xpeJaOZ YkdYFebsJVdnB4C1+F57ckkWrsTyAim29WHM8Tni0NT962ymS9uMsTc06f+MckleQ51M uVnWXlVRcyzcU5bjv0BeKKMwtbVXw/9g1z83xSrX7Seeo0ZLZyqoSgumAqDl7N9LLlg3 BuF8jTyOS/+/DGikMOaRfWeCAujjVMM8hjOWguWPdpQ7xKlFjxPXZMD/5MpsGtEeyOUE bALg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jBRehM56jaTPC4YFkHIP73ZOGOWMuo1++AATePLqtG8=; b=UHXxN/jfUM5OK6GXhHxV5hLhhSQzjiVmPOmhCvgBaG+Kj89rx7gIbDEuLrGLJth0jd LQT7aJEhAq1kJ5pI4xly/wsrXa9CtkSYUweJ51SIMnmUXwL0ahrZoc7Au9FUC5pscHqo VUztybjBn8I37Giu5+5uSOq4NZ0M2/XhTPYVjnEDH8COhCteVSOSRyLTq0o+wfJOBqs7 /80tc7a2TKE9dPv//BOc/xLCLi33Nwh7wN7njIo0ruVQrrOzMiVX4jKtUesCB6x9TVIH fU1vwSFodGVFZraRVAmmEuL0VcJi6e+oCZxcnYb253q8Fek/zSnwN2Fk1aHtb+pJwPBb kJQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t66si5006124pfd.319.2021.10.20.18.35.28; Wed, 20 Oct 2021 18:35:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbhJUBgq (ORCPT + 99 others); Wed, 20 Oct 2021 21:36:46 -0400 Received: from cmccmta3.chinamobile.com ([221.176.66.81]:10103 "EHLO cmccmta3.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbhJUBgp (ORCPT ); Wed, 20 Oct 2021 21:36:45 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.1]) by rmmx-syy-dmz-app12-12012 (RichMail) with SMTP id 2eec6170c3980c2-0f6a2; Thu, 21 Oct 2021 09:34:17 +0800 (CST) X-RM-TRANSID: 2eec6170c3980c2-0f6a2 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.112.105.130]) by rmsmtp-syy-appsvr01-12001 (RichMail) with SMTP id 2ee16170c395d66-33509; Thu, 21 Oct 2021 09:34:16 +0800 (CST) X-RM-TRANSID: 2ee16170c395d66-33509 From: Tang Bin To: krzysztof.kozlowski@canonical.com, vz@mleia.com, herbert@gondor.apana.org.au, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin , stable@vger.kernel.org Subject: [PATCH v3] crypto: s5p-sss - Add error handling in s5p_aes_probe() Date: Thu, 21 Oct 2021 09:34:22 +0800 Message-Id: <20211021013422.21396-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function s5p_aes_probe() does not perform sufficient error checking after executing platform_get_resource(), thus fix it. Fixes: c2afad6c6105 ("crypto: s5p-sss - Add HASH support for Exynos") Cc: Signed-off-by: Tang Bin Reviewed-by: Krzysztof Kozlowski --- Changes from v2 - add Cc: Changes from v1 - add fixed title --- drivers/crypto/s5p-sss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 55aa3a711..7717e9e59 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -2171,6 +2171,8 @@ static int s5p_aes_probe(struct platform_device *pdev) variant = find_s5p_sss_version(pdev); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; /* * Note: HASH and PRNG uses the same registers in secss, avoid -- 2.20.1.windows.1