Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Saurav Kashyap <skashyap@marvell.com>
To:     Zheyu Ma <zheyuma97@gmail.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        Javed Hasan <jhasan@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH] scsi: qedf: Fix return values of the probe function
Thread-Topic: [EXT] [PATCH] scsi: qedf: Fix return values of the probe
 function
Thread-Index: AQHXxb9uuNMPn5nJGkKEM22Ji9UpcKvc3CLQ
Date:   Thu, 21 Oct 2021 04:27:36 +0000
Message-ID: <DM6PR18MB3034F4D2FF41DA6D60674E27D2BF9@DM6PR18MB3034.namprd18.prod.outlook.com>
References: <1634740388-27238-1-git-send-email-zheyuma97@gmail.com>
In-Reply-To: <1634740388-27238-1-git-send-email-zheyuma97@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T1g208ttCz2hSOae9d0n2d+t4x36lHqnFh+H7zU99Z9MKuZ1AvLLzcD/9z6W?=
 =?us-ascii?Q?UlStWs0tw/zFKSkHrsGNwW395sFXgSyyemmggjTWG6M/n+VgLDc/WDqHox12?=
 =?us-ascii?Q?Y/83VblC4eGYfMYAO0r5WvrqoLKLBaaV4qOhxZWbiV+6mSEyoxQPW/+5T4dI?=
 =?us-ascii?Q?wU8W9JYJcvvW/CyUVNXBFybGTzRY0iNPWAFtxVVgiQ6oDl9y2u7KQx0LPTMI?=
 =?us-ascii?Q?5i9UweAxSaCA2UQr5Vi7Xp1u0CUbCgWulNqMaYSMaIFigq3H4dbs8ON1KPRv?=
 =?us-ascii?Q?zGkYm4tcL7hFRLYOa9ddMvJqMYHZUbxrpTJhBQh7ykuzNNVT0zEJfUOxf9kg?=
 =?us-ascii?Q?+DyMfFaJoxZfqMEsY1/XDNenQtetVE2HZ7W+BL40t4YI5QEKJe267osGeANH?=
 =?us-ascii?Q?yN2CBpTw4ZMvOCtMo0maOI62hGFXp17VIhkd449eMHuJO+7cVU2rby4j5cH3?=
 =?us-ascii?Q?AkiIUpT/Yp9qsenJglsCTu2hKa/VFmzqhLS0nXTp594xxRTjDAaGuY5B8BUu?=
 =?us-ascii?Q?8BfXbzGYh/i99daTH7iNv1C/Ufe5Kf1PaH+YK+u2h8VaUN0qQkQNiNNgMOXU?=
 =?us-ascii?Q?nX4bw4QWa2m7iWx82YrxXrpJZcvxY8snG7mYXDyf9461FWCUZqoJNIciTEEW?=
 =?us-ascii?Q?NTxQRtfY/2E3sjiVX04Mvhknc54jSb04Jc8Kq0Jabjauh//DGU5f5TjjBG69?=
 =?us-ascii?Q?rD7/tAhsxBdY29HJwIxm95jk8CqYvYsmoVDp+RfioOb3KKST9L9ICLZhJoW4?=
 =?us-ascii?Q?SA7CjW/ieMc8wLblDCtOkXhGITv03H/Ay4bKk+pqYk7pGKWl1VIpFxD66U1e?=
 =?us-ascii?Q?KJ6ezPzWV9m/poG3LfVZ6qCdFijRSKezd6jXa3Ox7izuSBcM+XPOrSzWmF+k?=
 =?us-ascii?Q?vrI5pLuOqnMIusNAlNjtcjJ1Zh+wkQmX8b3AkyQZ2I/hvcC4enfqfvVoWuoG?=
 =?us-ascii?Q?NI5CJkoPEnNZrGKeMjyZqKc6qgOqIGh4hkOTPTvCIeR5DWm9YXAdxK36UTHN?=
 =?us-ascii?Q?4a79MXXNPcsHWOrDxiks5ic51dXkqi68tWHkbFojdJfT2qRGtSC5tv3/ncG3?=
 =?us-ascii?Q?/QZ/A7JIvdxo3ucwCMYQVXRy1uGGrbjfEttHexLHgEgQxH+sPZabhFxc1ztb?=
 =?us-ascii?Q?nfvUb2muiAC+dPOHMMkKmcr292qHONxQwGcY7uhJ+m5OzXH7smXulCej16Cj?=
 =?us-ascii?Q?jm5UV5mcy5t2XwRDafeEWzKSWBTyVhiHK2UEKal7omK5Pv5o3DYsxZr76snB?=
 =?us-ascii?Q?XKI9LdrwXKPXqNU0G1BxwWD22R3Burm520jL/LPdijDCbgiEeqvr5faBR/Z+?=
 =?us-ascii?Q?TL9lt5rIwkSjVNRQcQ7NUKxu0OmGjB4R5C5HuWCPZ/MqJW2JHbG5qL6YKB2U?=
 =?us-ascii?Q?vI+XBkC0VbYPa3n1xjNBMid4pFzU?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB3034.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc427b5-9c7a-40f0-fa11-08d9944b1c21
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2021 04:27:36.3963
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: skashyap@marvell.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB2135
X-Proofpoint-ORIG-GUID: cnqadCe0JVBzc68zw-Q42oGrYotIa6N8
X-Proofpoint-GUID: 9NelQdZ98YTI_1mFFSQoS4gNJ17EcmDQ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-21_01,2021-10-20_02,2020-04-07_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Zheyu,
Thanks for the patch.

> -----Original Message-----
> From: Zheyu Ma <zheyuma97@gmail.com>
> Sent: Wednesday, October 20, 2021 8:03 PM
> To: jejb@linux.ibm.com; martin.petersen@oracle.com; Saurav Kashyap
> <skashyap@marvell.com>; Javed Hasan <jhasan@marvell.com>; GR-QLogic-
> Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Zheyu Ma
> <zheyuma97@gmail.com>
> Subject: [EXT] [PATCH] scsi: qedf: Fix return values of the probe functio=
n
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> qedf_set_fcoe_pf_param() propagates the return value to the probe
> function __qedf_probe() and then hits local_pci_probe().
>=20
> During the process of driver probing, the probe function should return < =
0
> for failure, otherwise, the kernel will treat value > 0 as success.
>=20
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> ---
>  drivers/scsi/qedf/qedf_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.=
c
> index 42d0d941dba5..52f2a52bea2c 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -3161,14 +3161,14 @@ static int qedf_set_fcoe_pf_param(struct qedf_ctx
> *qedf)
>=20
>  	if (!qedf->p_cpuq) {
>  		QEDF_ERR(&(qedf->dbg_ctx), "dma_alloc_coherent failed.\n");
> -		return 1;
> +		return -ENOMEM;
>  	}
>=20
>  	rval =3D qedf_alloc_global_queues(qedf);
>  	if (rval) {
>  		QEDF_ERR(&(qedf->dbg_ctx), "Global queue allocation "
>  			  "failed.\n");
> -		return 1;
> +		return rval;
>  	}
>=20
>  	/* Calculate SQ PBL size in the same manner as in qedf_sq_alloc() */
> --
> 2.17.6

Acked-by: Saurav Kashyap <skashyap@marvell.com>

Thanks,
~Saurav