Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <fcadd8a722eabf33638a234f3d1cb026977b35df.camel@perches.com>
Subject: Re: [v5 PATCH 3/6] mm: filemap: coding style cleanup for
 filemap_map_pmd()
From:   Joe Perches <joe@perches.com>
To:     Yang Shi <shy828301@gmail.com>, naoya.horiguchi@nec.com,
        hughd@google.com, kirill.shutemov@linux.intel.com,
        willy@infradead.org, peterx@redhat.com, osalvador@suse.de,
        akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 20 Oct 2021 23:19:00 -0700
In-Reply-To: <20211020210755.23964-4-shy828301@gmail.com>
References: <20211020210755.23964-1-shy828301@gmail.com>
         <20211020210755.23964-4-shy828301@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2021-10-20 at 14:07 -0700, Yang Shi wrote:
> A minor cleanup to the indent.
[]
> diff --git a/mm/filemap.c b/mm/filemap.c
[]
> @@ -3195,12 +3195,12 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page)
>  	}
>  
>  	if (pmd_none(*vmf->pmd) && PageTransHuge(page)) {
> -	    vm_fault_t ret = do_set_pmd(vmf, page);
> -	    if (!ret) {
> -		    /* The page is mapped successfully, reference consumed. */
> -		    unlock_page(page);
> -		    return true;
> -	    }
> +		vm_fault_t ret = do_set_pmd(vmf, page);
> +		if (!ret) {
> +			/* The page is mapped successfully, reference consumed. */
> +			unlock_page(page);
> +			return true;
> +		}

It might be more preferred to add a blank line after the automatic
when touching this block.