Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance
To:     Dongliang Mu <mudongliangabcd@gmail.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Vinod Koul <vkoul@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Zhang Qilong <zhangqilong3@huawei.com>
CC:     <dmaengine@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20211021030538.3465287-1-mudongliangabcd@gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <fe921832-79f9-7e6a-e1c5-a94b5d617435@nvidia.com>
Date:   Thu, 21 Oct 2021 07:57:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211021030538.3465287-1-mudongliangabcd@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 06:58:00.8312
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 58913f7a-a431-42e5-4be3-08d994601f28
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT037.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4291
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 21/10/2021 04:05, Dongliang Mu wrote:
> The previous commit 059e969c2a7d ("dmaengine: tegra210-adma: Using
> pm_runtime_resume_and_get to replace open coding") forgets to replace
> the pm_runtime_get_sync in the tegra_adma_probe, but removes the
> pm_runtime_put_noidle.
> 
> Fix this by continuing to replace pm_runtime_get_sync with
> pm_runtime_resume_and_get in tegra_adma_probe.
> 
> Fixes: 059e969c2a7d ("dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding")
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
>   drivers/dma/tegra210-adma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index b1115a6d1935..d1dff3a29db5 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -867,7 +867,7 @@ static int tegra_adma_probe(struct platform_device *pdev)
>   
>   	pm_runtime_enable(&pdev->dev);
>   
> -	ret = pm_runtime_get_sync(&pdev->dev);
> +	ret = pm_runtime_resume_and_get(&pdev->dev);
>   	if (ret < 0)
>   		goto rpm_disable;
>   
> 

Thanks!

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Jon

-- 
nvpublic