Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance in
 tegra_adma_remove
To:     Dongliang Mu <mudongliangabcd@gmail.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Vinod Koul <vkoul@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>
CC:     <dmaengine@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20211021031432.3466261-1-mudongliangabcd@gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <a0f51171-2a8b-b931-eb98-63e92fdf9dee@nvidia.com>
Date:   Thu, 21 Oct 2021 07:58:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211021031432.3466261-1-mudongliangabcd@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 06:58:57.2762
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c333981a-0586-4d6a-81c9-08d9946040cc
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT046.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2549
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 21/10/2021 04:14, Dongliang Mu wrote:
> Since pm_runtime_put is done when tegra_adma_probe is successful, we
> cannot do pm_runtime_put_sync again in tegra_adma_remove.
> 
> Fix this by removing the pm_runtime_put_sync in tegra_adma_remove.
> 
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
>   drivers/dma/tegra210-adma.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index b1115a6d1935..7e4d40cd9577 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -940,7 +940,6 @@ static int tegra_adma_remove(struct platform_device *pdev)
>   	for (i = 0; i < tdma->nr_channels; ++i)
>   		irq_dispose_mapping(tdma->channels[i].irq);
>   
> -	pm_runtime_put_sync(&pdev->dev);
>   	pm_runtime_disable(&pdev->dev);
>   
>   	return 0;
> 

Thanks!

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Jon

-- 
nvpublic