Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] blk-mq: Fix blk_mq_tagset_busy_iter() for shared tags
To:     Kashyap Desai <kashyap.desai@broadcom.com>, <axboe@kernel.dk>
CC:     <ming.lei@redhat.com>, <linux-block@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <hare@suse.de>
References: <1634550083-202815-1-git-send-email-john.garry@huawei.com>
 <2f09315210261e82c42a1353cab48dcd@mail.gmail.com>
From:   John Garry <john.garry@huawei.com>
Message-ID: <afdde2fe-21b3-2509-72fa-7f705338d8c7@huawei.com>
Date:   Thu, 21 Oct 2021 09:08:25 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <2f09315210261e82c42a1353cab48dcd@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/10/2021 19:49, Kashyap Desai wrote:
>> -----Original Message-----
>> From: John Garry [mailto:john.garry@huawei.com]
>> Sent: Monday, October 18, 2021 3:11 PM
>> To:axboe@kernel.dk
>> Cc:ming.lei@redhat.com;linux-block@vger.kernel.org; linux-
>> kernel@vger.kernel.org;kashyap.desai@broadcom.com;hare@suse.de; John
>> Garry<john.garry@huawei.com>
>> Subject: [PATCH v2] blk-mq: Fix blk_mq_tagset_busy_iter() for shared
> tags
>> Since it is now possible for a tagset to share a single set of tags, the
> iter
>> function should not re-iter the tags for the count of #hw queues in that
> case.
>> Rather it should just iter once.
>>
>> Fixes: e0fdf846c7bb ("blk-mq: Use shared tags for shared sbitmap
> support")
>> Reported-by: Kashyap Desai<kashyap.desai@broadcom.com>
>> Signed-off-by: John Garry<john.garry@huawei.com>
>> Reviewed-by: Ming Lei<ming.lei@redhat.com>
>> ---
>> Diff to v1:
>> - Add Ming's RB tag
> Now I noticed proper host_busy in my test. Still CPU hogging is not
> resolved, but issue addressed by this patch is resolved.
> 
> Tested-by: Kashyap Desai<kashyap.desai@broadcom.com>

Hi Jens,

Can you kindly consider picking up this patch?

I'm still waiting for feedback from Kashyap on whether we should 
optimize the other iter functions for shared tags, but this one is a fix.

Thanks!