Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 21 Oct 2021 10:39:15 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Francesco Dolcini <francesco.dolcini@toradex.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] serial: imx: disable console clocks on unregister
Message-ID: <20211021083915.4rpku6mtwzb2gqiv@pengutronix.de>
References: <20211020192643.476895-1-francesco.dolcini@toradex.com>
 <20211020192643.476895-3-francesco.dolcini@toradex.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="y6gglve2xlbipk5d"
Content-Disposition: inline
In-Reply-To: <20211020192643.476895-3-francesco.dolcini@toradex.com>
Precedence: bulk


--y6gglve2xlbipk5d
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 20, 2021 at 09:26:43PM +0200, Francesco Dolcini wrote:
> During console setup imx_uart_console_setup() enables clocks, but they
> are never disabled when the console is unregistered, this leads to
> clk_prepare_enable() being called multiple times without a matching
> clk_disable_unprepare() in case of console unregister.
>=20
> Ensure that clock enable/disable are balanced adding
> clk_disable_unprepare() in the console exit callback.
>=20
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--y6gglve2xlbipk5d
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmFxJyoACgkQwfwUeK3K
7AkNJAf/euBdQ/R/DwFToMZ2PjKFK7cGNOE5MVbNtUd6GHCCTI4dsP0Wu+AzU3Mb
9YzfAsZCe1htDW03TyouJxEwHHmHen6T9Qz06iJEp2LGPo/MXBRx3EggHHdT3oan
am7iWS+1rbfhiSSpy4eiA8ZJG7QTaHnONEI13J5Jd4wyqWVTZ2gh0dkpYsl45Wqe
ShJD5/uoMx4M4m7IM9KX1rTnNSJ0hVhmUIyQbnA6hOVCDfwgNBDm+vykxwiVLcUf
0Jx75AvbJhBnJwqKzKOYlw7LGQD57BvQcvXeunt5jYI4vFiuWDgLcFrllhOcP/+T
LDf65T8HQryYc8ZvkVLdt9QquJ3eKA==
=KhiM
-----END PGP SIGNATURE-----

--y6gglve2xlbipk5d--