Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] iio: adc: ina2xx: Make use of the helper macro
 kthread_run()
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211021083917.2024-1-caihuoqing@baidu.com>
From:   Lars-Peter Clausen <lars@metafoo.de>
Message-ID: <6699a823-b7b4-6453-aec0-95058b26c27f@metafoo.de>
Date:   Thu, 21 Oct 2021 10:48:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211021083917.2024-1-caihuoqing@baidu.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 10/21/21 10:39 AM, Cai Huoqing wrote:
> Repalce kthread_create/wake_up_process() with kthread_run()
> to simplify the code.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Hi,

Thanks for the patch, this looks good!

Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>

> ---
> [...]
>   	if (IS_ERR(task))
>   		return PTR_ERR(task);
>   
>   	get_task_struct(task);

This is unrelated to this patch. But I wonder do we really need the 
get_task_struct()? The driver calls put_task_struct() right after 
kthread_stop().

kthread_create()/kthread_run() and kthread_stop() already do reference 
counting of the task, so we are essentially just double reference 
counting. Maybe you can send another patch to cleanup the 
get_task_struct()/put_task_struct() in this driver.

> -	wake_up_process(task);
>   	chip->task = task;
>   
>   	return 0;