Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp412690pxb; Thu, 21 Oct 2021 01:57:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPFBsm7p/A23edkQwYB33jSs9DurMHTcowJ+4RFOQEm2maGXJcW6kFXrcLbBzvPTcuRmpt X-Received: by 2002:a05:6402:40d3:: with SMTP id z19mr5972548edb.393.1634806650743; Thu, 21 Oct 2021 01:57:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634806650; cv=none; d=google.com; s=arc-20160816; b=dY9kWJF8G7avcjc8AhnPLwH72qOuSU4/RLFOpCA23L2W/lYyPRiA2msY1stYFJJ2IV BfGCVIh7Q+4vwXB2BedWASJ/ajVBSh+oMfgkj6ZSggL/v8RBedCWNUDwRf+tKRwfoMtt gdcfF+HhJ6sWKePCYb63SGWHgMQ/Lwgp+1Jf+aQwqOL51022+erHKoWUdY2J1hBGnBQy d9gKVxbMKlsuQCqdUJKzmElkGwPli8I4RiHn7aWM8+InmizuV+lurcHqHBybEUuyWhX+ /kWnq5OyuILzNCAq7upJ8Eli+asZ/kLHf/qKc4OqMQ6L28Q3j4YRh0gI/QbW2unt6ol7 b5AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=TsTUaUN6UAZjto/Yd/hWLc73ukdwtGkHFVUFsfzhjq4=; b=XFPj5Mnn0QVojLrfKbLAZryycxE38pIt1YU9wryiUaQASh0MQTNtN8WmUFeIZ4baCe GMfAMER6sQfnxQG+z1kaWfCouJ93uQltK9ebcLHtwgmW5mMaocEGzig37Iw0BDcWdaQg HvsfZ1915zFaTpibLcrAeNuqMNv8SYQMvXgUT18Csr6hBadq0IU215nn4UQNd6hv3ZZI XHZUQ1i1rOYrhYDerDxh/k9n4zwCZx82OizYiMqn+Qf8CiVAW4tkH6J3B0t4OcrCOtSQ H39On1x3f5I4vA2ZFtMby7ClL8pqVh0wwc1/egIYOg5JsoRDiuIeSEbIBjcJu3FUrXzc BXKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=G3oBkKyz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p23si7674286edw.186.2021.10.21.01.57.07; Thu, 21 Oct 2021 01:57:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=G3oBkKyz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231502AbhJUIyV (ORCPT + 99 others); Thu, 21 Oct 2021 04:54:21 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:52466 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231336AbhJUIyG (ORCPT ); Thu, 21 Oct 2021 04:54:06 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1634806311; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=TsTUaUN6UAZjto/Yd/hWLc73ukdwtGkHFVUFsfzhjq4=; b=G3oBkKyzKz9Q3AYU09qhW3P/aAxd+EJZLWqwV3PBgWZpAS3a7urKJ18P2i0YhoNSoqBee8bh AEKQTEtdnFQreXXTUP1SIG/vJdLJYCIqmWofQrMW9y4CKeaOHzWbau61kWgwTE+ZbBCRYEG+ W1+5IoZvlEJt3DuY9Q0nTTkNHNE= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 61712a0e308e0dd330b1e035 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 21 Oct 2021 08:51:26 GMT Sender: skakit=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E37D9C43617; Thu, 21 Oct 2021 08:51:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: skakit) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3A2CAC4338F; Thu, 21 Oct 2021 08:51:25 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 21 Oct 2021 14:21:25 +0530 From: skakit@codeaurora.org To: Stephen Boyd Cc: Bjorn Andersson , Rob Herring , Lee Jones , Liam Girdwood , Mark Brown , Das Srinagesh , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mka@chromium.org, collinsd@codeurora.org, subbaram@codeaurora.org, kgunda@codeaurora.org Subject: Re: [PATCH V2 2/4] dt-bindings: mfd: pm8008: Add pm8008 regulator node In-Reply-To: References: <1633060859-22969-1-git-send-email-skakit@codeaurora.org> <1633060859-22969-3-git-send-email-skakit@codeaurora.org> Message-ID: <23abf3d093df63b1025e466f45ff16c6@codeaurora.org> X-Sender: skakit@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-10-05 23:40, Stephen Boyd wrote: > Quoting Satya Priya (2021-09-30 21:00:57) >> Add pm8008-regulator node and example. >> >> Signed-off-by: Satya Priya >> --- >> Changes in V2: >> - As per Rob's comments changed "pm8008[a-z]?-regulator" to >> "^pm8008[a-z]?-regulators". >> >> .../devicetree/bindings/mfd/qcom,pm8008.yaml | 24 >> ++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> index ec3138c..0c9665e 100644 >> --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml >> @@ -45,6 +45,10 @@ properties: >> const: 0 >> >> patternProperties: >> + "^pm8008[a-z]?-regulators$": > > Please just call it 'regulators' > >> + type: object >> + $ref: "../regulator/qcom,pm8008-regulator.yaml#" >> + >> "^gpio@[0-9a-f]+$": >> type: object >> >> @@ -122,6 +126,26 @@ examples: >> interrupt-controller; >> #interrupt-cells = <2>; >> }; >> + >> + pm8008-regulators { > > Please just call it 'regulators' > Okay >> + compatible = "qcom,pm8008-regulator"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + vdd_l1_l2-supply = <&vreg_s8b_1p2>; >> + vdd_l3_l4-supply = <&vreg_s1b_1p8>; >> + vdd_l5-supply = <&vreg_bob>; >> + vdd_l6-supply = <&vreg_bob>; >> + vdd_l7-supply = <&vreg_bob>; >> + >> + pm8008_l1: regulator@4000 { >> + reg = <0x4000>; >> + regulator-name = "pm8008_l1"; >> + regulator-min-microvolt = <950000>; >> + regulator-max-microvolt = <1300000>; >> + qcom,min-dropout-voltage = <96000>; >> + }; >> + };