Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CAMuHMdWD+FXt-rUz6oiU9MNq3EiKExgic17kCnUjynidii470w@mail.gmail.com>
References: <20211021030938.51884-1-tangbin@cmss.chinamobile.com> <CAMuHMdWD+FXt-rUz6oiU9MNq3EiKExgic17kCnUjynidii470w@mail.gmail.com>
Subject: Re: [PATCH] media: rcar_fdp1: Fix the correct variable assignments
From:   Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Tang Bin <tangbin@cmss.chinamobile.com>
Date:   Thu, 21 Oct 2021 10:08:43 +0100
Message-ID: <163480732348.2663858.5189176300885425535@Monstersaurus>
User-Agent: alot/0.9.1
Precedence: bulk

Hi Tang,

Quoting Geert Uytterhoeven (2021-10-21 08:59:18)
> Hi Tang,
>=20
> Thanks for your patch!
>=20
> On Thu, Oct 21, 2021 at 5:10 AM Tang Bin <tangbin@cmss.chinamobile.com> w=
rote:
> > In the function fdp1_probe(), when get irq failed, the
> > function platform_get_irq() log an error message, so
> > remove redundant message here. And the variable type
> > of "ret" is int, the "fdp1->irq" is unsigned int, when
> > irq failed, this place maybe wrong, thus fix it.
>=20
> The second issue is not actually present, as the error check
> operates on ret, not fdp1->irq?

Agreed, the error print is redundant.=20

In fact it would have erroneously print on ret=3D-EPROBE_DEFER cases too,
so it's not just redundant, but inaccurate too.

I don't think the assignment of fdp1->irq =3D ret at the same time is an
issue, because if ret < 0, fdp1->irq wouldn't ever get read, as the call
returns.

But .. I have no objection to setting it after instead.

> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>=20
> > --- a/drivers/media/platform/rcar_fdp1.c
> > +++ b/drivers/media/platform/rcar_fdp1.c
> > @@ -2289,11 +2289,10 @@ static int fdp1_probe(struct platform_device *p=
dev)
> >                 return PTR_ERR(fdp1->regs);
> >
> >         /* Interrupt service routine registration */
> > -       fdp1->irq =3D ret =3D platform_get_irq(pdev, 0);
> > -       if (ret < 0) {
> > -               dev_err(&pdev->dev, "cannot find IRQ\n");
> > +       ret =3D platform_get_irq(pdev, 0);
> > +       if (ret < 0)
> >                 return ret;
> > -       }
> > +       fdp1->irq =3D ret;
> >
> >         ret =3D devm_request_irq(&pdev->dev, fdp1->irq, fdp1_irq_handle=
r, 0,
> >                                dev_name(&pdev->dev), fdp1);
>=20
> Anyway, the code is correct, so:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Perhaps with the commit message updated/simplified, but either way:

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

>=20
> Gr{oetje,eeting}s,
>=20
>                         Geert
>=20
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6=
8k.org
>=20
> In personal conversations with technical people, I call myself a hacker. =
But
> when I'm talking to journalists I just say "programmer" or something like=
 that.
>                                 -- Linus Torvalds