Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 21 Oct 2021 10:15:15 +0100
From:   Stefan Hajnoczi <stefanha@redhat.com>
To:     Joe Perches <joe@perches.com>
Cc:     cgel.zte@gmail.com, mst@redhat.com,
        Denis Efremov <efremov@linux.com>,
        Julia Lawall <Julia.Lawall@inria.fr>,
        Gilles Muller <Gilles.Muller@inria.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>,
        Michal Marek <michal.lkml@markovi.net>, cocci@inria.fr,
        jasowang@redhat.com, pbonzini@redhat.com, axboe@kernel.dk,
        virtualization@lists.linux-foundation.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ye Guojin <ye.guojin@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] virtio-blk: fixup coccinelle warnings
Message-ID: <YXEvo5w6OzH3T0Tv@stefanha-x1.localdomain>
References: <20211021065111.1047824-1-ye.guojin@zte.com.cn>
 <b85fee5ff20d2b398948a6bccf1bcc5eb22b49ff.camel@perches.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="MKTZmaAbKHGPJEyk"
Content-Disposition: inline
In-Reply-To: <b85fee5ff20d2b398948a6bccf1bcc5eb22b49ff.camel@perches.com>
Precedence: bulk


--MKTZmaAbKHGPJEyk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 21, 2021 at 12:08:23AM -0700, Joe Perches wrote:
> On Thu, 2021-10-21 at 06:51 +0000, cgel.zte@gmail.com wrote:
> > From: Ye Guojin <ye.guojin@zte.com.cn>
> >=20
> > coccicheck complains about the use of snprintf() in sysfs show
> > functions:
> > WARNING  use scnprintf or sprintf
> >=20
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> []
> > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> []
> > @@ -624,7 +624,7 @@ cache_type_show(struct device *dev, struct device_a=
ttribute *attr, char *buf)
> > -	return snprintf(buf, 40, "%s\n", virtblk_cache_types[writeback]);
> > +	return sysfs_emit(buf, "%s\n", virtblk_cache_types[writeback]);
>=20
> Perhaps scripts/coccinelle/api/device_attr_show.cocci should be updated
> to be more like the script used in commit 1c7fd72687d6

This won't catch the case covered by the patch because it's
"snprintf(buf, 40" instead of "snprintf(buf, PAGE_SIZE", although
any size that's not PAGE_SIZE needs to be reviewed carefully in case the
intent of the statement is to truncate the output.

Stefan

--MKTZmaAbKHGPJEyk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmFxL6MACgkQnKSrs4Gr
c8js/wgAvvwLyhlzNHhPnOnKHV4zzRCS5mL7wTXIPYXRIuZLbmJe7cfyn2qfZtBE
o6KUg+EZMrSddh+yqN2A/D010ZKvothDHO+XHnjXjc1YEtD9gsUUTO0u4/3sjOwx
KZ04JmhYNuk3Q/KJNokoiqIQ4IYxx2g2puHbCXZBjoRwn2PQ5AmF5FmncmEOPaxy
0uK3v8fBNqBcYbaf759HJzAV3MfTV/kA+ybQIbTo/bt9iv8CVeM55kwPFqjGh0v2
/Lq0X45AKKRPF351kE7zO2F7/Bf4wVJEoeQVpct9rROwSNR52em6LuaRE5Q2s+ba
cVrOmOZTmCqirILmZ0Aqp+U8EnHEVA==
=qJkM
-----END PGP SIGNATURE-----

--MKTZmaAbKHGPJEyk--