Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] net: dsa: sja1105: Add of_node_put() before return
Date:   Thu, 21 Oct 2021 05:46:06 -0400
Message-Id: <20211021094606.7118-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5yTD858mm9RAoM95AS14IJzBrmvOyPLw5csu0RK7jkFGziBfqwdnVHXCqsyx?=
 =?us-ascii?Q?HCv3rrfYSRTcf639livXNnzInPXsyN8oqyuCnZvxdsZnmjPHUpihM1eFox4T?=
 =?us-ascii?Q?Q46l0NHU84jxzbh4YiXT36os+dc3ClFGRlt/1dGMPQ47A8ku5DiBU1ipWJXg?=
 =?us-ascii?Q?Oo4+n8M7+v1t3UBll0EgKI1lQuRzyZ5vDSIx7T5jWFnEC9FXZH8+2gqk7jzl?=
 =?us-ascii?Q?m9rPpV3h2n8YI+I6XNTXFypHoOA17of278+2YRFMYystiNb5LlzAP4Icmmfn?=
 =?us-ascii?Q?dALR3orzvcX2MW9YXnlNJnOx3B7+rf9MuYVadl0wHqrd1pT1IGF/lsBhA0Cm?=
 =?us-ascii?Q?8dAbrOlVwxy8YP7G3x/IiJ7IqNLvPd/l36cZZk46GFgW7ZbE2lm7mcaE8E/L?=
 =?us-ascii?Q?/qIGrJJWNJT1PHWcQQ4WVpeD3nn7sLyhFAKG+K//gBq40ITcg7HLAEVPNnh+?=
 =?us-ascii?Q?zOWmZP+nUdIKdaX7RpdvU764pCJe6yajHsT9GtWJ/gFbX2VNM99T6HsC4dFp?=
 =?us-ascii?Q?u8yfv3jbwAPAUjeMg8w7qO4C64CpN/YXmVOuUyNYhGcUhrEvXnUFXWUfBeQW?=
 =?us-ascii?Q?QPigGtbTIsmHFbHvFqkoE77zE7ZWW7LLuxcVBeiNvstsL4owAeo+TTGGNKXu?=
 =?us-ascii?Q?ymwatyS9zbOJflUAsCE1R/9Ik1w/Sym7JbaxJIX5kY4Ewctacosi3rrD8oW7?=
 =?us-ascii?Q?gqhFXMJqI/d0tbSy7pnFMPXvIpiLwftyFrVGeppkSxIWSPxYQfp5X5ogEMqi?=
 =?us-ascii?Q?MvhHy3AEcGrF8xXSsOxobzdB8WRNuxMrACVVGhkBIJFDSe0zvrS0zn5wRQxF?=
 =?us-ascii?Q?RZZmKd8JU25KQbfEjLmHS9DJVXzaRHXIhP6LcUawMafbwy24Mh4m/pzXqpZ3?=
 =?us-ascii?Q?Jf987T7KPXpIOWG4t3syfKD3THGZPVBuHhPv4/EtYjhsp0rw910lnyYPT/Z8?=
 =?us-ascii?Q?6HnYr2v5JP62Y+d/gZkd6mKQEgGwO3U9TtEL4z5eXmQp0eyb15za35IYFbEi?=
 =?us-ascii?Q?5UxW2VHLbo//FGMEL8kl5fcHGrz16GVczl2PZ3xRW3uzTXTt+2M8ZwJeFUdX?=
 =?us-ascii?Q?fogUP3Wy307DH1V+UnZWOqa4r92RmsgxDDM9tW0sCSJmdu0TQHUzGzGbz90I?=
 =?us-ascii?Q?RI9PdYVTgN3b6VurDScG5hR7Ws8LeWBXfN2qpjLW8iZ1B0P4xE82CGNO8EQg?=
 =?us-ascii?Q?lBPCbzYahAmdqiGEZP9cED27RJ7Eks4rocGGH03ZlT4C08JYC4ntX9rPgj2Z?=
 =?us-ascii?Q?KgpjP68xtkheAUW+TnsHiiNnKGnuiAD27UNmO5NZn/Gb4ytK5xqTxowBpYuL?=
 =?us-ascii?Q?zamye2Q/HE5i/ihyM6porbuJ?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f31210cb-1440-4822-b1a0-08d99477af9e
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 09:46:42.0256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 11126903@vivo.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3078
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/net/dsa/sja1105/sja1105_main.c:1193:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/net/dsa/sja1105/sja1105_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index 1832d4bd3440..70ece441b3b8 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -1233,8 +1233,10 @@ static int sja1105_parse_ports_node(struct sja1105_private *priv,
 		priv->phy_mode[index] = phy_mode;
 
 		err = sja1105_parse_rgmii_delays(priv, index, child);
-		if (err)
+		if (err) {
+			of_node_put(child);
 			return err;
+		}
 	}
 
 	return 0;
-- 
2.20.1