Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp448134pxb; Thu, 21 Oct 2021 02:49:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxy4FIzZtyatMJEgWgc4hGkC4zDdH3af/V4PGDngd7bw+1dQJJfUQRxbM4I+ozt/3T23Nw X-Received: by 2002:a17:902:ce86:b0:13f:16c5:c666 with SMTP id f6-20020a170902ce8600b0013f16c5c666mr4412523plg.88.1634809753724; Thu, 21 Oct 2021 02:49:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634809753; cv=none; d=google.com; s=arc-20160816; b=AHZXZdzLaLQHBLOPs5pxq47+pND0pbwhPqYWioDTPwT3ttGtE9urwJFPN8eSQfpAW5 u9dO+nNOjcJhecmyXc27DOBVMQ8fYxB4G+Xdyo1iGG5izpnxW7rZT8Pf5P8HVNFl/Jb/ 5vNT7LaaGViZyUaP6dpvze+K+i+5BR/aYOFdpzX3sEZqOvQRXZzyRa0P7OfcAoS0rJ34 CX3t9saVnn8qmVIEuIHli+m7GgfMRBZjH40HVtznHTyYvmThGHM+UL9yVAFYMH28kupF sx1hU+SbL1td0OSXcSxec5JTY8AnFj4Pfa1NQjEdXMqoi/NqrzXSBU6Y/5jAEjOOvgHG fXXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=p0lwLfCstIphgXtUacpoF59TciIXxsGmnHeCvpob+Lo=; b=Va7F/2R6swpGMFVpJbN515p70TfZyWTJ/nM9Mws0QNXDBAKrKmovqXySTlflAAuJzW uW3TuiUpUtP/r9IQITZdjjMdCNMP9jGLTELpHevzuzuj6FdrFipbZp3DQzrVoV6yYF3T stlbdebyx208/NXJV790oU+ybQDU9DIdrwpWcK4WIJ+MK0B5Py3DEIJpqfO5O8I9Y8rW DVFBIIivEgsfmYRlMBDgUb87axLLbsEjPZdWt9b/OMR87K+C1/DaNafj9KuxCW8Kv/il t/2LDNKCwth1wfnRY850q8rIrUkuR0RFCb4mKH+wADXBiNk2NmDb8YpSTqG0bKT1QlRe t61g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=IQoA3njD; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y15si6731642plr.103.2021.10.21.02.49.01; Thu, 21 Oct 2021 02:49:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=IQoA3njD; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231520AbhJUJsk (ORCPT + 99 others); Thu, 21 Oct 2021 05:48:40 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:57848 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231391AbhJUJsk (ORCPT ); Thu, 21 Oct 2021 05:48:40 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D8FFD1FDA8; Thu, 21 Oct 2021 09:46:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1634809583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p0lwLfCstIphgXtUacpoF59TciIXxsGmnHeCvpob+Lo=; b=IQoA3njDVRHZc2FEWC6PUzeolrZZjrkhVQrR50zsm0oK0mG7C6Gf9GYZrhtejnMyAGJ2Xu bas+9N1vRy0362Tr9upDY2oRJuaROdcjEGxZlpfM1lhVQspTWvKPML+OyC5V0ApuMYJ9oR IOy7t3B5jfa7c4QUBkjDKRMuGtXJihQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1634809583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p0lwLfCstIphgXtUacpoF59TciIXxsGmnHeCvpob+Lo=; b=11EfSLWriAORNeSEZKnRzbUiqIDRFrl9EnXMfU/SChC/HbzESw79aRZWx6Y9ofZBGn9JqW t4Hvxvj5jwaHqcBA== Received: from suse.de (unknown [10.163.32.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 3F790A3B85; Thu, 21 Oct 2021 09:46:23 +0000 (UTC) Date: Thu, 21 Oct 2021 10:46:21 +0100 From: Mel Gorman To: Vincent Guittot Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com Subject: Re: [PATCH v3 4/5] sched/fair: Remove sysctl_sched_migration_cost condition Message-ID: <20211021094621.GE3891@suse.de> References: <20211019123537.17146-1-vincent.guittot@linaro.org> <20211019123537.17146-5-vincent.guittot@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20211019123537.17146-5-vincent.guittot@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 19, 2021 at 02:35:36PM +0200, Vincent Guittot wrote: > With a default value of 500us, sysctl_sched_migration_cost is > significanlty higher than the cost of load_balance. Remove the > condition and rely on the sd->max_newidle_lb_cost to abort > newidle_balance. > > Suggested-by: Peter Zijlstra (Intel) > Signed-off-by: Vincent Guittot Acked-by: Mel Gorman -- Mel Gorman SUSE Labs