Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp448563pxb; Thu, 21 Oct 2021 02:49:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDKjESiFmGOIdUCWRKONILzI/J+tqwLhBE9hj/D7ekgA/GFAtPdHYk1y7tG0SvS/5fKBFG X-Received: by 2002:a17:90a:a085:: with SMTP id r5mr5460780pjp.8.1634809796683; Thu, 21 Oct 2021 02:49:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634809796; cv=none; d=google.com; s=arc-20160816; b=Bf7f8WNM6sxoHbPSdPx2ko0Pgo8c9V9dt6xcSDDVM6AXfDuBFPO5LnekkB7SvWxBX+ QVB3Pej4H2pvxjLpviBcgOmJb6TGrrn6sQE5f6Dr7OvwXxuCjfMQo/nv8CqUHv0aWnMs aFvIa3bwOMtIBi/FNhzhA6SVkVw7kxHBHX8EV0Vf21leMgj2DxYIRXZFTYBWSoieQKQ0 VvKRKNNDG/AkJnMjEl92tJNTfrnece7w9noT84eYcIdpPRg52YEdM/+PtGW7aLx8TNMR Wo3AGPR4QH0zK9rdag6Rji9/MN+Yx2lvylQIGofWsk+StkE4yWilhfoXXxk5t0PQWqKD dubA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=iL0FGkgQ+00vIDzyXvU4qGdZhYe9TsBrYAloXnNsW5c=; b=NN9CNsqcUkfegi1tH2LLTglfktb3O3bA4pK+76GsXl9yjiab9BkNCB1ft3GiEHmDwC KcUBQD+VT5w0IOHhynLaB7aJvEyOmh/ZLgVZ8R8lwC9q5+qyB/JxA5wG5JhXxpA7ojRG yj0Vgc/JBibNZgluk6jmsJ1S2OOji6lk7KeLkEBaHal+ZRwmRNquNsO0ckF0azXBjbE8 EuANRCbXkHV9Rbe6ws3tnArTh+dnZnRtrA9xZ8EEDAvdOL9jdVKDss0FRcqgmz3L2txP evr+gpvgO2wWLU2DfapoXWfAEKotYyiS+i8aM+vezjhzGUp29sKziETeBEUF3KlmWtSB jjqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QFBZTZp8; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=YFOsr2pE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t1si5504941pjr.165.2021.10.21.02.49.44; Thu, 21 Oct 2021 02:49:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QFBZTZp8; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=YFOsr2pE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231627AbhJUJtN (ORCPT + 99 others); Thu, 21 Oct 2021 05:49:13 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:45038 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231542AbhJUJtM (ORCPT ); Thu, 21 Oct 2021 05:49:12 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id EB27921989; Thu, 21 Oct 2021 09:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1634809615; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iL0FGkgQ+00vIDzyXvU4qGdZhYe9TsBrYAloXnNsW5c=; b=QFBZTZp8dgDLWkL3LnD/T2DUQOpApheTrDjxaTFd52sL8wXrDBwcqVywFgYDSBhKZJiwQn TBEtO32KdFaS5WnuCbPLV9aw7uE+TRrAbqvBlR5Ns4H3OK7evIhDX4pLOceWE1NFhUmHw3 gzc4MzXEJ4q8gaEkX7VoxkO1Wp/jZfE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1634809615; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iL0FGkgQ+00vIDzyXvU4qGdZhYe9TsBrYAloXnNsW5c=; b=YFOsr2pE1quQYA9N82FNUkP3kxA4aDjuYl252O/R5PZJvHTx44/DR0ZGW1s2OzCxOf3v3/ YXUsSbxuf+U27NBQ== Received: from suse.de (unknown [10.163.32.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5326BA3B81; Thu, 21 Oct 2021 09:46:55 +0000 (UTC) Date: Thu, 21 Oct 2021 10:46:53 +0100 From: Mel Gorman To: Vincent Guittot Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com Subject: Re: [PATCH v3 5/5] sched/fair: cleanup newidle_balance Message-ID: <20211021094653.GF3891@suse.de> References: <20211019123537.17146-1-vincent.guittot@linaro.org> <20211019123537.17146-6-vincent.guittot@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20211019123537.17146-6-vincent.guittot@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 19, 2021 at 02:35:37PM +0200, Vincent Guittot wrote: > update_next_balance() uses sd->last_balance which is not modified by > load_balance() so we can merge the 2 calls in one place. > > No functional change > > Signed-off-by: Vincent Guittot Acked-by: Mel Gorman -- Mel Gorman SUSE Labs